From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DFEC2222DD for ; Thu, 20 Mar 2025 22:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742508136; cv=none; b=VuvdXTv4JaSjC+w08bAauqUKHoDVqiwC8z/Mso20C+iT3HlTlcIxZ3taFj4AgKj6u7CDFd+4AmR5B4ADoA8w8P1RNJm/YpVMitmkhNo7qUbW5I0yT/TXduZ34zaQnObBfKKkueOtAMB3YOcam6Uy2I8xsaABmD1b+8NVK8ZHITc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742508136; c=relaxed/simple; bh=d7Ya1LHCdyWqJD4dFEE2qeC6cXP+snsY2+GnEOCqguE=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=KxY5GhOrjDyl1npKiL8ZQPooQQsqcNtGJiSED48Q/MzJhqpzUxL24HxrA2zScFwElV7QzqX3bfyeth0hj1z+cNAmxOmCfe2c4DbW/kpO8azrZte7wsRBGj5IEjwhGE8idzNy7QDKQQDgcvH+U9JILV35h9gN0lUE+WWQbhq84Qk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=RqdtWJtU; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="RqdtWJtU" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-476ac73c76fso14643321cf.0 for ; Thu, 20 Mar 2025 15:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1742508133; x=1743112933; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=jBZh6zpn6DRlrcZ7VEPN5EqgicdAyzcXvCF6SeotL1s=; b=RqdtWJtUJFwWLCWWVQskqWRqyTkNrKr2VuOEIBBU/696BmyLTBSV4YCSJnnI6+EWIJ eaLmwVkohnR9ca0+Z91WsdOs9lXgpT5nb2oBp/C+AKVwAifYQ9LEIVx0fAlaANRvNZ8l 0klRQTrO1EpHgm4NoXBRJQ8EzCKKT7t5U4c6ozCU5c/592h/aMAHlkXmVOnXvzsPFxzz 6PjK441ZrUnTzQ/Qk2Mf+v+j8di5D8ThTURfHdxCXH5MVynNthRrSneXpt/lBSTvBMde 2bv57iJZE4Ll/Wzr6iLtJiYy5vg6uaP794cVtA8hhHP+om7btTgCsPMNHz/FSGdwf7vm mFkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742508133; x=1743112933; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jBZh6zpn6DRlrcZ7VEPN5EqgicdAyzcXvCF6SeotL1s=; b=mU3/NG4ZTz1nG272/bu1hTYvHbcJUd/4ucOEhFoqEkwd75CIh6eo7Bg7plyerm8biQ jbR90TeZA8LXIUNqGUEcR4XYVmdJFpc+g/C4KRr6S/kV/xzGj3eqEUdfVFmramB3Ig26 qRBd3jwjYvlOxDdmufTrGGCoB9VE64kotSIPYm5GH7KsN6OSVz8UPNq9yqBxvyY7XO2n krdeYng7ejxHiteFFrBmt91iB10PgG/swfxUpggjWqFXeBiDoPS0DmhrkOfwDsDyHRCO 7eKSBBQ/cciTw57AhWlIaZPSg7LzrtcWZqqwfe7L3pWJK2pRafF6eo/eiJmFIDJoIQgN NAMQ== X-Forwarded-Encrypted: i=1; AJvYcCVQk6OSpumuk0lrHzteg/YLsE7jCveFpKTYKIlx21NJ+qrU62DWCWYavLw/3hygev8NYqVmMaU+74P7ogQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjy0R1nBdX2gEuxslaJkP967J3CRYTicM1bqnGuqW5NkfzpoxS 8smfaTG8qrpHtwciqIFkeK+bszqE1bffOP8pBkx8oMuavZWszb4fWO+dw+jI2KhBh/coHCITW8A = X-Gm-Gg: ASbGnctGW3DjDhw0WkQXCmUtagWpjS8DUndNqvNlAo4P3Juei5KM7GfeHr7tYgO2uRI wcUcfVVn8vyhvnA45kNSaWLlZ5uo3xkPswnuKkEaLx1Ni2y+xQxhg/MpnOeUKNHAWr6IAZlMGnD ucLRconJRcwVO5bevIaxxUP/wHXiw6P7YTC+TpoAcB4LcrRv/SRTKKO8ajNhWrOX9sl6Efn/zNG o4LJzotKfD1W6yKmk7NtgivR+zMtnjQkgr3z5lf4LU8pQl7SfC8MDYEqMq0BoONpzpdV/AjDt/d ZD1eOxNA68xpIxm+sPPPAgmkXmprhaLArRjue3w5o9/4SfgXP6k3rkLAockcJPZb5q6zOuljbee iRtoKYAM3xIkO2A== X-Google-Smtp-Source: AGHT+IEpTU+4E0FkwubwYokg6Ah9wbYKDgW5/Z1hnBycqv4qF/mtU8N7ku2JritQ36rrSIqLmxtbKQ== X-Received: by 2002:a05:622a:1f0a:b0:476:a74d:f23b with SMTP id d75a77b69052e-4771de62897mr15221101cf.48.1742508133366; Thu, 20 Mar 2025 15:02:13 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-4771d191ea6sm3608231cf.45.2025.03.20.15.02.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 15:02:13 -0700 (PDT) Date: Thu, 20 Mar 2025 18:02:12 -0400 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20250320_1749/pstg-lib:20250319_1956/pstg-pwork:20250320_1749 From: Paul Moore To: Andy Shevchenko , Casey Schaufler , audit@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Eric Paris , Andy Shevchenko Subject: Re: [PATCH v2 1/1] audit: Mark audit_log_vformat() with __printf() attribute References: <20250313085343.241623-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20250313085343.241623-1-andriy.shevchenko@linux.intel.com> On Mar 13, 2025 Andy Shevchenko wrote: > > audit_log_vformat() is using printf() type of format, and GCC compiler > (Debian 14.2.0-17) is not happy about this: > > kernel/audit.c:1978:9: error: function ‘audit_log_vformat’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format] > kernel/audit.c:1987:17: error: function ‘audit_log_vformat’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format] > > Fix the compilation errors (`make W=1` when CONFIG_WERROR=y, which is default) > by adding __printf() attribute. > > Signed-off-by: Andy Shevchenko > --- > v2: added necessary technical information to the commit message (Paul) > > kernel/audit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Merged into audit/dev-staging, this will move to audit/dev after the upcoming merge window. -- paul-moore.com