From: Paolo Bonzini <pbonzini@redhat.com>
To: Junaid Shahid <junaids@google.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 3/3] kvm: introduce manual dirty log reprotect
Date: Tue, 27 Nov 2018 11:11:55 +0100 [thread overview]
Message-ID: <c7f9b47a-092d-a977-cd89-96efe70d249b@redhat.com> (raw)
In-Reply-To: <bdb69ca7-1c35-6f92-c4ef-f82c0d4b788f@google.com>
On 27/11/18 06:04, Junaid Shahid wrote:
> There is a subtle point here which might be worth mentioning in a comment. [...]
You're absolutely right, it's subtle and should be mentioned.
>> @@ -2945,6 +3012,9 @@ static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
>> case KVM_CAP_IOEVENTFD_ANY_LENGTH:
>> case KVM_CAP_CHECK_EXTENSION_VM:
>> case KVM_CAP_ENABLE_CAP_VM:
>> +#ifdef CONFIG_KVM_GENERIC_DIRTYLOG_READ_PROTECT
>> + case KVM_CAP_MANUAL_DIRTY_LOG_PROTECT:
>> +#endif
> Shouldn't we also add this new CONFIG option to the Kconfig file?
>
It's already there. The new part is that if you are using it, you get
manual reprotection for free.
Paolo
next prev parent reply other threads:[~2018-11-27 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:54 [PATCH 0/3] kvm: split retrieval and clearing of dirty log Paolo Bonzini
2018-11-26 16:54 ` [PATCH 1/3] kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic Paolo Bonzini
2018-11-26 17:50 ` Cornelia Huck
2018-11-26 22:37 ` Junaid Shahid
2018-11-26 16:54 ` [PATCH 2/3] kvm: rename last argument to kvm_get_dirty_log_protect Paolo Bonzini
2018-11-26 22:49 ` Junaid Shahid
2018-11-26 16:54 ` [PATCH 3/3] kvm: introduce manual dirty log reprotect Paolo Bonzini
2018-11-27 5:04 ` Junaid Shahid
2018-11-27 10:11 ` Paolo Bonzini [this message]
2018-11-28 11:42 [PATCH v2 0/3] kvm: split retrieval and clearing of dirty log Paolo Bonzini
2018-11-28 11:42 ` [PATCH 3/3] kvm: introduce manual dirty log reprotect Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7f9b47a-092d-a977-cd89-96efe70d249b@redhat.com \
--to=pbonzini@redhat.com \
--cc=junaids@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®