mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	"Jim Mattson" <jmattson@google.com>,
	Joerg Roedel <joro@8bytes.org>, "H . Peter Anvin" <hpa@zytor.com>,
	<x86@kernel.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: SVM: fix svn_pin_memory()'s use of get_user_pages_fast()
Date: Mon, 29 Jun 2020 20:10:41 -0700	[thread overview]
Message-ID: <c7fa9c34-2d4e-9f1b-9afd-7f4132cdd35c@nvidia.com> (raw)
In-Reply-To: <87imgj6th4.fsf@vitty.brq.redhat.com>

On 2020-05-26 00:33, Vitaly Kuznetsov wrote:
...
> I bit unrelated to this patch, but callers of sev_pin_memory() treat
> NULL differently:
> 
> sev_launch_secret()/svm_register_enc_region() return -ENOMEM
> sev_dbg_crypt() returns -EFAULT
> 
> Should we switch to ERR_PTR() to preserve the error?
> 
>>   	/* Avoid using vmalloc for smaller buffers. */
>>   	size = npages * sizeof(struct page *);
>>   	if (size > PAGE_SIZE)
> 
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> 

Thanks for the review, Vitaly. If anyone is able to do any run-time
testing of this patch and also patch 2/2, then I think a maintainer
would be more willing to pick them up.

Any testing help there is greatly appreciated!


thanks,
-- 
John Hubbard
NVIDIA

  reply	other threads:[~2020-06-30  3:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  6:22 [PATCH 0/2] KVM: SVM: convert get_user_pages() --> pin_user_pages(), bug fixes John Hubbard
2020-05-26  6:22 ` [PATCH 1/2] KVM: SVM: fix svn_pin_memory()'s use of get_user_pages_fast() John Hubbard
2020-05-26  7:33   ` Vitaly Kuznetsov
2020-06-30  3:10     ` John Hubbard [this message]
2020-05-26  6:22 ` [PATCH 2/2] KVM: SVM: convert get_user_pages() --> pin_user_pages() John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7fa9c34-2d4e-9f1b-9afd-7f4132cdd35c@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=jrdr.linux@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®