mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment
Date: Thu, 3 Apr 2025 11:07:40 +0300	[thread overview]
Message-ID: <c7fd0bd4-4fc8-43f0-b980-b49472e76445@ideasonboard.com> (raw)
In-Reply-To: <20250331070200.3985562-1-andriy.shevchenko@linux.intel.com>

Hi,

On 31/03/2025 10:02, Andy Shevchenko wrote:
> The default for of_gpio_n_cells is 2, no need to assign the same
> in the user.

Where is this documented? I'm also having trouble finding the 
implementation.

  Tomi

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/media/i2c/ds90ub913.c | 1 -
>   drivers/media/i2c/ds90ub953.c | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c
> index fd2d2d5272bf..834df8d508e6 100644
> --- a/drivers/media/i2c/ds90ub913.c
> +++ b/drivers/media/i2c/ds90ub913.c
> @@ -216,7 +216,6 @@ static int ub913_gpiochip_probe(struct ub913_data *priv)
>   	gc->direction_output = ub913_gpio_direction_out;
>   	gc->set = ub913_gpio_set;
>   	gc->of_xlate = ub913_gpio_of_xlate;
> -	gc->of_gpio_n_cells = 2;
>   
>   	ret = gpiochip_add_data(gc, priv);
>   	if (ret) {
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 46569381b332..1cd5ac7157e4 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -420,7 +420,6 @@ static int ub953_gpiochip_probe(struct ub953_data *priv)
>   	gc->get = ub953_gpio_get;
>   	gc->set = ub953_gpio_set;
>   	gc->of_xlate = ub953_gpio_of_xlate;
> -	gc->of_gpio_n_cells = 2;
>   
>   	ret = gpiochip_add_data(gc, priv);
>   	if (ret) {


  reply	other threads:[~2025-04-03  8:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31  7:02 Andy Shevchenko
2025-04-03  8:07 ` Tomi Valkeinen [this message]
2025-04-03 10:58   ` Andy Shevchenko
2025-05-05  8:17     ` Sakari Ailus
2025-05-05 14:38       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7fd0bd4-4fc8-43f0-b980-b49472e76445@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®