From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Lv Ruyi <cgel.zte@gmail.com>
Cc: chi.minghao@zte.com.cn, davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
zealci@zte.com.cn
Subject: Re: [PATCH] net/nfc/nci: use memset avoid infoleaks
Date: Tue, 1 Mar 2022 11:24:02 +0100 [thread overview]
Message-ID: <c7fea223-b958-deea-70b2-a649e3cc0ec4@canonical.com> (raw)
In-Reply-To: <20220301093424.2053471-1-lv.ruyi@zte.com.cn>
On 01/03/2022 10:34, Lv Ruyi wrote:
> hello sir
>
> I think this way: On 64-bit systems, struct nci_set_config_param has
> an added padding of 7 bytes between struct members id and len. Even
> though all struct members are initialized, the 7-byte hole will
> contain data from the kernel stack.
>
That's reasonable. This explanation should be mentioned in the commit
msg. Also just initialize the array to 0, instead of separate memset call.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-03-01 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 8:17 cgel.zte
2022-03-01 8:20 ` Krzysztof Kozlowski
2022-03-01 8:33 ` Krzysztof Kozlowski
2022-03-01 9:34 ` Lv Ruyi
2022-03-01 10:24 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7fea223-b958-deea-70b2-a649e3cc0ec4@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®