mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Pavlu <petr.pavlu@suse.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Daniel Gomez <da.gomez@samsung.com>,
	linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Antipov <dmantipov@yandex.ru>
Subject: Re: [GIT PULL] Modules fixes for v6.15-rc6
Date: Sat, 10 May 2025 07:25:19 +0200	[thread overview]
Message-ID: <c804cbe9-3777-46ec-9df2-db76c1139137@suse.com> (raw)
In-Reply-To: <CAHk-=wjNj0vHh9v6-LTrbgtq=o6OS+RN3u3m03nV3n9V+urGtg@mail.gmail.com>

On 5/9/25 18:19, Linus Torvalds wrote:
> On Fri, 9 May 2025 at 08:09, Petr Pavlu <petr.pavlu@suse.com> wrote:
>>
>> The fix has been on modules-next only since yesterday but should be safe.
> 
> Hmm.
> 
> At a minimum, the *description* of this bug is garbage.
> 
> It talks about an "uninitialized completion pointer", but then the fix
> actually depends on it being initialized - just initialized to NULL.
> 
> I do believe that it always is initialized, and I have pulled this.
> but I really think the explanations here are actively misleading.
> 
> Because there's a big difference between "uninitialized" and "not
> pointing to a completion".

Right, the description is in this aspect misleading, my bad.

-- Petr

  reply	other threads:[~2025-05-10  5:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 15:09 Petr Pavlu
2025-05-09 16:19 ` Linus Torvalds
2025-05-10  5:25   ` Petr Pavlu [this message]
2025-05-12 18:14   ` Dmitry Antipov
2025-05-12 18:56     ` Linus Torvalds
2025-05-09 18:31 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c804cbe9-3777-46ec-9df2-db76c1139137@suse.com \
    --to=petr.pavlu@suse.com \
    --cc=da.gomez@samsung.com \
    --cc=dmantipov@yandex.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=samitolvanen@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®