From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6869C43381 for ; Mon, 11 Mar 2019 08:06:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7713E206BA for ; Mon, 11 Mar 2019 08:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbfCKIGl (ORCPT ); Mon, 11 Mar 2019 04:06:41 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:35251 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbfCKIGk (ORCPT ); Mon, 11 Mar 2019 04:06:40 -0400 Received: by mail-ed1-f67.google.com with SMTP id g19so3186504edp.2 for ; Mon, 11 Mar 2019 01:06:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hPXF5PngqF1AmgyWUQxnYlVcu/aGY/4pbfB3NhnZRkc=; b=kcHcdEpgL4/l1H2/mVklOPntwB+LIWDc/rBYrS/N1p7mYu+jIwQsDYBx0iw6gkzyex ucKzg2j+ZdKx/G3iLafdqxuNnsmb84N6vTFUXfhDl05jwycI9s25a3Y3NiNaaQ4Bm2nk 36NPx1mWlXext0IiUmWAV7w7iy8iqoQNF9I3w69hUnkkDVygwv5TKiXGGg9bjP7pnWin WMCMtTlBNdBLhZs2H0A3m4XqJclFrgJtYpf81YS+M+kc4r9d1Ux/t8HwUQ8pGOihZd7+ XKUeKiBI+P2nr6FBdnDPm5lYXVSBhTsHxZuHseYDv3WeU7F0TvHszhMv8KVi/f6egCv0 sVjg== X-Gm-Message-State: APjAAAXoDAIEJb05Vv5voO7svLu+y3yQUaIrVA0zVVFOJAKT2lpDzXpa 8Fuv3z7Ma4uyA+alCgvqUseEWA== X-Google-Smtp-Source: APXvYqwpZtYZ0ioqyO+Odt4tgsZnXR6AxI5xO7z9rh2XuLBmfd2y57h0vQN+AyQ/PW4lKNdYGOnt2w== X-Received: by 2002:aa7:c705:: with SMTP id i5mr1468624edq.14.1552291598291; Mon, 11 Mar 2019 01:06:38 -0700 (PDT) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id s24sm4383011edd.23.2019.03.11.01.06.37 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 11 Mar 2019 01:06:37 -0700 (PDT) Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B To: Chunfeng Yun Cc: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> <1552282383.10179.21.camel@mhfsdcap03> From: Hans de Goede Message-ID: Date: Mon, 11 Mar 2019 09:06:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552282383.10179.21.camel@mhfsdcap03> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11-03-19 06:33, Chunfeng Yun wrote: > Hi, > > On Fri, 2019-03-08 at 13:07 +0100, Hans de Goede wrote: >> Hi, >> >> On 08-03-19 07:13, Chunfeng Yun wrote: >>> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for >>> usb-b-connector >>> >>> Signed-off-by: Chunfeng Yun >>> --- >>> .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt >>> index a9a2f2fc44f2..7a07b0f4f973 100644 >>> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt >>> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt >>> @@ -17,6 +17,16 @@ Optional properties: >>> - self-powered: Set this property if the usb device that has its own power >>> source. >>> >>> +Optional properties for usb-b-connector: >>> +- id-gpios: gpio for USB ID pin. >> >> What about boards where the ID pin is *not* connected to a GPIO, >> but e.g. to a special pin on the PMIC which can also detect >> an ACA adapter ? Currently this case is handled by extcon >> drivers, but we have no way to set e.g. vbus-supply for the >> connector. Maybe in this case the usb-connector node should >> be a child of the PMIC node ? > Yes, it would be, PMIC is in charger of detecting the status of ID pin Ok, then I think this should be documented too. >> And in many cases there also is a mux to switch the datalines >> between the host and device(gadget) controllers, how should >> that be described in this model? See the new usb-role-switch >> code under drivers/usb/roles >> >> In some cases the mux is controlled through a gpio, so we >> may want to add a "mux-gpios" here in which case we also >> need to define what 0/1 means. > I'm not sure, the mux seems not belong to this connector, > and may need another driver to register usb-role-switch, > similar to: > > [v2,2/2] usb: typec: add typec switch via GPIO control > https://patchwork.kernel.org/patch/10834327/ Right the mux/role-switch will need a driver, but the "owner" of the usb_connector, e.g. the PMIC or the owner of the id GPIO pin needs to know which device is the role-switch so that it can set the role correctly based on the id-pin. Your binding already contains Vbus info, allowing the owner of the usb_connector to enable/disable Vbus based on the id-pin, but the owner will also be responsible for setting the role-switch. Note we cannot simply assume there will be only one role-switch, we really need some link from the usb_connector to the role-switch (or if it is a GPIO driven role-switch simply a role-switch-gpios member in the usb_connector). Regards, Hans