From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C11726F46F for ; Mon, 17 Nov 2025 17:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763401214; cv=none; b=pj8l6zOecolde+Pe8WaMcXf9bXi6MjyrXvH61djdDfTGKTf6EVQqkl9XbiN0M59YxBav8/vWAdcmHTSIKNmGBYmd2KQRyGwYnPsyV4BwO0ep7Wq0GrlEymcJPEvDvEq5wEG9aPu7O0VUPG/WQTfigo2mZy52WjiNMDGzf7w7I6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763401214; c=relaxed/simple; bh=8qZhN0NBRQxt+JdBFlObP/D+8kNalh+BFzjZOa9IVwU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BH/jPM8VAWekUCCKKI2Sf+XazTx7iOZuM8ocOr9Zo+Ya2tQwi4Mb2sV+bUT3OnBBnHuwozgs7owZndSFSrzQ07LLph8Pkh6V0ccT/URbwxKNemDr3WCvtVSWOuzcIKtba98FSbQ6hiekkLeIgQqxKPs60d8Xm1ieamhbm6j2CbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ub6bc65y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ub6bc65y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FDC0C2BCB0; Mon, 17 Nov 2025 17:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763401212; bh=8qZhN0NBRQxt+JdBFlObP/D+8kNalh+BFzjZOa9IVwU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ub6bc65yJ6CtqjV+o4FjeW+owuLgSh3vmzDhYrtlaELN8+Tbhqpp52kMBPcwiOA+s hwVEPqPTTUNp5t+a48Vaa7M+CxgaHLsUmU5tArWGRraDT0I7uqmHGl+1YezuiIvEvm XS5LAvogNCJGhBy1G6VF20cyteEiggf7dSr4Bcq971sYwMc2zH9GN8T6FJfHS99YJI hGKe74SAXheDKQBV4MeGuXGz0+4U1FnEa80IpNIbpDyOURAcDGxmEI68+tRNgFzuY2 dDywo/5r9R9n5pqqSsQAZPeiTslCOVG+8Z3z7mN+LyEoXGBqUA5qQL+ChR8rxplzQf ByVEg8BI3DkwA== Message-ID: Date: Mon, 17 Nov 2025 18:40:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 06/10] mm: debug_vm_pgtable: use pgtable_has_pmd_leaves() To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com References: <237bcb7f3d832457322210cc7f8d1272c4ac88ef.1762464515.git.luizcap@redhat.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <237bcb7f3d832457322210cc7f8d1272c4ac88ef.1762464515.git.luizcap@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06.11.25 22:28, Luiz Capitulino wrote: > debug_vm_pgtable calls has_transparent_hugepage() in multiple places to > check if PMD-sized pages are supported, use pgtable_has_pmd_leaves() Is that code even dealing with pages? Likely we really only want to check whether PMD leaves are supported, independent of any pages. > instead. > > Signed-off-by: Luiz Capitulino > --- > mm/debug_vm_pgtable.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index 830107b6dd08..241b36c78ac9 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -170,7 +170,7 @@ static void __init pmd_basic_tests(struct pgtable_debug_args *args, int idx) > unsigned long val = idx, *ptr = &val; > pmd_t pmd; > > - if (!has_transparent_hugepage()) > + if (!pgtable_has_pmd_leaves()) > return; All of these are currently protected by CONFIG_TRANSPARENT_HUGEPAGE, right? -- Cheers David