Re: [PATCH v4 1/2] media: i2c: adv748x: add adv748x driver

[Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>]

On 13/06/17 10:24, Geert Uytterhoeven wrote:
> Hi Kieran,
> 
> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham <kbingham@kernel.org> wrote:
>> From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>
>> Provide support for the ADV7481 and ADV7482.
>>
>> The driver is modelled with 4 subdevices to allow simultaneous streaming
>> from the AFE (Analog front end) and HDMI inputs though two CSI TX
>> entities.
>>
>> The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked
>> to the TXB CSI bus.
>>
>> The driver is based on a prototype by Koji Matsuoka in the Renesas BSP,
>> and an earlier rework by Niklas Söderlund.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
>> --- /dev/null
>> +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c
> 
>> +static int adv748x_hdmi_set_pixelrate(struct adv748x_hdmi *hdmi)
>> +{
>> +       struct v4l2_subdev *tx;
>> +       struct v4l2_dv_timings timings;
>> +       struct v4l2_bt_timings *bt = &timings.bt;
>> +       unsigned int fps;
>> +
>> +       tx = adv748x_get_remote_sd(&hdmi->pads[ADV748X_HDMI_SOURCE]);
>> +       if (!tx)
>> +               return -ENOLINK;
>> +
>> +       adv748x_hdmi_query_dv_timings(&hdmi->sd, &timings);
>> +
>> +       fps = DIV_ROUND_CLOSEST(bt->pixelclock,
>> +                               V4L2_DV_BT_FRAME_WIDTH(bt) *
>> +                               V4L2_DV_BT_FRAME_HEIGHT(bt));
> 
> On arm32:
> 
>     drivers/built-in.o: In function `adv748x_hdmi_set_pixelrate':
>     :(.text+0x1b8b1c): undefined reference to `__aeabi_uldivmod'
> 
> v4l2_bt_timings.pixelclock is u64, so you should use DIV_ROUND_CLOSEST_ULL()
> instead.

Aha, thanks.

/me ponders why I didn't get spammed from the bot-builders about this?

Fix applied locally ready for v5.

Would you like the remote updated for renesas-drivers or will you patch locally?

--
Kieran

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>