From: "Christian König" <christian.koenig@amd.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
<dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Cc: linux-kernel@vger.kernel.org,
"Oded Gabbay" <oded.gabbay@gmail.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org,
"Michel Dänzer" <michel.daenzer@amd.com>
Subject: Re: [PATCH] drm/amd: include <linux/delay.h> instead of "linux/delay.h"
Date: Thu, 18 May 2017 08:47:34 +0200 [thread overview]
Message-ID: <c8127402-cb4c-e725-cdee-5932ab97bd36@amd.com> (raw)
In-Reply-To: <1495082612-10385-1-git-send-email-yamada.masahiro@socionext.com>
Am 18.05.2017 um 06:43 schrieb Masahiro Yamada:
> Use <...> notation to include headers located in include/linux.
> While we are here, tweak the includes order a bit to sort them
> alphabetically.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
>
> drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 4 ++--
> drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c | 2 +-
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 ++--
> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 +++--
> drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 8 +++++---
> drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 5 +++--
> 6 files changed, 16 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> index ff4ae3d..963a9e0 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> @@ -22,10 +22,10 @@
> */
>
> #include "pp_debug.h"
> -#include "linux/delay.h"
> -#include <linux/types.h>
> +#include <linux/delay.h>
> #include <linux/kernel.h>
> #include <linux/slab.h>
> +#include <linux/types.h>
> #include <drm/amdgpu_drm.h>
> #include "cgs_common.h"
> #include "power_state.h"
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c
> index f5e8fda..f6b4dd9 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c
> @@ -21,8 +21,8 @@
> *
> */
>
> +#include <linux/delay.h>
> #include <linux/errno.h>
> -#include "linux/delay.h"
> #include "hwmgr.h"
> #include "amd_acpi.h"
> #include "pp_acpi.h"
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index 8f663ab..581374d 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -21,11 +21,11 @@
> *
> */
> #include "pp_debug.h"
> +#include <linux/delay.h>
> +#include <linux/fb.h>
> #include <linux/module.h>
> #include <linux/slab.h>
> -#include <linux/fb.h>
> #include <asm/div64.h>
> -#include "linux/delay.h"
> #include "pp_acpi.h"
> #include "ppatomctrl.h"
> #include "atombios.h"
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 8394955..f4ab81b 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -20,10 +20,11 @@
> * OTHER DEALINGS IN THE SOFTWARE.
> *
> */
> +
> +#include <linux/delay.h>
> +#include <linux/fb.h>
> #include <linux/module.h>
> #include <linux/slab.h>
> -#include <linux/fb.h>
> -#include "linux/delay.h"
>
> #include "hwmgr.h"
> #include "amd_powerplay.h"
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
> index 1f6744a..39c7091 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
> @@ -20,11 +20,13 @@
> * OTHER DEALINGS IN THE SOFTWARE.
> *
> */
> -#include <linux/types.h>
> +
> +#include <linux/delay.h>
> +#include <linux/gfp.h>
> #include <linux/kernel.h>
> #include <linux/slab.h>
> -#include <linux/gfp.h>
> -#include "linux/delay.h"
> +#include <linux/types.h>
> +
> #include "cgs_common.h"
> #include "smu/smu_8_0_d.h"
> #include "smu/smu_8_0_sh_mask.h"
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c
> index c0d7576..2e954a4 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c
> @@ -20,15 +20,16 @@
> * OTHER DEALINGS IN THE SOFTWARE.
> *
> */
> -#include <linux/types.h>
> +
> +#include <linux/delay.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/slab.h>
> +#include <linux/types.h>
> #include <drm/amdgpu_drm.h>
> #include "pp_instance.h"
> #include "smumgr.h"
> #include "cgs_common.h"
> -#include "linux/delay.h"
>
> MODULE_FIRMWARE("amdgpu/topaz_smc.bin");
> MODULE_FIRMWARE("amdgpu/topaz_k_smc.bin");
next prev parent reply other threads:[~2017-05-18 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 4:43 Masahiro Yamada
2017-05-18 6:47 ` Christian König [this message]
2017-05-22 7:39 ` Daniel Vetter
2017-05-22 7:55 ` Christian König
2017-05-22 8:06 ` Daniel Vetter
2017-05-22 8:11 ` Christian König
2017-05-23 18:28 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8127402-cb4c-e725-cdee-5932ab97bd36@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.daenzer@amd.com \
--cc=oded.gabbay@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome