From: Guenter Roeck <linux@roeck-us.net>
To: Jeff Lin <jefflin994697@gmail.com>
Cc: grantpeltier93@gmail.com, karanja99erick@gmail.com,
chiang.brian@inventec.com, krzk@kernel.org,
william@wkennington.com, tzungbi@kernel.org,
thorsten.blum@linux.dev, ninad@linux.ibm.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (pmbus) Add support for multiple-function pin
Date: Tue, 16 Dec 2025 01:45:59 -0800 [thread overview]
Message-ID: <c8195f04-3492-4cf9-b2b0-6f3a1198ffa2@roeck-us.net> (raw)
In-Reply-To: <20251216091617.2581192-2-jefflin994697@gmail.com>
On 12/16/25 01:16, Jeff Lin wrote:
> Some pmbus chip support the additional multiple-function pin, which can
> detect and provide the connected device's current reading. The data
> format of the multiple-function ping must be confirmed with the chip
> vendor, as it may vary between different chips. However, it is
> problematic if the data format differs from the original 'iin' and 'iout'
> and we want to show both the current from multiple-function pin and the
> original 'iin' and 'iout'.
>
> To solve the problem, add support for additional virtual current input
> and virtual current output, call it 'viin' and 'viout', respectively.
>
Those are just additional current input and output values. That does not
require additional sensor classes. Just use the chip driver to map the
readings from the chip format to the format used by the existing iin and
iout (there is no 'viin" or "viout").
Also, please point to the standard regarding "multiple function pin".
The term must only be used in the common code or definitions if it has
a reference in the standard. Otherwise it is just a manufacturer specific
extension which has no place in common code. The second patch of the series,
which accesses some very vendor specific functions, strongly suggests that
this is the case.
Guenter
next prev parent reply other threads:[~2025-12-16 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 9:16 [PATCH 0/2] hwmon/pmbus: (isl68137) Add multiple-function pin for Jeff Lin
2025-12-16 9:16 ` [PATCH 1/2] hwmon: (pmbus) Add support for multiple-function pin Jeff Lin
2025-12-16 9:45 ` Guenter Roeck [this message]
2025-12-16 9:16 ` [PATCH 2/2] hwmon/pmbus: (isl68137) Add multiple-function pin for raa229141a Jeff Lin
2025-12-16 9:56 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8195f04-3492-4cf9-b2b0-6f3a1198ffa2@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chiang.brian@inventec.com \
--cc=grantpeltier93@gmail.com \
--cc=jefflin994697@gmail.com \
--cc=karanja99erick@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=thorsten.blum@linux.dev \
--cc=tzungbi@kernel.org \
--cc=william@wkennington.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®