From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mn-var-som: reorder reg properties after compatible strings
Date: Tue, 7 Nov 2023 17:37:44 +0100 [thread overview]
Message-ID: <c81b364e-a36e-4f56-b2c4-d4ca889281ed@linaro.org> (raw)
In-Reply-To: <20231107112804.e854521b47caeafdc642a2f3@hugovil.com>
On 07/11/2023 17:28, Hugo Villeneuve wrote:
> On Tue, 7 Nov 2023 17:19:20 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
>> On 07/11/2023 17:01, Hugo Villeneuve wrote:
>>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>>
>>> Move reg nodes after the compatible string, to follow DT conventions.
>>
>> This is a bit of churn... like patches for checkpatch. But unlike
>> checkpatch, it's not even documented.
>
> Hi,
> I do not really understand your point or if I must change
> something...
>
> But looking at a lot of dts, the reg property is always following the
> compatible string, so I assumed it was an undocumented convention or
> best practice...
>
Patches fixing only checkpatch --strict are usually welcomed only in
staging. But even there no one wants to deal with one patch changing one
style issue in one file.
You are doing the same, outside of staging, but relying on undocumented
practice. Such patches are unnecessary churn. Documenting the practice
and fixing entire subsystems or groups of devices would be welcomed.
Fixing line by line some style issue is just effort for maintainers.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-07 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 16:01 Hugo Villeneuve
2023-11-07 16:19 ` Krzysztof Kozlowski
2023-11-07 16:28 ` Hugo Villeneuve
2023-11-07 16:37 ` Krzysztof Kozlowski [this message]
2023-11-07 16:52 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c81b364e-a36e-4f56-b2c4-d4ca889281ed@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®