From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 234A3C433FE for ; Tue, 25 Jan 2022 16:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234039AbiAYQVI (ORCPT ); Tue, 25 Jan 2022 11:21:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:47736 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1583255AbiAYQQu (ORCPT ); Tue, 25 Jan 2022 11:16:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643127409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KX6Xm8xd5XItsATHw1pCIORe/qAqaOGR19jcipUdA5w=; b=gPDfb5pMVCKeRlsFgRmr033wYgL8Eg0EtX3UmBr7TvfIuj8shO3CTeKqFlUkFM8vcvWNlX q7ahat3KgMu3QAObHb5kdFbjX3rgY0Vtek0lxnG3Aoqbt3ifT568AF+7jowpAHwSCr09yk wZoovlcVAJFvdxRRTWd/AqM/QhDcg44= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-189-1tAMNPKcP3moPDKCBoWqFw-1; Tue, 25 Jan 2022 11:16:47 -0500 X-MC-Unique: 1tAMNPKcP3moPDKCBoWqFw-1 Received: by mail-ej1-f70.google.com with SMTP id ky6-20020a170907778600b0068e4bd99fd1so3623101ejc.15 for ; Tue, 25 Jan 2022 08:16:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KX6Xm8xd5XItsATHw1pCIORe/qAqaOGR19jcipUdA5w=; b=b7O1BW/HpZxOSbZUb31w42vPK/qHUQVawRNRopa/KlLzFk1ZZNJ/SJ0kltHGknv0p4 8WzjXkSUqi9XOgnxhBH2uWiZO3wC5+p3cJLef+umH5/kYblqWqphclsc2a7IJGCHzJ62 v1R9D3I4SICEWYGCzDNRFBelBsIzzEQOqqVy6oHKJjI7aZ7ynU7/T0hMWw4BKK0QMX5k F+pERClvdq6EkKSefyf2GGDUJyewYpjnk5kKjxyjSHvcCHjwpT0hAnz1nEamxH8sybFb j4PUQDjx90phvVk3lPiIxXExZpW318o1kwLOB9C/2AFoB4uQNPRr9V0AGN7o2lKqBq5A tVdA== X-Gm-Message-State: AOAM532SHAq+Pp5lsCk47qii4OAKF2e160RIcBCeNpRgHWIOLDk2Vws/ HjDueAlgjdqj3st1D/gKowUE5QTiBECtttFEtm3fLNPHJUE9cwdqu6ZrwpFD5TT16olOPycH5lF yP+Wy9wvfQPLu2ZcoDbE9P1Gl X-Received: by 2002:a05:6402:190d:: with SMTP id e13mr11203149edz.6.1643127406123; Tue, 25 Jan 2022 08:16:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJYPPNAkHsi7A2wclzej5ABIz4nD7f3K3+RXhrdQ+YdD37YBKS4eHmlYrgYxSqtYu/ydCyTQ== X-Received: by 2002:a05:6402:190d:: with SMTP id e13mr11203123edz.6.1643127405862; Tue, 25 Jan 2022 08:16:45 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id i16sm6376175eja.8.2022.01.25.08.16.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 08:16:45 -0800 (PST) Message-ID: Date: Tue, 25 Jan 2022 17:16:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 11/19] KVM: x86/svm: Remove unused "vector" of sev_vcpu_deliver_sipi_vector() Content-Language: en-US To: Jinrong Liang Cc: Xianting Tian , Jim Mattson , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220125095909.38122-1-cloudliang@tencent.com> <20220125095909.38122-12-cloudliang@tencent.com> From: Paolo Bonzini In-Reply-To: <20220125095909.38122-12-cloudliang@tencent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/25/22 10:59, Jinrong Liang wrote: > From: Jinrong Liang > > The "struct kvm_vcpu *vcpu" parameter of sev_vcpu_deliver_sipi_vector() > is not used, so remove it. No functional change intended. > > Signed-off-by: Jinrong Liang > --- > arch/x86/kvm/svm/sev.c | 2 +- > arch/x86/kvm/svm/svm.c | 2 +- > arch/x86/kvm/svm/svm.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 0727ac7221d7..2fd1e91054b3 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -2925,7 +2925,7 @@ void sev_es_prepare_guest_switch(unsigned int cpu) > hostsa->xss = host_xss; > } > > -void sev_vcpu_deliver_sipi_vector(struct kvm_vcpu *vcpu, u8 vector) > +void sev_vcpu_deliver_sipi_vector(struct kvm_vcpu *vcpu) > { > struct vcpu_svm *svm = to_svm(vcpu); > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index 3e75ae834412..aead235a90ee 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -4348,7 +4348,7 @@ static void svm_vcpu_deliver_sipi_vector(struct kvm_vcpu *vcpu, u8 vector) > if (!sev_es_guest(vcpu->kvm)) > return kvm_vcpu_deliver_sipi_vector(vcpu, vector); > > - sev_vcpu_deliver_sipi_vector(vcpu, vector); > + sev_vcpu_deliver_sipi_vector(vcpu); > } > > static void svm_vm_destroy(struct kvm *kvm) > diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h > index 0a749bbda738..61c96f4a7006 100644 > --- a/arch/x86/kvm/svm/svm.h > +++ b/arch/x86/kvm/svm/svm.h > @@ -621,7 +621,7 @@ int sev_handle_vmgexit(struct kvm_vcpu *vcpu); > int sev_es_string_io(struct vcpu_svm *svm, int size, unsigned int port, int in); > void sev_es_init_vmcb(struct vcpu_svm *svm); > void sev_es_vcpu_reset(struct vcpu_svm *svm); > -void sev_vcpu_deliver_sipi_vector(struct kvm_vcpu *vcpu, u8 vector); > +void sev_vcpu_deliver_sipi_vector(struct kvm_vcpu *vcpu); > void sev_es_prepare_guest_switch(unsigned int cpu); > void sev_es_unmap_ghcb(struct vcpu_svm *svm); > For this one and patch 10, even if the argument is not used, the code seems more natural if it is there. It is more of an implementation detail that it is not used. Paolo