From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2174486BA9 for ; Fri, 21 Aug 2026 16:19:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787329183; cv=none; b=TX3zUn0ViFysr7JfAq2/USXxwpYWo1Czlhrx/T5oUvWLDMHtBPN7nrBzYvmAYGAgO4OZOrFKnsUvSckIShKHMSTf3sMywxKMb3MmvFrxq7tCS3NMPFJ9ss6NpOKjCRGKAPe53Vn1cJujBY2JqRQ+lI6nhdLIXL5/uTIfci2CVxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787329183; c=relaxed/simple; bh=X10fgcE/VdvZBiLYK96ZfvDAsItFNmfond2stuPddA4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ueUhjJf1cpRLcLY6RHG2BaB9is31MbmcxsLVaxely1xk4grCn1A5jGN3gOGEb7hnRlTfwGrKwlX3aYNaLIt1LkzuTGky9q/BALNK5uUkXgBeRRtXC0TL6yGHM6VT1ojUL3PV9t8uByWkfgTZWAdUR1snxT8RssC5y7sNOVdWfY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N71lhcbr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V1IPRsxu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N71lhcbr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V1IPRsxu" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67LFmVLi1875166 for ; Fri, 21 Aug 2026 16:19:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gEYvpnAfzkeKW0yeKy1jpo0v3pAYiHrS+jiYSV5Tvjw=; b=N71lhcbr5rc5+Ma7 v7CHr5pI0zWKHpS5WKfVzmaKWSDa0qPLNneY6rafufgyARMVgi9FcrqVaWYBBHrY COagBa67FingibI8pSKl3ZwRQA9CnJ5QMJBs6Z4TjfF2GhOwIr2vp3P1uMeIIG4t qmYRQR3ydxJpNjiwhamZ4GfR6vuUGjPkmNG/wjhw7aue4GfQo+tL4uDY2pkovlLi +dcVHB5V7ynk77UYXI9igboWYJBlMlZ7vZXn8ML+KVjbaIDJLqogTXzyrh2tERZe Q6CfduM2rbDDPPMwB9E36inNdUhnSpN0Zzd50lct6zIe71nJpniAs06X+P+IOYuD gULumQ== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g6gdeadsr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Aug 2026 16:19:38 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7eb64224fd2so2410629a34.0 for ; Fri, 21 Aug 2026 09:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787329178; x=1787933978; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gEYvpnAfzkeKW0yeKy1jpo0v3pAYiHrS+jiYSV5Tvjw=; b=V1IPRsxuDG6rg7FbMrCs755o/yJHxniVx8t3O/XDpKeH4JHqh1Ejeb54QKZEzfxhOZ D4RY9/mo5xct8nyGObaLIoZ+0V7t/vcTnzrHpjTQ3ccBZ7tqbcfS1lAXhUK+yR+8ShQc bRKNg1rGygzqSjmoPFo5enrWMg/tvvVdLSbuJv894LBcpbGV2wfmBnelUHzNzjOoLV8d N/xW0oNLqVVMi+eVmy5Dj6fAZ6BIsDVgq6QTJRFG2Ek4sDf8emYqY5Sy/z8+ALYrTRd0 aF3qqjks6zjWzbAjPeetunghHd/HnjMrh5OHsa+VqQC6SM1ZPpdo1YmNkQi9fgjjBX6o ad5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787329178; x=1787933978; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gEYvpnAfzkeKW0yeKy1jpo0v3pAYiHrS+jiYSV5Tvjw=; b=IUY5ko6TaYx0Gr7nYve7J7HxBSvJFiCHBDN7/epdAVwyVvKAYqalZXKxKojAuiMPRZ zzv80pM5nZafmMFhA+rSUjEHX003gW9KeD8gYI5BHhtjEAFfm4Rq7l+BH15e8U5DWTBp hPqztfZXH/WLFy1HGtNz85qv5oLQaXw12eOBNkggaFFDbZNU2fMacM6FUMmkNzW4KNd4 Ek1s8hqvS6txB37V6zmHUGMrMuy60hbkHifhNKLZHsD5MNyKSjw5PgtzsyGEcICJ169M KMQYKSehTwyOFGbwsamhyTMztzeBxUJSfVCTEYgXKVxWSS5hVoNe5EKrQYKh9gEKQfBx GZ4Q== X-Forwarded-Encrypted: i=1; AHgh+RqWXQny3v03D2X0QRrHUOTGoA09+bhACKQEimcjKtNgrUsFszkBxDWNxN07JjJmL1rm2QvJMMbJjXcLRpw=@vger.kernel.org X-Gm-Message-State: AOJu0YzJikR7UpRnHg6NvwGjspeZEI365R8LA6dcO8nyz11+MNbqKQPA 0hhJqOaHwZ07I5ZV2g1DBKL7GMAxAv5sZSCgWCEdJfW6q8D+IUumtz+3FqyxwHPawpxyfYeqPDy ZOGoKUWdojHxK3PjD6gzqaofU/olLA4KugoHFcY/519CIlNeoLT8ojyH1z++Fb8E9jr4= X-Gm-Gg: AR+sD130MkPlOmeNSDZ1Hw0wRXuJABb8UXhV+ZnllB9jAoD+KFL8yk+Z7+ec1i7rpSz x4hXO90jKAmEdChEb/Qo59DPYtqEdPoR09y9PONtla92AWt5yGh6Azx185rTF0S/ONLfzvSHuoX H2X2vrElXYsstfbb9DsOMkFCLN4f4E2ABk/ZK/voB5Q1BrR8Ers4Wema656u6Nxjp6fwJiWrP/6 iB4AgodFi6Bt6afJrIhX9Qxp82Lbv7FKLfryZ6JvMG2cf3VBX7TSrNKJYdQh85TniRCySnn5lmc 7Rl6/HgwshtecqWJVed8irI4F2YkO9Rhjc25egwQH4JRuzmzL+fyigGuNaN0sebpj3MxucYxE5w wjuUA1Xj1bioJ+T/k3zQldMk+pDWvwL3U X-Received: by 2002:a05:6820:308d:b0:6b1:681f:81a1 with SMTP id 006d021491bc7-6b1681f9275mr1606903eaf.24.1787329178071; Fri, 21 Aug 2026 09:19:38 -0700 (PDT) X-Received: by 2002:a05:6820:308d:b0:6b1:681f:81a1 with SMTP id 006d021491bc7-6b1681f9275mr1606821eaf.24.1787329177641; Fri, 21 Aug 2026 09:19:37 -0700 (PDT) Received: from [192.168.1.2] ([122.171.20.211]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4632a6c360asm4738369fac.5.2026.08.21.09.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 09:19:37 -0700 (PDT) Message-ID: Date: Fri, 21 Aug 2026 21:49:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/15] pinctrl: qcom: Add Kuno pinctrl driver To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Michael Turquette , Stephen Boyd , Brian Masney , Taniya Das , Georgi Djakov , Bartosz Golaszewski , Linus Walleij , Thomas Gleixner , Radu Rendec , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260814-kuno-soc-support-v2-0-3079794f0f73@oss.qualcomm.com> <20260814-kuno-soc-support-v2-9-3079794f0f73@oss.qualcomm.com> <4e7a398b-e75c-4dca-8380-440ca7cb22c6@oss.qualcomm.com> Content-Language: en-US From: Hardeep Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=BcroFLt2 c=1 sm=1 tr=0 ts=6a887a9a cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=+KmVXPE0btiop/5qwQKk0Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=A1cAmru4g_ti7Hb5znAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-GUID: pyJMbWCMnDohDyHJgGZpJIjffPxsyCKY X-Proofpoint-ORIG-GUID: pyJMbWCMnDohDyHJgGZpJIjffPxsyCKY X-Proofpoint-Spam-Info: AW1haW4tMjYwODIxMDEyNyBTYWx0ZWRfX+SnIgxzwHlUj j4YBdkrNMLHqc5kOm16TQDYWmMn13rsTPq1kWSoTUr/DNf/wiOcOqxtpAmXLu2uENb1cqaueWRj LuJJ5mJ99HR13KqHpKvFIpNxTOi0e6A= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIxMDEyNyBTYWx0ZWRfXxRT5fTDaPYW8 C9nwkoBTMFhpCFEZaeFFvOhij5wtdXTKl/tnaSv27P76QVUffN4QM/NubfGe7XCji9qkFu+CZaG poLzdqIHtQJyEbn3Namj7CY31L2Q4m1Q9ZRd+CxO+vPPuvzxDKBIYVJ2Zias/+6HhmF0g/iqLfP kJdjdvrawN2QqRk3KYbosxIGXjMs3q/6oCZECXVVb1MT1wIFu0BWMiw7w1PVW9rWBN1JzHC4i3c sKLdAUjtWKAOZ1WyeGR+PofJQal8C9x4i+p74+Gdh6aq3wuLQoZW0E6JoyvLu01hvzsRiuWUjyS +asZemNheNHLcZUx1XYW7gLUjEh1GJQeKAkxIjPybYS7fUn1aOqVJglJySKFmGyRQQhJXKeqQCh epIERxtv+Kg8zDoj1PAteybfQ61L8JmqR9F3WoHQfWGJtek61qHnGCVEQvur5Zs0M7IAM1GP5rX Yhrrn3m5MlN5YuDCUcQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-21_05,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608210127 On 8/17/2026 8:55 PM, Konrad Dybcio wrote: > On 8/17/26 3:42 PM, Hardeep Sharma wrote: >> On 8/17/2026 6:54 PM, Konrad Dybcio wrote: >>> On 8/14/26 9:31 AM, Hardeep Sharma wrote: >>>> Add the TLMM pinctrl driver for the Qualcomm Kuno platform, supporting >>>> 110 GPIOs and their pin multiplexing, pin configuration and gpiolib >>>> interface through the common pinctrl-msm driver. >>>> >>>> Signed-off-by: Hardeep Sharma >>>> --- >>> [...] >>> >>>> +    [65] = PINGROUP(65, qup0_se1, qdss_cti_trig1, qdss_cti_trig1, NA, NA, NA, NA, NA, NA), >>>> +    [66] = PINGROUP(66, qup0_se1, qdss_cti_trig1, qdss_cti_trig1, NA, NA, NA, NA, NA, NA), >>> Function3 can't be selected because of repeating names >>> >>> In qdss_cti_trig1_groups, you have qdss_cti_trig1 specified twice. >>> Perhaps there was a longer name that got truncated? >>> >>> Konrad >> Thanks Konrad for review. >> >> It's a real qdss_cti_trig1 line - the in/out >> mirror partner of funcsel 2: >> >>    GPIO65: fsel2 = qdss_cti_trig1_in_mirb, fsel3 = qdss_cti_trig1_out_mire >>    GPIO66: fsel2 = qdss_cti_trig1_out_mirb, fsel3 = qdss_cti_trig1_in_mire >> >> Both map to the same name because the driver uses one coarse >> "qdss_cti_trig1" for the in/out mirror variants. > But these are physically separate functions, even if the mirror feature > makes them seemingly one and the same > >> Listing the function on both funcsels is the normal sdx convention for >> these mirror pairs - the in-tree drivers do it, including the same pins >> on sdx65: >> >>    - sdx55 [16][17][22][23][54][55][94][95] → in pinctrl-sdx55.c, pins >> 16, 17, 22, 23, 54, 55, 94, 95 each repeat qdss_cti at two funcsels. >>    - sdx65 [65]/[66] → in pinctrl-sdx65.c, pins 65 and 66 do it — >>    - sdx75 [16][52][53][56][57][78][79] → in pinctrl-sdx75.c, those pins >> do it. >> >> Only funcsel 2 >> is selectable from DT (first-match), which is expected and matches those >> drivers. > As you described it, you found a bug (FSEL3 is not selectable), please > fix it in all the instances you've mentioned. > > Konrad Thanks for review. Corrected in v3 : https://lore.kernel.org/all/20260821-kuno-soc-support-v3-0-196e2b306368@oss.qualcomm.com/ Best Wishes Hardeep Sharma