From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Leo Yan <leo.yan@linaro.org>, Ali Saidi <alisaidi@amazon.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
James Clark <james.clark@arm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Sandipan Das <sandipan.das@amd.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf tools: Fix foolproof typo
Date: Thu, 19 Jan 2023 15:14:25 -0500 [thread overview]
Message-ID: <c8238848-801b-af31-d9aa-91839fae5885@linux.intel.com> (raw)
In-Reply-To: <20230119201036.156441-1-irogers@google.com>
On 2023-01-19 3:10 p.m., Ian Rogers wrote:
> In the context of LBR stitching documentation.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Thanks Ian.
Acked-by: Kan Liang <kan.liang@linux.intel.com>
Thanks,
Kan
> ---
> tools/perf/Documentation/perf-c2c.txt | 2 +-
> tools/perf/Documentation/perf-report.txt | 2 +-
> tools/perf/Documentation/perf-script.txt | 2 +-
> tools/perf/Documentation/perf-top.txt | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt
> index 5c5eb2def83e..af5c3106f468 100644
> --- a/tools/perf/Documentation/perf-c2c.txt
> +++ b/tools/perf/Documentation/perf-c2c.txt
> @@ -121,7 +121,7 @@ REPORT OPTIONS
> perf c2c record --call-graph lbr.
> Disabled by default. In common cases with call stack overflows,
> it can recreate better call stacks than the default lbr call stack
> - output. But this approach is not full proof. There can be cases
> + output. But this approach is not foolproof. There can be cases
> where it creates incorrect call stacks from incorrect matches.
> The known limitations include exception handing such as
> setjmp/longjmp will have calls/returns not match.
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index 4fa509b15948..9b0c0dbf9a77 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -507,7 +507,7 @@ include::itrace.txt[]
> perf record --call-graph lbr.
> Disabled by default. In common cases with call stack overflows,
> it can recreate better call stacks than the default lbr call stack
> - output. But this approach is not full proof. There can be cases
> + output. But this approach is not foolproof. There can be cases
> where it creates incorrect call stacks from incorrect matches.
> The known limitations include exception handing such as
> setjmp/longjmp will have calls/returns not match.
> diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
> index 68e37de5fae4..8d77182fbf31 100644
> --- a/tools/perf/Documentation/perf-script.txt
> +++ b/tools/perf/Documentation/perf-script.txt
> @@ -502,7 +502,7 @@ include::itrace.txt[]
> perf record --call-graph lbr.
> Disabled by default. In common cases with call stack overflows,
> it can recreate better call stacks than the default lbr call stack
> - output. But this approach is not full proof. There can be cases
> + output. But this approach is not foolproof. There can be cases
> where it creates incorrect call stacks from incorrect matches.
> The known limitations include exception handing such as
> setjmp/longjmp will have calls/returns not match.
> diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> index e534d709cc5a..c60e615b7183 100644
> --- a/tools/perf/Documentation/perf-top.txt
> +++ b/tools/perf/Documentation/perf-top.txt
> @@ -334,7 +334,7 @@ use '-e e1 -e e2 -G foo,foo' or just use '-e e1 -e e2 -G foo'.
> callgraph. The option must be used with --call-graph lbr recording.
> Disabled by default. In common cases with call stack overflows,
> it can recreate better call stacks than the default lbr call stack
> - output. But this approach is not full proof. There can be cases
> + output. But this approach is not foolproof. There can be cases
> where it creates incorrect call stacks from incorrect matches.
> The known limitations include exception handing such as
> setjmp/longjmp will have calls/returns not match.
prev parent reply other threads:[~2023-01-19 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 20:10 Ian Rogers
2023-01-19 20:14 ` Liang, Kan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8238848-801b-af31-d9aa-91839fae5885@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alisaidi@amazon.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®