mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Armin Wolf <W_Armin@gmx.de>
Cc: hdegoede@redhat.com, jdelvare@suse.com,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] hwmon: (sch5627) Use bit macros when accessing the control register
Date: Sun, 10 Sep 2023 17:48:33 -0700	[thread overview]
Message-ID: <c8238cd2-00a1-43a5-8b6b-871cba0da4d0@roeck-us.net> (raw)
In-Reply-To: <20230907052639.16491-2-W_Armin@gmx.de>

On Thu, Sep 07, 2023 at 07:26:35AM +0200, Armin Wolf wrote:
> Use bit macros then accessing SCH5627_REG_CTRL, so that people
> do not need to look at the datasheet to find out what each bit
> does.
> 
> Tested on a Fujitsu Esprimo P720.
> 
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>

Applied.

Thanks,
Guenter

  reply	other threads:[~2023-09-11  0:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07  5:26 [PATCH v2 0/5] hwmon: (sch5627) Make limit registers writable Armin Wolf
2023-09-07  5:26 ` [PATCH v2 1/5] hwmon: (sch5627) Use bit macros when accessing the control register Armin Wolf
2023-09-11  0:48   ` Guenter Roeck [this message]
2023-09-07  5:26 ` [PATCH v2 2/5] hwmon: (sch5627) Disallow write access if virtual registers are locked Armin Wolf
2023-09-11  0:49   ` Guenter Roeck
2023-09-07  5:26 ` [PATCH v2 3/5] hwmon: (sch5627) Use regmap for pwm map register caching Armin Wolf
2023-09-11  0:52   ` Guenter Roeck
2023-09-07  5:26 ` [PATCH v2 4/5] hwmon: (sch5627) Add support for writing limit registers Armin Wolf
2023-09-11  0:54   ` Guenter Roeck
2023-09-07  5:26 ` [PATCH v2 5/5] hwmon: (sch5627) Document behaviour of " Armin Wolf
2023-09-11  0:54   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8238cd2-00a1-43a5-8b6b-871cba0da4d0@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=W_Armin@gmx.de \
    --cc=hdegoede@redhat.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®