From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39C0929D268 for ; Fri, 27 Mar 2026 07:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774597891; cv=none; b=uMgCxD14G9tAiOWD8y67RX0fBj8Xbu4goejdBjllSLn6/S4yxGrF8fs9fHOutyIfd67NJpxgpgW396L/Ky8CrTWSkm/UI39zhy5NiX6032vnyKP9mcW6pDBEGIGFtUJX6CCUcvkYu0La1TUrifsvS5+dMSnDZxp28XbK/kzPyzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774597891; c=relaxed/simple; bh=bQQlwZ4SeBxVMr54+IT9zGQQHRyh4SojeHmnIsWX4Vo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SXOTsgjGI0EIsCLFiUs/EBEgbw0+o1U04MYB039v5ooD8GjNAeaMNJysR7DC9Sd66r9R8buTRqCwUP2aiPbN+QD79VI8Cgz5eoHiG+Sg1dSq0RwTs/4qfhK0+rSGXEa+kMjotZmGwdEx7ELQAhLU9chOff3Wb60tfimauiYFWOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kXxPCsMm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kXxPCsMm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAA66C19423; Fri, 27 Mar 2026 07:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774597890; bh=bQQlwZ4SeBxVMr54+IT9zGQQHRyh4SojeHmnIsWX4Vo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kXxPCsMmsglasjUC56YN66BuUwkCXnonxDBVLcZlbpxknQvkF3ucezBc240psEPeq aJi1TkZiKgApAaz6haTHQOtDpDifLpsFoERji2pyYLL83lLBzlu5lRUznjExBycEr1 daoR1DBcB8FVEG7g4C3SzMX8ZLbImaYPvIOzZo5ujEDBJH+mhpGx5grshS1ldmOb+R 3KExS2+cK3btkg7d05CdQFlHDT2dRaGxBxDUwhpO6rRnXcFC7NywHf2idJIyAQNugo UjQX8iJLjPfL2RD+9EsG8LbLfUZU30NrUhmsfCBYc1O3wuAczR/9tlg5CoOYtShj+A RIPml0qVQOSyA== Date: Fri, 27 Mar 2026 07:51:22 +0000 From: "Lorenzo Stoakes (Oracle)" To: Andrew Morton Cc: Qi Zheng , hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Harry Yoo (Oracle)" , Qi Zheng Subject: Re: [PATCH v2 4/4] mm: memcontrol: fix unexpected massive positive number in memcg_state_val_in_pages() Message-ID: References: <54c2b09c-84f8-4118-96a6-acc13ca2f245@lucifer.local> <9ee51ac2-c87c-44f6-b983-44ac9007cb35@lucifer.local> <20260326170622.8fa7ca34d1425c241525bd41@linux-foundation.org> <0cf08b3f-6fed-41c4-8728-c925e8a55f29@linux.dev> <20260326201349.f63af08fb120b2ecb1623211@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326201349.f63af08fb120b2ecb1623211@linux-foundation.org> On Thu, Mar 26, 2026 at 08:13:49PM -0700, Andrew Morton wrote: > On Fri, 27 Mar 2026 10:42:52 +0800 Qi Zheng wrote: > > > > a) Redo this "fix unexpected ..." series on top of "Eliminate ..." > > > and tolerate the bisection hole (easiest). > > > > From my personal perspective, I prefer this approach. The issues fixed > > by this patchset aren't too critical; it's just that the counter might > > overflow (and only with CONFIG_MEMCG_V1). If it can be included in > > v7.1-rcX along with "Eliminate ...", I think it's acceptable. > > Cool, thanks. > > I've dropped "fix unexpected type conversions and potential overflows > v2" from mm.git to give you a clean mm-unstable to work against. I > expect to be pushing this a couple of hours from now. > Yeah this works for me too, I think given low chance of hitting we can tolerate a small bisection hole!