From: Rob Emanuele <poorarm@shoreis.com>
To: Michael Roth <mroth@nessie.de>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Andrew Victor <avictor.za@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
Subject: Re: [PATCH 5/6] Unified AVR32/AT91 MCI Driver Support for a VCC Pin
Date: Mon, 15 Jun 2009 15:16:49 -0700 [thread overview]
Message-ID: <c8284b5b0906151516x6774545u6308e45049bb094c@mail.gmail.com> (raw)
In-Reply-To: <200906152335.48926.mroth@nessie.de>
That would be fine with me.
On Mon, Jun 15, 2009 at 2:35 PM, Michael Roth<mroth@nessie.de> wrote:
>
>> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
>> index 1c1a4b3..a639b93 100644
>> --- a/drivers/mmc/host/atmel-mci.c
>> +++ b/drivers/mmc/host/atmel-mci.c
>> @@ -214,6 +214,8 @@ struct atmel_mci_slot {
>>
>> int detect_pin;
>> int wp_pin;
>> + int vcc_pin;
>> + bool vcc_pin_act_low;
>
> Maybe, just 'vcc_active_low' is more clear?
>
> Most other kernel code use 'active_low' or 'xyz_active_low' as far as I can
> see.
>
>
prev parent reply other threads:[~2009-06-15 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 1:02 Rob Emanuele
2009-06-15 16:20 ` Nicolas Ferre
2009-06-15 18:17 ` Rob Emanuele
2009-06-15 21:35 ` Michael Roth
2009-06-15 22:16 ` Rob Emanuele [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8284b5b0906151516x6774545u6308e45049bb094c@mail.gmail.com \
--to=poorarm@shoreis.com \
--cc=avictor.za@gmail.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mroth@nessie.de \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®