From: Krzysztof Kozlowski <krzk@kernel.org>
To: dongxuyang@eswincomputing.com, p.zabel@pengutronix.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
huangyifeng@eswincomputing.com
Subject: Re: [PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset controller
Date: Thu, 19 Jun 2025 19:40:51 +0200 [thread overview]
Message-ID: <c82bf3c6-ff40-4167-a78a-4ea21e41e8e9@kernel.org> (raw)
In-Reply-To: <20250619075811.1230-1-dongxuyang@eswincomputing.com>
On 19/06/2025 09:58, dongxuyang@eswincomputing.com wrote:
> From: Xuyang Dong <dongxuyang@eswincomputing.com>
>
> There are some register offsets in reset dt-bindings. It could be used.
> Therefore, we want to keep these bindings. I don't known if it meets
> the requirements.
>
> PIPE_RST_CTRL, TBU_RST_CTRL and TEST_RST_CTRL are not used in this
> driver. Therefore, these are left out.
>
> Updates:
>
> dt-bindings: reset: eswin: Documentation for eic7700 SoC
> v2 -> v3:
> 1. Drop syscon and simple-mfd from yaml and code, because these are
> not necessary.
> 2. Update description to introduce reset controller.
> 3. Add reset control indices for dt-bindings.
> 4. Keep the register offsets in dt-bindings.
No, drop. Register offsets are not bindings. That was last comment, so
don't keep them. Remove them.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-06-19 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 7:58 dongxuyang
2025-06-19 8:00 ` [PATCH v3 1/2] dt-bindings: reset: eswin: Documentation for eic7700 SoC dongxuyang
2025-06-19 17:39 ` Krzysztof Kozlowski
2025-06-19 8:01 ` [PATCH v3 2/2] reset: eswin: Add eic7700 reset driver dongxuyang
2025-06-19 17:41 ` Krzysztof Kozlowski
2025-06-19 17:40 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c82bf3c6-ff40-4167-a78a-4ea21e41e8e9@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongxuyang@eswincomputing.com \
--cc=huangyifeng@eswincomputing.com \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®