From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 718B338236F for ; Tue, 14 Apr 2026 07:46:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776152793; cv=none; b=Im4gP4m0/+m0iDk0iWnUHVN0wJBWB9w5JyTmgYOzmUQsmhH3016+fM0aww4DcGg6xlNct1p8m561nD+Lxuf+rNhMwT8q5C88rYrsKrU88oEAYBP1Aa3jFaP2BJwRnS5jmbDg7znWUd1P0VIIWUhEttfjTXnyXm+bjBgXm+AVYYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776152793; c=relaxed/simple; bh=dCmDjjmCpLnkgHMl9cT95Muw7QF27hl7RVArNKvikXc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dnJVpygoBgK1yhMFzZ6a+0vHigVsP0WSKSgs6hjEJDJRuPGCi6QJKqV8QNzSB2trpl9BF4LfXKpTlWNboXQc84lwzccXVdVlyG1XlLB/juko5DX5D58JB4ny3ylXexVZD4haYw8E/Dv0T6ikF2WdYq2eLf67vlp1/4MtBnEhxZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.177]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4fvxDF3XQtzKHM02 for ; Tue, 14 Apr 2026 15:46:21 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id 47CC54058C for ; Tue, 14 Apr 2026 15:46:29 +0800 (CST) Received: from [10.67.111.176] (unknown [10.67.111.176]) by APP3 (Coremail) with SMTP id _Ch0CgAXErzU8N1peDpsAQ--.17S2; Tue, 14 Apr 2026 15:46:29 +0800 (CST) Message-ID: Date: Tue, 14 Apr 2026 15:46:28 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 13/14] mm/vmscan: remove sc->unqueued_dirty To: kasong@tencent.com, linux-mm@kvack.org Cc: Andrew Morton , Axel Rasmussen , Yuanchu Xie , Wei Xu , Johannes Weiner , David Hildenbrand , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Barry Song , David Stevens , Leno Hou , Yafang Shao , Yu Zhao , Zicheng Wang , Kalesh Singh , Suren Baghdasaryan , Chris Li , Vernon Yang , linux-kernel@vger.kernel.org, Qi Zheng , Baolin Wang References: <20260413-mglru-reclaim-v5-0-8eaeacbddc44@tencent.com> <20260413-mglru-reclaim-v5-13-8eaeacbddc44@tencent.com> Content-Language: en-US From: Chen Ridong In-Reply-To: <20260413-mglru-reclaim-v5-13-8eaeacbddc44@tencent.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:_Ch0CgAXErzU8N1peDpsAQ--.17S2 X-Coremail-Antispam: 1UD129KBjvJXoWrtrWUAF1xuF4kXryxWw4xXrb_yoW8JrWxpa 95Ka1UKay5Jr1jkr9xAF9xZr4Iq3y7K3W7trW7Zw1UWasxXF1rWryakr1Yqrn5ur97CFy3 AFsruFy8Kw4rJaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS 14v26r4a6rW5MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWr XwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07 jxOz3UUUUU= X-CM-SenderInfo: hfkh02xlgr0w46kxt4xhlfz01xgou0bp/ On 2026/4/13 0:48, Kairui Song via B4 Relay wrote: > From: Kairui Song > > No one is using it now, just remove it. > > Suggested-by: Axel Rasmussen > Reviewed-by: Baolin Wang > Reviewed-by: Axel Rasmussen > Reviewed-by: Barry Song > Signed-off-by: Kairui Song > --- > mm/vmscan.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index b0b66c03d4dc..a431f94ff3a3 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -169,7 +169,6 @@ struct scan_control { > > struct { > unsigned int dirty; > - unsigned int unqueued_dirty; > unsigned int congested; > unsigned int writeback; > unsigned int immediate; > @@ -2035,7 +2034,6 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan, > > sc->nr.dirty += stat.nr_dirty; > sc->nr.congested += stat.nr_congested; > - sc->nr.unqueued_dirty += stat.nr_unqueued_dirty; > sc->nr.writeback += stat.nr_writeback; > sc->nr.immediate += stat.nr_immediate; > sc->nr.taken += nr_taken; > Reviewed-by: Chen Ridong -- Best regards, Ridong