mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Afzal Mohammed <afzal@ti.com>
To: <linux-fbdev@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	Rob Landley <rob@landley.net>,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	Mike Turquette <mturquette@linaro.org>,
	"Manjunathappa, Prakash" <prakash.pm@ti.com>
Subject: [PATCH v3 02/12] video: da8xx-fb: fix 24bpp raster configuration
Date: Tue, 22 Jan 2013 22:22:09 +0530	[thread overview]
Message-ID: <c831d47d82bc2910fb77e460b6334e331e9704d6.1358871750.git.afzal@ti.com> (raw)
In-Reply-To: <cover.1358871750.git.afzal@ti.com>

From: "Manjunathappa, Prakash" <prakash.pm@ti.com>

Set only LCD_V2_TFT_24BPP_MODE bit for 24bpp and LCD_V2_TFT_24BPP_UNPACK
bit along with LCD_V2_TFT_24BPP_MODE for 32bpp configuration.

Patch is tested on am335x-evm for 24bpp and da850-evm for 16bpp
configurations.

Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
 drivers/video/da8xx-fb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 35a33ca..7f92f37 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -550,10 +550,10 @@ static int lcd_cfg_frame_buffer(struct da8xx_fb_par *par, u32 width, u32 height,
 	case 4:
 	case 16:
 		break;
-	case 24:
-		reg |= LCD_V2_TFT_24BPP_MODE;
 	case 32:
 		reg |= LCD_V2_TFT_24BPP_UNPACK;
+	case 24:
+		reg |= LCD_V2_TFT_24BPP_MODE;
 		break;
 
 	case 8:
-- 
1.7.12


  parent reply	other threads:[~2013-01-22 16:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 16:51 [PATCH v3 00/12] video: da8xx-fb: am335x DT support Afzal Mohammed
2013-01-22 16:52 ` [PATCH v3 01/12] video: da8xx-fb: make io operations safe Afzal Mohammed
2013-01-22 16:52 ` Afzal Mohammed [this message]
2013-01-22 16:52 ` [PATCH v3 03/12] video: da8xx-fb: enable sync lost intr for v2 ip Afzal Mohammed
2013-01-22 16:52 ` [PATCH v3 04/12] video: da8xx-fb: use devres Afzal Mohammed
2013-01-22 16:52 ` [PATCH v3 05/12] video: da8xx-fb: ensure non-null cfg in pdata Afzal Mohammed
2013-01-22 16:52 ` [PATCH v3 06/12] video: da8xx-fb: reorganize panel detection Afzal Mohammed
2013-01-22 16:52 ` [PATCH v3 07/12] video: da8xx-fb: minimal dt support Afzal Mohammed
2013-01-22 16:52 ` [PATCH v3 08/12] video: da8xx-fb: invoke platform callback safely Afzal Mohammed
2013-01-22 16:52 ` [PATCH v3 09/12] video: da8xx-fb: obtain fb_videomode info from dt Afzal Mohammed
2013-01-22 16:52 ` [PATCH v3 10/12] video: da8xx-fb: ensure pdata only for non-dt Afzal Mohammed
2013-01-22 16:53 ` [PATCH v3 11/12] video: da8xx-fb: setup struct lcd_ctrl_config for dt Afzal Mohammed
2013-01-22 16:53 ` [PATCH v3 12/12] video: da8xx-fb: CCF clock divider handling Afzal Mohammed
2013-01-22 17:03 ` [PATCH v3 00/12] video: da8xx-fb: am335x DT support Koen Kooi
2013-01-22 18:45   ` Rob Clark
2013-01-23 12:27     ` Mohammed, Afzal
2013-01-23 14:25       ` Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c831d47d82bc2910fb77e460b6334e331e9704d6.1358871750.git.afzal@ti.com \
    --to=afzal@ti.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=prakash.pm@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=s.trumtrar@pengutronix.de \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®