From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B37C433FE for ; Tue, 22 Feb 2022 10:03:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbiBVKEL (ORCPT ); Tue, 22 Feb 2022 05:04:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbiBVKEJ (ORCPT ); Tue, 22 Feb 2022 05:04:09 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0F6EF5D1AE; Tue, 22 Feb 2022 02:03:44 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B0A95106F; Tue, 22 Feb 2022 02:03:43 -0800 (PST) Received: from [10.57.9.152] (unknown [10.57.9.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C61B83F5A1; Tue, 22 Feb 2022 02:03:40 -0800 (PST) Message-ID: Date: Tue, 22 Feb 2022 10:03:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC][PATCH 1/2] dt-bindings: power: add Energy Model bindings Content-Language: en-US To: Viresh Kumar Cc: linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, rafael@kernel.org, daniel.lezcano@linaro.org, nm@ti.com, sboyd@kernel.org, mka@chromium.org, dianders@chromium.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org References: <20220221225131.15836-1-lukasz.luba@arm.com> <20220221225131.15836-2-lukasz.luba@arm.com> <20220222030337.ijnfrh367illmidr@vireshk-i7> <147e48e5-e310-cd8f-ba8c-ff32e3094be3@arm.com> <20220222094547.tgj4bciq6rez62nk@vireshk-i7> From: Lukasz Luba In-Reply-To: <20220222094547.tgj4bciq6rez62nk@vireshk-i7> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/22/22 09:45, Viresh Kumar wrote: > On 22-02-22, 08:06, Lukasz Luba wrote: >> I'm not sure if that would be flexible enough to meet the requirement: >> power for each OPP might be different in one board vs. other board. > > Don't DT files overload values from board files all the time ? Why wouldn't the > same apply for OPP table as well ? In that SoC and family of the boards, there are no such examples. It used to be popular in arm32 boards, but I'm not sure nowadays. > >> AFAIK the OPP definition is more SoC specific. > > This isn't about OPP definition as well, but just that if DT allows you to > override or not. I think it will. > Redefining the whole OPP table, when the freq, voltage, interconnect, and other old entries don't change isn't too messy? As I said, I would prefer something lightweight, not redefining all stuff from OPP in every board file.