From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751703AbdF1Sob (ORCPT ); Wed, 28 Jun 2017 14:44:31 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:42330 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbdF1SoM (ORCPT ); Wed, 28 Jun 2017 14:44:12 -0400 Authentication-Results: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] fs: System memory leak when running HTX with T10 DIF enabled To: Christoph Hellwig CC: Keith Busch , , , References: <1498667571-14275-1-git-send-email-wenxiong@linux.vnet.ibm.com> <20170628171031.GC2650@localhost.localdomain> <20170628183141.GA12722@lst.de> <0fa90019-5b07-7afb-8915-17c54a22709b@fb.com> <20170628183818.GA12860@lst.de> From: Jens Axboe Message-ID: Date: Wed, 28 Jun 2017 12:44:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170628183818.GA12860@lst.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:180::1:dc49] X-ClientProxiedBy: MWHPR10CA0055.namprd10.prod.outlook.com (10.169.238.17) To BN6PR15MB1187.namprd15.prod.outlook.com (10.172.205.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18edf86c-5aa2-49c2-86af-08d4be55a71f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN6PR15MB1187; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;3:NPcmPLLzrXLIEfjzHZoLCunIVGZzkfn/FAkoqPkJ+qFyxf+rppNgaoXpl48V8FcnDfi76I4ve2HT5EvsgGRSJwo2fuT5XrVUdhPeJ/HIXitMtKWbckg5Y54uyH+/mmLETetpvAH/zTtfRMn6cIfLQNpl2NcxmRA+rx/qocMD995x6rM4Ir3N//eINAUxWarPiPmiRYZtyGPMAyFerFRYJGTEbtQFltXt3DC8zzN/jMLVwCMpEAudTbWTNAmizbnDx2aaNmz8HsjtvxuaadSnDOZNBm2Xhw7XMX8VpcTtf4lH/41kytujdURVwx2QjbkYqsM3v0OVTTmL/nzRr+ZNOpDVsNAminPc+gL/AdtSy/66AC4/F84nI2OKwBDC+lvpopAkbwk5AfUm8u09uP/tzOuvyC+7DEBd1XrnSQb+lJHRyGijrJoSa2LbIgUJ8Cub8tEVER96QXoQgdnMVOB5lrBvq746AShJaZYtrJe5+20PH3JR9Bwo4RFBYv6e094MwdCjrwgJZwFBdssFPo0dW1G8ik1UgvxL5k5XkX0LP+IzcUTmlZch2LGPiip8la1Z8PWcX0RSQrVQ26YIvJRLVdy/jR9x1CzBqMs+PnhiZUCSPbmHB0KA+/3uxHauY2mZxOSHxvEm4clJcW85J5NBpe70/51u9VChDDEiiwse+T7VB2b1XNdWQea8F1W57zmXUpI7U+mkrIjTxx/Xo1I1M/vVOWmhViKuoejV7zCyYLc= X-MS-TrafficTypeDiagnostic: BN6PR15MB1187: X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;25:NmEBOo/trF6xG3QEUNc/wuPs9KT0Vw0jthfwIG23v+hTfNgzKb1xnlbzfFtj0y/C8BDqf/4ncgwi3HcTxv7w5+2Vo9eOrZXZApK4w2PWp/OyMg0U2+/bY8wJu2ikcFrKsaY5+Y26fHMwbdhXzrJ4dVUno1apIs+hTTf7vBchDT7zEysGiqDwNCgdD9s7whQMQNjCBvLl+phNiBsFTmxEzqiALypFw6eQZ3wkeIjPU14PlEHsgWaMLo6PU/otcldrk7zj3MAhJ4+5xiCNEBx74yNGR0H5TZU0Vtq3OboWq0JgwB9+n+wMgXklueHiBNFA93edhvQooZSh4niBDwiT+zZG9Y83+ei7KCmFvSLXcfdHD6qc5Rdb+UXQ0n0S6h1KPsr2MT1emkM80sjbv4VNpnXC7RzQ232WUt6vnbOhWHCved9P+cTtwRbtjI6rL5wS+0Gn4LG1l3f51PVzqz0ccC21aU+Q5niOx15jSYk3ArWSAZ4GuYTIPK9GMILrgmP2zLJH+L844sfMcnkGcP+S6V02Ull5zoRMVFdtkxhI0C+TAs68fXgFS1sTRXPO4DiQIf69eIQwi+l6UjgDIXrGDF7YqT6g81/yB03qBqc8tv7WXk7FwEF6wKEKMDgKNW9mze7K3SRlKScmtdEObPbk3mlBqtCPcOKYzltFs9kQHgyjIwl6fDXDtRYp7fBQEkNr7rANTminjBPlEHJ5dr0H6yj3KFMdNPgvTL/bdBaLnQlZwHMaeC1hZWKIVVKkX8kW+3fPO7PMgH9xnYMoXSkhrhkJjU5XyhM2n72dFSl3d+JGto4vIjhmXDMHsGm5GrPSLbD1QwBOSRwV5EUKrQV6ukq7qEplrOUla10cM+5iNrDb+PbVHMHXY/sD3r3ztOiEr4HJxB2ACWhH0HaSg9i8Gu+DlpdNnZiAfWyBGc+RAZc= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;31:8RwLw3uLkp0qH4E6qiRUjZLS0D3pcEHze2BTJQso+5mk1wTfQ/0HYcgRwB9i29tva3f97QPag5QauuwILlVMACCItk8dl/o0P9CHuaXh8kd40nZUXCQG3W96g4ATiBOpxJ+tnyHf0DnBEIY8gMBbDCdencyI27apKXPViz+FNHYvEKVTCkfxsho+Tod1Be7T7hO2eFBRikSbNoFzB1xNJKrH+KkljxQebWcjZB6fd8irN6zGJCLzW0UvVd7K3IeSS6snlcAh0s2RnBXMIwK528AKwqFYuhm+NCIoFfXS09E852Xp5mjdQdIkKpIc48tBL7aOq21oY6ihhBn7eDQF/RBjFCXr6qJ0CzTf6Xc6Rng5nYardBlv/jsk6ac7I/Ytl/eaTaRl4BpkjXFfR0mAwcZ9TQuAIZbFgc+g3kEEAXBuAQRsIkT/kUq8+mfR6c0mu/mK99KdsVnTIH7706S7UotHTrnNxgL51yaGhD4cv+3UmUc3ebKxDPXVLxtcGPT4yF7lu7cIuXaenwOKkPrr4kf9TZ5zpvRRnb9d8wbjfl0J/uVctmOk+Uue10UdVf2uwy9V/68YgYut0RI1PUaO91x8Uv7LeNJpq+PKbsU2iC/CryJ5OUG5bZ5RAYqoFr0J1IEcU0kXjc2TfjOY+GvwrhuWXunuzsHvp54+ARnk3Wv19ISce9TesKf0WGmCt78VRDMHlv5QyjpsVLjmtbDfmA== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:NwW2sQDjuXEzfgCVVcE+1QDvADxhFCsGoO9KVy0L4P47nNM7PUFvqWKyllYxIlXlhlA9hyCUOh576FnOBTkOL3vLe9WsLsgQqBRplRqWFydTurCNBuSv8E2B/KXgBFpQmkcH9o/BgM7M1+K8C5nRn1YNh92W+K8JpnbBcUoEZYpV7sER9m1BvdRruos9TLml12WJXNI54qzgnFWJWaLvZdcWprTc5JvijoPdP4XPmgV8sDhZedC/ZzxjER9MTHslHOlxCR94pHBlg8RW5uUecCkv/qmkk3WiPmcFiDmf4dNHY3hOPBcMP8YwIDXiTWOIyIyYuekupEe9P6tplosJ9kc6rKmQ//MrgB4iKzDxMjbweqglZfJ4dYmTmPzjDg5QC7ILF9augt5f+WPiLMRENnKIzdHVVKyWdgAglXXr8R572pKxSkrDgviZec4sVbBID/t3duA60s/95ilJ31jXk5g9B7/IMoMBCKj1+MircXVkLRQDjIB6LMt4kJ7Ulv+M X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(247924648384137); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR15MB1187;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR15MB1187; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjE1TUIxMTg3OzQ6VXJHcW1QYVlEbFJvRUFVUHRQLzBlYkJtZEN1?= =?utf-8?B?ZUk4cHpodTNyWkNJRHhyVUFVblNraU9RYmQ0WEg1NWhaS1QydXUyai91anl4?= =?utf-8?B?eGRDaHpQeVBXU3pmb29rMVFhYThEM3lFMzhEM3YydEVRV3FXSWY1Nm41amNh?= =?utf-8?B?Um5qVmJVUm1VVXdZWGxmbU94c3lLRm14MGFMb0twbVB6WElVS1FUcmlsNjkz?= =?utf-8?B?QTdtaGo3eHZYQjY3QUVxUllZNXpDdkVkcGRVdnk5QnpoaXpwYXVQaTNZcXZU?= =?utf-8?B?ZXk5KzFJaW93SHVLWHlDaFN3Szh2Yzk3N1ZOeFhscVdtejVHRnJqYTN4UDE2?= =?utf-8?B?UEdNalNrN3QxWjhPMUZnN2ZGTE8vaERibWxTdzRjeWw0c0pMb1FDUkduZGk0?= =?utf-8?B?UGVESmY5TmNLcWpmdFJGRS80eUxwSlFjSUF5eFlaZEJ2STVOSWpFQi9oZVRy?= =?utf-8?B?Y3VOZzFjMFFQWmlWcUVmbHlrUU1hMkZjVWRuNWEwcGg3MGh3M0tudm5reGN1?= =?utf-8?B?bFZmTXVla21NNnhwZGs5SDhQVHlpczdwZW1ZZTA1bjlGdTRzZzMvbVI2NG9C?= =?utf-8?B?cStUa1hHYituUHNlSGdBNGVEM2Y3MXZCNU0rQXZ3YlJoSTY4TDQxeXMvMlRv?= =?utf-8?B?MUxIZU41czJSelJCVFd1ZDhySzVjNHdkNlozYVorWkd3QnlJYjVKamwvdmh1?= =?utf-8?B?ZzNGb29kaWZ2OVZWZGUwRHdxSGIxd200L1JmN1puMVEyZ2thUkRRVVBDWWJ1?= =?utf-8?B?K2JCaG92WFp6YUhOenJab3c3RUhzMThnVmNDRkg3RTNodUZMdXJpTUs4Q2Fo?= =?utf-8?B?aUl3SHRTWi9FaUF2Y215Q0NCVDlBdElmaTNya01ZL3BqYmNCSFIyOUJza00y?= =?utf-8?B?clpqd0N0dnVWMmt2Z0MrbU1GZTVKM1VKMzd6UDR5d3BmY2s0aTNJUysvVk9L?= =?utf-8?B?alZJdWFGTW1JQURiV2srN3BjR2xRb1ZKUitCSEkySzRiNkR3b05DWFdiT1BF?= =?utf-8?B?RjF4Qmt5d2FtNFN5MEIydm5SUTVFa3ZsYkoySzFMUUlGTWFiWjY2SG5kOUxM?= =?utf-8?B?ODQ1THcreWVvRHpDN1ZkMVFSVHoxcng4MGlKMTJYYTEvU2F3YjVINDhTeUlU?= =?utf-8?B?ZjdSRis3MVpzRENEb0lwN0RuNVlBOTRSc3BlanlFTXdiZmI0a0RGWGhyYVJ3?= =?utf-8?B?ZFQ4MHJXSG5UUWdZN2hKSVNWVlAvWEZTTElZZ21BaCtHa0Y3TnZvYmRGT1hp?= =?utf-8?B?T1YzUTZhWWZVU2NKUHFGWnlRdjk4MUZEdGdpWnVmVlVZN3FiQlpoeWJ1STUx?= =?utf-8?B?Rm5ZOW50YU5ha0NYTXhTQldLM2pkOEVoYmtLTjhDNlB5djBXS3ZieFZ6ZExi?= =?utf-8?B?SUZ3Zk5veWI1RGR0QkdwMFdHaGtwSENFOG0wWGMvUFdDdDE5RUY0Ui9YTStF?= =?utf-8?B?M2Y3dHZ5Sndkck9kYmNpeGgrYUxVSldvR3RON29iNVRpWDdOY1g4OWF2cU5W?= =?utf-8?B?UGRnRXRWZW40NE9KOE9HbkJIRTEyTTVxZ0dmRHM0UXNUU0NxQVRlb0l4UXBT?= =?utf-8?B?Y3pxUXRhYm1lMmZyQVNaaFp0aVlZUWJaTDYvbnMyYS9zL092bDdlQ2gvNHFI?= =?utf-8?B?YkovUkRTTTZDRFp1b3hDWXN2QlBVYWlMTkhqMk1FWlhrcERza3JpWnc9PQ==?= X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39400400002)(39410400002)(39840400002)(39450400003)(39850400002)(24454002)(377454003)(8676002)(6916009)(42186005)(6486002)(65956001)(53546010)(25786009)(4326008)(81166006)(2950100002)(53936002)(2906002)(5660300001)(93886004)(86362001)(6116002)(54356999)(31686004)(6246003)(76176999)(50466002)(229853002)(305945005)(110136004)(230700001)(189998001)(50986999)(36756003)(31696002)(47776003)(38730400002)(23676002)(33646002)(478600001)(4001350100001)(7736002)(65826007)(83506001)(64126003)(65806001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1187;H:[IPv6:2620:10d:c081:1110::119a];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjE1TUIxMTg3OzIzOjFCL3lYeHZMVklFU1RQakRreWtyV2hOZi9X?= =?utf-8?B?eStMNmpaZDJUeXB1L3VmLzBXZnd5K0Iwd0U5ZmNrREVmcTJ4c1hqN3l5ZGVt?= =?utf-8?B?c1lRT3VnT2l5NGVDK2dWZzBCUXZoaFhIZTlHQUVIWDFNaVdoVU9Ka2gxVFVt?= =?utf-8?B?dFRYLzBaM0pJYW04TmwvK3RweXRnQkhYSllseVlHU2N2UWFreVJPVEs4Q2xD?= =?utf-8?B?aCsyVGVCZFN5di9LdjBnMi9Md1VWVE5XN0FQeDdhLzl4TDZXTXpRdjhHL2JV?= =?utf-8?B?Q0ZwOFBJWDIxa3Z4Rno5Y0p6ZG9HTzNWTFVrRFBucTdycC9EOWZoN25jNnly?= =?utf-8?B?SGtJR1ZoamlkcmYxMnhQZC9wUnA1TmhJM244STYwVHlzc2MzNDJFeW5aVzdq?= =?utf-8?B?Zi9tYnhOVDh3dllaSzYyNzlNa2VxOWRUTGFGdy94UDBOUjk2Um0vRS9Kb3FJ?= =?utf-8?B?SmlRSktxdklvUEVPZVBSK1BvNElnSCtWMTdtNGR5dDd3NFUxWUJaTy90eHVP?= =?utf-8?B?b2hrVUk2Zjd5cDEzM09PbHZWRUppTGlhdjd4WldvWDZtRVB0b0ZDdEdVa1dV?= =?utf-8?B?VUlnTjQ3YXRjcTdEbEdsZUR1dHVheWN4UmZEQldNa2dYTE5STDhkNXpHRFBP?= =?utf-8?B?bVRRbmhmd1BUWUt1dnlTOWpNblJVWS9HVzR5RU8wYldWejk1UDVrVVhtU3BG?= =?utf-8?B?NFZUTndEbWdOZGpjWUYxc3ZlbWdtV0RsUXdtb1p0ZnREN2w1b3BQSFRnWnl1?= =?utf-8?B?bUdCY0JLbnFzdmtpdUk3VmM1cTVnNXdER3hnOCtNaVFKVm45dUEyazBwNTNi?= =?utf-8?B?NWJPVVEraEdwYUE1cW85QTNUOVZPaG1idHMxTzFabUZRTXRTbnZjbEgrRjIv?= =?utf-8?B?ZXF6T2s5UEdzaWtuQ3FCcGYrcW5ETFA3UFR3Rm5pMy9jTk01ZlV6WHB4Ymov?= =?utf-8?B?bW55RVRSMjVEeHdXK0VUc0x2d1RSNlE4SHI2a0wyQkF1d1dRQjhiRTVjR3Q0?= =?utf-8?B?MXNPZUZsZDlJcVNPV3NYYUozQklOTE4wSlEzbzJGQ1hxZkZxbmlSY1Jua1Fr?= =?utf-8?B?cENsczVoazJrTXJrWXM4K2FTN2xlc0RHM2FGRWdvZ2Ntb0p3RWFBN2hSWC9K?= =?utf-8?B?ZmNYa0I3clZUa0tqS1FCNkRLaDFQejFubGhYa0FoV25iSVpCNlo2elZKZ3Nu?= =?utf-8?B?cHVsUkViaHpVSUVlQm1DcmJ5anMvQ20vQnN3VTRsODNIN1grYnBzMHlhb1Bn?= =?utf-8?B?RDl6VU5oZzdZa0hqbDRucnZoVzM0dXdjRllFTVdZQm9FKzRXQnRDbjA1dHVo?= =?utf-8?B?blVRdnMxaXBsZ3F0WVp5Tmdpclo1bG5MZ2tSTXBSZmd4VUlHaXJGUkVGQ1VV?= =?utf-8?B?MVBHWkQ1VkhkT3JKUURuNXZ6S3d4ZkNGRVA5aFI1MEZLdG13cysvUlNMNTM0?= =?utf-8?B?eW9DQi9QbzZlWDkyZXlGeFNEb2FkWVU2NkNoZGJYQ3haallsSm1NakFtQ3F6?= =?utf-8?B?TzNzUnJFeGhDYy9seno3c2Jvdm5Fa2d5VmhJSExvZFlEV0h4Y2lUZGNsV2ta?= =?utf-8?B?K1FWajIvbE0yYzdhOVV6cEd2cVd0eTY1NC84L2RtYjdSODJKSFV3bEJLUFNa?= =?utf-8?B?YTU3WTFOVkpaaUFZYUxOT25aQzBsTXFHUHIvVDBob01Uc1RyazBncUZnPT0=?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjE1TUIxMTg3OzY6M1ZEd2ZuUjQ5bVVqS1lORm1vbWFNL3lraFJL?= =?utf-8?B?Y3Q0QTVBUEM0WDV4MDRCWDRrUE1SMmx0aSt3UUYzd0hJZlRtNUNDYUpEYjc5?= =?utf-8?B?cHRqVTJyZnhLajF2UVByTVg3dHlwa0cvR1NjRmpSMHRwZU5ob2VMRTZydDJh?= =?utf-8?B?Tjl1c0xTL3BlSGhVZ0l3V2E0aU9BdTJnSFhsMGZ6b3U1cndsMG05czNaZFps?= =?utf-8?B?N2JuNXdta25vWE1xNFQ4MzE2UVFESytkWDBaQVF6aWlhTGlYcEc2R1RKTDEr?= =?utf-8?B?NFR1d1dlUDgrcFo0TGJDN2M4KzAwbEp2dXZ5bUEzaDFodm50bXNFMUV6VHht?= =?utf-8?B?U0x4YmZGRDNNajRTZE9XR3BnN2FZN2hvRmJjeXVkZ0hiZVhZVGtNMzFlZVdu?= =?utf-8?B?djBJVW4rRDdBSXE3VHZYOW1Ya0E3Z01PaXdHTFJTMlIwWm1LaGgvY3VmaWRC?= =?utf-8?B?SXZGYlN2Q1Z1d1Y2aTZQYUZ6QWJ0ZEtWM0RtaTVYOFY0NFJLc2Y0WUliV0lq?= =?utf-8?B?N0ZCV2szb21WTmtmYWg3SUJnRjdnSXhFR3FzL29KcE9IdTZSdEc2MDRFcDBG?= =?utf-8?B?UW8wcnB0N2tYSlZZSFBNMnR4MHBOSGNBVFc3MUtMam9MUFRyY0NQTGhHWFZm?= =?utf-8?B?dG9VU2R5N2E5UUpteFd3UWtoN1hBb1pEK0I3RWJrRURCRlJsRXRJZ0E2Tlo0?= =?utf-8?B?NVE1TW9XZkg3NXZ6L05wd1R3ajdsNXh4R3UxUndaUWg2WEl1YW42cFV1S1Jk?= =?utf-8?B?ZE13elhhR0gxYTlCMGUyNUhzVXdqZzVQMlljVHU1WHdjSnpSZThOSjBEcito?= =?utf-8?B?TEQ5Tis2VEsydGd0ZFpzSEV5bWFzV1YzQndQTUV0Qk5vRWgrYVJxbUIyM2F1?= =?utf-8?B?amdNSmY3OEVIVW5jbzR3cDY2TDZjaEU5RlIyMmc0b0pYVkowNGdRUm1jMGdk?= =?utf-8?B?bjAvSHNJQXI2b1UrdDk5OTMrQ1M2L2I3aENqM2JIQmVxNUhmQUdlTDBiemZx?= =?utf-8?B?bnpqbnNFTnFmR0dtOFhpZ3B4M0RSNVRNZkdPRFJ5RmVsVXhic1pSQmE4dkIw?= =?utf-8?B?Y1hhVmF0TFlUVFhFZkQ4c3cvRzVoUlBtY0VJSHRtTW16TXBpSmhlVlRqK2lB?= =?utf-8?B?Smx0L0pCQ3RsUEpuKzRCdVcvd2Vqclg3ek1JUkxmcm1xOTVLZkFUcjlGSUgz?= =?utf-8?B?dVY2TTRFcFg1RnRtQy9HeWQwTjJHSVUyUmhVa0FuamxGd2ZMZFVqcFd3aXFB?= =?utf-8?B?eTJuRkd1QmJCSS9mMFpFU3VDTTI3SjBlRnZtY3VWbnFZRFdqa01qYVY1Smgw?= =?utf-8?Q?84AluMUTFKdvaalHhBQjhBIESbC/94Q=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;5:EHa3m6O/DMEls7+tn9UXsAZYkCQ1E1BN+IArOYbD8BxZO9U/599o2oToENF1nBetk4lVNt3OlRA0oqnNcvg6ab6BP98h1Byx05UI0gZ2GQ9yTaqX8MCuWviOqHJzgYi7AU5pu+wOA1WjMu0UrEZZuJiuj5kW/1q/xyxw4dMbCyIczsFm3CLTdFwRXbw6uwgSlwDklkHRS1Hsvo288RPtKn+ua9zYrKef4IZqdxHaZxmAm8/MrQ3Gr3DGqqjdm6z8ehiO7jVw+mHFnDZEFfsi5LOKIt6TX4scMEEYQgMvxlPipCHDjP6MLJ2O+Ak/w87nRsZg5HDJ6DO12gSA7b3wNtGi7T2Cune+RDoEYXjp7NM6EiJRWobLMc30PvSZdjsjOsKGFzX/kJJJhW5pDvhmpTCvpMjYs6Q059+QuQylKsEtxGp9EuWtbAEyY4/htlAhtJcrU9T0gFoq3kuh82rUExpdRCcfTqAVYPHuppCB9OBBG3P4EJYdKfb607RTC/wt;24:LKZhS7IY4dxvoBapFy2gSKsNT+SOiTPvjAQTo3sz4CZV8fIq7KA2xR9yQcwwbWM9lO+tEvrLLiaYa5wC81OXlb0W31vUQ6K+3GdzB6tdX+c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;7:P3POtK5g9V7EuJrmy2SmhF8ZELpA05AyG2HmHRGnoCrUCylZ5uPXzVDGT3ob6DTAB3VFEY564TMPvXg9Z3MueMx0JD4Mw2tHKe0XIFR+/THjdCJmRi7SZhCMgQlPe+MWbcB8toaOT+gASTQxxGpfFW/VPiA/xjuCDZmYnA0/ZkdV90aNZ2S1gRnnKRQEnMpljDUzqyQokL7GdPm0BHeOF7uisgw/KRjq5ORCdPEuh85jdXgQdluoW/xU+avV35zkA0s/Ls0riBc35GJYxK1CgwvTD0snrMGqaiJtRSc6iVqId7gEM938ktoopwnC/NaeykPSF8V7gmcLGLdaXcwkPiiQUdZ+QhDJ/97dvGIMg1GJLS4UCxPuAIWAbRtYreN+4xeZNK1fXf1IVmbWVofAWjKqV9Fz4qSsR7QvTzNakv45EJqfV5OmZtUAEYyLrntFyf0dvfO5eCd3t6Buw/WXZrUG5t7VvBAhdrwaasSZ/NnbH0IBkxWmFNlua5eVJGtaYjRss84HRhuLO27Uz8w6J/lGt34lQCyT0ace9G9Qf8z6Ak0gEvyjstRxPk2BYWV0ZtgFpFkxZ4zxl2MTKzNVrzppU6lous4IeqUScnk3VN3YGxX8kA22RoT3GUJoDiVuR51jQwVn4k2aNMrP+uj3/GJxKRRvfPrFxf/hP96rSrS9vBlU0FamWjI6p6Qr4FPeJ9/Xpg9bhh7hRlRky4wPxTWeaa9sXR513xkr5NzrylEh+yO6W1k/ei1BAoNrzhGbG1bvKVRyHZUEQxIG82z2f1dPtkVaPavHJPSIjn52Rh4= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:WbaOjzREQ/oQ9Rfx5YoTTkwxNiVp9vAehpPn21UUX9NCoITi3On/b9Wa/sMnIEbeIOftCZbS6qZdnJZew/+aEMIRRMZ2w9FXrHkLImRi6yzeSbEG2EP8FPHdkXD+C//4RzgWs6G3UvIpjfyLvT0qdVlOPRFW/iYU+K6F8zffw3w= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2017 18:44:03.9566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1187 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-28_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/28/2017 12:38 PM, Christoph Hellwig wrote: > On Wed, Jun 28, 2017 at 12:34:15PM -0600, Jens Axboe wrote: >> That's what I sent out. > > Where? Didn't see that anywhere.. Looks like you weren't CC'ed on the original thread. About an hour ago. >> Here it is again. We should get this into 4.12, >> so would be great with a review or two. > > Can we rename __bio_free to bio_uninit and add a comment to bio_init > that it must be paried with bio_uninit? Let's keep it small for 4.12. We can do a cleanup on top of this for 4.13. > Except for that this looks fine, although there are a lot more callers > that should get this treatment.. Should only be an issue for on-stack bio's, since we don't go through the put/free path. Did a quick grep, looks like this is one of 3. One is floppy, which probably neither has DIF or uses blk-throttle. Then there's one in dm-bufio, didn't look too closely at that. Last one is this one. -- Jens Axboe