From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023093.outbound.protection.outlook.com [40.107.162.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73C233D952A for ; Mon, 20 Jul 2026 09:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.93 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784541390; cv=fail; b=ZUIdQUw3rVv31UmFXKwg6g1wWBNm095lk8LwEAna3BCC/zeZBYwPZlV+m7e052sQ7INC3OOHhqaGvgsI0G/g8nl/kN8dFmWAaPb23TksQ9x8rym3AtHhn7VarB8YtFkuHURo94C+AWFMT6QRL0ABZ7XfBo/iJZKieaaRPvj1Dr0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784541390; c=relaxed/simple; bh=zZg/o5fEj5obLdsNzB9Ko+FEtcYNL7D3PPH7ohi2uW0=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=aWW4agajxE8SSFqZYNqluN/25zfZqnkYhbBRm98TDPAjhVIp+piYxQ/ZqJ4bNaEHm4RYBXT9kcn4IW1mvJyt8qKpBUvT/1yPTaO1ljc2bwGxSCpy4cA06Zt7cFtM+O88wZDYMbe59CTixt5a1b6WL6kivvZ3IDq1BIUy2NbC2AI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=virtuozzo.com; spf=pass smtp.mailfrom=virtuozzo.com; dkim=pass (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b=FHrLFKeC; arc=fail smtp.client-ip=40.107.162.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=virtuozzo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="FHrLFKeC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M/zmKTwk7UuS5hYo7vN5Z1rkcRKseZj/9tIjIscw8eZbDABzhTex+boCzeZW3V8LCKJNZsxn4Emdow2bjrxuE06M3MVuCKPX/sHqvt2WFXRddC6/tvW33aCPCIRQaLaQvXpk/MA3VEQvrTYmxa8SNYp1YRo1ssugvzWnDwwxaVaeHes2X5SWlIGhG4Uw+BQw+zswdM4zNiSUQsA/BbpZyNnw42CrbUHToGjRECFXNVT7DpFeMvjoo63Tj/yKFbwCFUCs+xkUWsGcsxjnP5bVseqOfv2i3Txx6VpKEPnhJOEjlCpYA4Ot1DLn9hSNqmfyix//poTiRqZALQkJcfuPTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GdstaDTqYZVedGrprs0yqfAawl7HVFJ2kfh9HhXYoOg=; b=IRi4Jz0sgi0sg2crV7Bs+lwXPyy6fk5R7hss2hhcxKkJ172VPTJoofF1t1EaR4BM8bbS6SbaTtxCu+PBe19wn3cZnArSjV3zWZ0kbYRsVhhE2oryC7SD3lHTafap1IY8SIJBGM0nuJTEAMIN0B50oXJVaR2FukFhJ8jBxPHp+UbEd8GZCKfHa2uRyfYOHFODpKN/E/T1iIQ/pmpbarCXLf0ROUM5TUq0yjllkXQeWre10jFWK+kiXXfEp1auwmLtVJhRyP7pTUphkpdWLX9BidHuU4Cn1HmppmuqXlLp1nDBKr7XNzNrBYRshKcCBOGDceTqe+MS299dTafk0SLY2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GdstaDTqYZVedGrprs0yqfAawl7HVFJ2kfh9HhXYoOg=; b=FHrLFKeCO3YqkSceVdADX78lJNVOytVqSSfilSdOjBXwYtAp+p5a1esjZfXqLVn2Cn7ZRyshY8iR/+S4CqpRFlT1lJ3UiT4YsRLNVl6Q+HcaUS3nSzHFl7iwN0vbiWvhQBOJZ8cDwF+WW1t/EsbandcygTAckjRscNXHQ60VQw5eBvrBDzTlZggxepO8RQMavSfwI/zLgSqwtWZAbPXkO9SK73MWxYCf0sX3SSBgRal2ACz8SZEf6K9RVOzBVXraIg6nYQkVA4yp99oTkUKmkGSo4brGoo8g5K+/4+U4SCUHSUtyFw+LHBvTIeGtzdk693Lu6hWrVFaLZYbTMY4kuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AM0PR08MB11804.eurprd08.prod.outlook.com (2603:10a6:20b:747::14) by DB8PR08MB5500.eurprd08.prod.outlook.com (2603:10a6:10:11e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Mon, 20 Jul 2026 09:56:17 +0000 Received: from AM0PR08MB11804.eurprd08.prod.outlook.com ([fe80::bf46:f137:f6d2:5b3a]) by AM0PR08MB11804.eurprd08.prod.outlook.com ([fe80::bf46:f137:f6d2:5b3a%6]) with mapi id 15.21.0223.011; Mon, 20 Jul 2026 09:56:17 +0000 Message-ID: Date: Mon, 20 Jul 2026 11:56:15 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] pid: deinline kill_cad_pid To: "Cen Zhang (Microsoft)" , brauner@kernel.org Cc: oleg@redhat.com, akpm@linux-foundation.org, jack@suse.cz, avagin@gmail.com, mjguzik@gmail.com, include@grrlz.net, ebiederm@xmission.com, legion@kernel.org, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, tgopinath@linux.microsoft.com, kys@microsoft.com References: <20260719155842.7069-1-blbllhy@gmail.com> Content-Language: en-US From: Pavel Tikhomirov In-Reply-To: <20260719155842.7069-1-blbllhy@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BE1P281CA0243.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:8b::8) To AM0PR08MB11804.eurprd08.prod.outlook.com (2603:10a6:20b:747::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR08MB11804:EE_|DB8PR08MB5500:EE_ X-MS-Office365-Filtering-Correlation-Id: 62765214-5853-4de7-054d-08dee6452449 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|10070799003|7416014|376014|1800799024|10067099003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: CQlrnj+cvMYIkKfMbIq5fSHuQxeyz+55pr36fQ8hV8m0mqWHjwEOJtw4/DfWPuEES4M+SpTYTiltYWvc78KVfykM8G1CHABbyyVZiMtnP1Pn6QpDXU55QdLDc7OlZ0zAaJHOmMkPOPDpjZjUZItr+23kVHwPRF0pBeyG2gm6h15QjbM5Kf9SuyZV82Lu56OKbKU4SJ1XpvFZrmfJHwpH20/oYqr3DwtaZSZQSritOcChMelOFszogZiOzuJ+GXrjlvnOum3xnVzz+84+bwZqfV/q4N4FiSW7Jx9gN8W8xonqFiUYke5WPdaxJHz1Pys0vKTePCSACHAnE+9bujZSlUVPcgLnUIDX3AkZmNwkOa2m1+gd2/wq6LY1oob2JHWder1mA2hT9e+sRckNgG4pgdCWpOkggKBF9Zc1C8RQ/G2ZfVcsWSmMfV5zDQcIa4Yq659bJR+eBRv9JVihWT4h2Ka5teA8jPGBj3wNca7LwSLy6sRQgoUirl6HFsfCWkxgo9w7ELu7QIrxSKp5Ny0fjijQT2NH9AuC5TEdSKP4/MgBJgGPBdU96AoZRqxMmu0dS+6i5cGwkhfWAcG1lbisbLjXGgXeIGtAD5ORW2WsVzJRbHHZTV9pmTs7t+7sA3GNz3o9C5MOiCzBAl+LVEivXTmkgdOl3a+31+aYoRVgGI0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB11804.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(10070799003)(7416014)(376014)(1800799024)(10067099003)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDI3cUJQUnZ0SjVONVR0cTIzeTVLMzFWdGl3R0src3pMVlJvSTV3Mk9TdkNL?= =?utf-8?B?THZFc1VZR3hTdzA0TlVUVTFRbzRSS0dmem1aK2pQbjBIUGJWVFlmMFR2QVNV?= =?utf-8?B?Yk5MbndPVHRTRitXMGJrZFloUlRReTB1OTZUU2hHWkRzbVZiN1NYTS9kS1N1?= =?utf-8?B?TG1NOEpFVGdyaWs0b3RTVXEwd0p2MnIzdnlxQmJJdUFHTXI5MjR6UVZYWnNU?= =?utf-8?B?RG5XZmU3WHE3WUlNTkdLajg1d2pyUU9ibGVpcmRxcXU5Yit3Y1JmbGhEeTlU?= =?utf-8?B?QWV4ME5uVGtMS1ppQnNoeTZqODh0RVRrbTc3UnVYR3pPWmx6Z2RybDlGL3pH?= =?utf-8?B?RmhxcU1jdmh6UDZHck5HU3FUWXlTdjlKa1Yzenp3VlFsZ0dUdGw1MXhqN3d5?= =?utf-8?B?TzFWb3h1b1pZQk5oZlZGSjhEUGdBb2VndXVVbGRVejJDTC9hT0lQTit5bFp4?= =?utf-8?B?M2lRc0lHTG9SQlUyVWk0TzY3MWwxeFFhRGlHcXNwMDI1TnFyZ2dueEpzM2cv?= =?utf-8?B?UzBDRGhsb1duTkUxK21mSHgwK1hlODFhZ0hSVkJNdjN0bWk2RzZzNkNxY2Jz?= =?utf-8?B?U25nUllYcXZ1TjMyZDBTNkljZ2VUcG51T3FvYnB2U1lVblE4K2JqYitteFBs?= =?utf-8?B?RlpOU3o4STdYY2xpVE5CdVJ1ejhQK2pURkpzTXVGdmVycHVuUUthL1JuUldS?= =?utf-8?B?VGxlSVpTYlFLdU12dlFhc3c1RTNQa2lFa210djh0NU4rWXRsK0RBM01oZmZ5?= =?utf-8?B?WnJxQjJqM0YvNE9Ed2VrOWlaODlHdHE1VWE5dHdka1FqRWVZVzBrWVplR0My?= =?utf-8?B?ZGdjR1dpNCs1T3JTMDBXOHg0RGZWVGxYZ0RRMDlsNlNvNHZWN0pHYkRmWjNN?= =?utf-8?B?TWRBZWhwZTQ0OVdwdVNuZCt6WmE5MEVwQ2VEY0hsc21zUjcwd2hySGJLd05L?= =?utf-8?B?SVM3TW9CYzdsbm5JdXJLcitzZm53Ung3MDNxMkpIZW9Fa3F4TGN4L05mVUpW?= =?utf-8?B?cjVZQ2xkdVl3Y1Z3bEIrZ1Q0ZEJDbi91TjAvQzkxYmMycWtMZ1ZsRWN5cFpX?= =?utf-8?B?S3dhMVAxMlhPSC9oNEJoamoyU3NJQzJrNVp5WjhOOGc1Y2xFUXRnYWIwUHc5?= =?utf-8?B?YVorMzgwUURvdFdjQjBGcWFhMWQwTmY1QktJSGxBc2R2bE01cW13N3hub1ZB?= =?utf-8?B?NGo4UUMvS1FsRGdjaXN3T2IzMnhtWnJLNHU2RmUrSXpFVENHYlQ0Ky9Bdyt3?= =?utf-8?B?c2JOVHpyVk0yR0hwTDdNeUtyNk5xZEp4Vmp0RW9iMGtPL096ZVlpMnM3b0lZ?= =?utf-8?B?QWZqaHBvUGUxQzdwNkF6RmFTS0pYTHlmY3dIZ2UvZHJ1d2ppdFc1N2c1bDVU?= =?utf-8?B?NUcvWmpMT2dZSnFZMmFWcm1KclRERGFaWXJmZXZVTm9kUTVCbHg5aFVkZ01l?= =?utf-8?B?b1ZtWU84ckpnRXdhODdFZkZFdExIWEpIbUEybHZvbE5WNHpWcDBEUlJzcStT?= =?utf-8?B?NERqYWFtTHZVRk5xZE8xZ2FaZGtCMjRucmwwL1BhdGZxV0g2dWhHazA2UXYx?= =?utf-8?B?QWRmSXZLWEdJM3NDQXh5Q0xqaVdGWENtYmRWNzhvRWdBZFBvcHl2bUdtVERr?= =?utf-8?B?Um1yckxaZitmczZ3TVF6dldKRCtYNFRUbzR1OGM4d05iMzIyck9SQzBQaWd4?= =?utf-8?B?b2tmSzBESE9leVh1T2w5ZTIyZ0FwNFh3TTM0a0owZFBRNkVuSVYxRkx6UW1x?= =?utf-8?B?WmhLZ29UN3p0ekVoVkx6U3h0VFY0bmY3b0tRVW81b2FOL2h2YmY1c2hBcTZj?= =?utf-8?B?eWliTm9uSGpTM2szcmNlL0ZsUTE4UVRyTGMvZUxpN2Uremg5MGczT3VUN2ZI?= =?utf-8?B?cjJzcWJzSDc0OXd3T21qVlhla3hnMWJWekJhenNTWWpEbUNZd25TdFNFeUtC?= =?utf-8?B?YlpxSUFVN1l5U0pEUlZnQ3VsRnNsVVo2YWw1ZGFFRzgzVHNEZmx1MlhJZ3I5?= =?utf-8?B?dDBQOENESlhMOU1DRjROMjFFY082TmNHNmRHMDF6K05SNTNCK2FDdWM5eTBV?= =?utf-8?B?aUkyc3EvMktoMlFIeUJ3Y01DVWZyVnd6NFdHb2FwcVRRT3FLTWJtZkJkMlNQ?= =?utf-8?B?RS9SN0l1c1ExaHhLcEx4VXRuU0VwRGtwSVFKbHBzWXJBMHI2YzgveHAybTRW?= =?utf-8?B?NUJoeE1JQ0VtalFLR2ZEN1BHRUQ5aUFwSzE2amFrVERFRkxneGlQMEZ3SmZm?= =?utf-8?B?dERaN0dzVlE2ckNub0pRZFlaZkpOMll6SWh4UTFFbWwyRnhCQVI0QXloVzRX?= =?utf-8?B?dEh3UytOejNVNEFTMDBZVUl3K2kyOEMyWmVraG9WWURYSDB2THBuZmZheW5i?= =?utf-8?Q?+RJaiztQToc4Og+0bhyentlouetWv+wuefw9NJORU/+OT?= X-MS-Exchange-AntiSpam-MessageData-1: BQCJcnX6z6xrKwdA9F0GOzi6JUIeK2B2RAg= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62765214-5853-4de7-054d-08dee6452449 X-MS-Exchange-CrossTenant-AuthSource: AM0PR08MB11804.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2026 09:56:17.0831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kpoZ/aYb5V6NXxf7BbmXsFpJkc4N+wUiNROZIfHl4B95M+jb0Y9UZ06V85Q7suYCqlSHDE2DmZ+3mNppn0RmLKnHEoVN6o8l4uABOUhkjRY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5500 On 7/19/26 17:58, Cen Zhang (Microsoft) wrote: > Move kill_cad_pid() out of the header without changing behavior. This > prepares for taking a reference to cad_pid under RCU in the following > fix. > > Suggested-by: Mateusz Guzik > Suggested-by: Bradley Morgan > Reviewed-by: Bradley Morgan > Link: https://lore.kernel.org/all/CAGudoHH0vz=1m97EDHQFLLwGJmDPmqWJ+444b7rMiD059drEwQ@mail.gmail.com/ > Signed-off-by: Cen Zhang (Microsoft) > --- > v3: Add Reviewed-by from Bradley Morgan. > v2: New preparatory patch to deinline kill_cad_pid(). > > include/linux/sched/signal.h | 5 +---- > kernel/pid.c | 5 +++++ > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/linux/sched/signal.h b/include/linux/sched/signal.h > index 584ae88b435e..d45a5476b97d 100644 > --- a/include/linux/sched/signal.h > +++ b/include/linux/sched/signal.h > @@ -562,10 +562,7 @@ static inline sigset_t *sigmask_to_save(void) > return res; > } > > -static inline int kill_cad_pid(int sig, int priv) > -{ > - return kill_pid(cad_pid, sig, priv); > -} > +int kill_cad_pid(int sig, int priv); Maybe we should explicitly include signal.h in kernel/reboot.c to have kill_cad_pid defined there? This already was there before this patch, and it compiled somehow, so it's definitely included implicitly somehow. > > /* These can be the second arg to send_sig_info/send_group_sig_info. */ > #define SEND_SIG_NOINFO ((struct kernel_siginfo *) 0) > diff --git a/kernel/pid.c b/kernel/pid.c > index f55189a3d07d..234ebee29375 100644 > --- a/kernel/pid.c > +++ b/kernel/pid.c > @@ -557,6 +557,11 @@ pid_t pid_vnr(struct pid *pid) > } > EXPORT_SYMBOL_GPL(pid_vnr); > > +int kill_cad_pid(int sig, int priv) > +{ > + return kill_pid(cad_pid, sig, priv); > +} > + > pid_t __task_pid_nr_ns(struct task_struct *task, enum pid_type type, > struct pid_namespace *ns) > { -- Best regards, Pavel Tikhomirov Senior Software Developer, Virtuozzo.