From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751479AbdKVVFx (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Nov 2017 16:05:53 -0500
Received: from mail-io0-f181.google.com ([209.85.223.181]:45417 "EHLO
        mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751260AbdKVVFv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Nov 2017 16:05:51 -0500
X-Google-Smtp-Source: AGs4zMZHp3LhYgumtybDnrl/HvHnD8qWBh6IAjcwoqb6ZIC2gUk3S49LC2FVO/f72zVaCTnYJ96YIA==
From: Woody Suwalski <terraluna977@gmail.com>
Subject: [PATCH] 4.15 vmgfx boot warning
Cc: DRI mailing list <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, Dave Airlie <airlied@linux.ie>
To: Sinclair Yeh <syeh@vmware.com>
Message-ID: <c845316e-c0f8-9ef7-2bf5-97418d8094c7@gmail.com>
Date: Wed, 22 Nov 2017 16:05:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0
 SeaMonkey/2.49.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The 4.15 vmwgfx driver shows a warning during boot (32 bit x86)
It is caused by a mismatch between the result of vmw_enable_vblank() and 
what the drm_atomic_helper expects:
    /...
    ret = drm_crtc_vblank_get(crtc);
    WARN_ONCE(ret != -EINVAL, "driver forgot to call 
drm_crtc_vblank_off()\n");
    /...

Signed-off by: Woody Suwalski <terraluna977@gmail.com>

--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c    2017-11-22 
15:29:46.511674079 -0500
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c    2017-11-22 
15:30:35.344559592 -0500
@@ -1869,7 +1869,7 @@ u32 vmw_get_vblank_counter(struct drm_de
   */
  int vmw_enable_vblank(struct drm_device *dev, unsigned int pipe)
  {
-    return -ENOSYS;
+    return -EINVAL;
  }

  /**