From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED3222FFDD8 for ; Wed, 14 Jan 2026 17:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768411465; cv=none; b=LDxOD86bSnUi5rxzEG/QqQkyKhvJ5t4rmlszBsuhu0q/7gYqWc3fxlVpGjS9NPEMjc8p4nZVoiSp8lD2N26ZPQvmz7Jkgxy5QLhopRmEAu+6QZRYQyOaYda1g8eWegerx0Gxv3aqr2mUn6k/VtO3gZk8SxJoDvnAbx5gQHtRKKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768411465; c=relaxed/simple; bh=qQcflF4w079QNMpZfzmyomZEqM2JpNH5WkaVJP7WAyU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kotkwXrJP07FI48zBVMAlLpMffbHiKWf5k7wAQwlbhlidbJHCDluThebfgL9DYKglEeMRUjE+Sm0dJ1fPVdkVGEmFJvdy7k5OzoPYSEvu8Nv2z0X1ONsKICG8Gc86IUc8l9ilA08SeZ5djsEzZ9kGi1le4m3DzO1hpfZxU1Azi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BMYn0omk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VpvhsLnk; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BMYn0omk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VpvhsLnk" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EB31ih3279777 for ; Wed, 14 Jan 2026 17:24:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9+mDVu2OGbCT81X3aqnLFlTpu1u9SyfEN+WtZVk3UzM=; b=BMYn0omkV3KnPVwr aYc7QEPJX7FQ1zDsOUQwM7ueppV982NjHgRbTbww2X1wElcH+dK+devi1eBD4o7R 31I/Au5ABO8cyTs1ta53A+UbUK4xHZLek6lNkI6T5dCijSRIIpBprL1DxQefB4xL PFgq+WLXG1vRbkb5Iwvc4D/U5n+YiT8b69bg2G+ader+BadeegqhOHILJcrBLoVT X8uhIX29Oo26kV4oPjNvJnhq9kq7ttG6R8vnBnBPtAG2978gS4QSQXhG15twuFiq KOswoKe2n0pUNBJuN/8hyoWz5ZB7SPIOr2xKvFLWf5MGPlQWjlGyDB2UvGasU725 +sS+rA== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp9x8sa61-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 17:24:22 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-1233b91de6bso718880c88.1 for ; Wed, 14 Jan 2026 09:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768411462; x=1769016262; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9+mDVu2OGbCT81X3aqnLFlTpu1u9SyfEN+WtZVk3UzM=; b=VpvhsLnk7JpaVQeOiV9ssHMlE7YKtaPY5rF/g5Mv6jDyLDemz8rtTb3prZtnGCx/p8 YFW0V3VRhX3xxPcT9mCYrCdQTlsE/CF/BIvHmQaYSP96CgrFrXrispnvsDU/XpqvC+Sw HzxkL9M2ZZaheoM2HWlqCFb1uoVDcgZwOWA0+IKUaav4z8oX/vwtMtHHdSgXvtGnX+23 aN0cW3YH9eIShlLer7Vt/mfL2GXwzQODrbDhWVhKIRdQabE2zQpOg+ZBX1lU7OQvxEEb 1cs2hzgRprxwiOVAlitxjPyjz8eaKhiQQH5jkeA2du87U0u6D6JX0aP3Co506uYsCRna TQ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768411462; x=1769016262; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9+mDVu2OGbCT81X3aqnLFlTpu1u9SyfEN+WtZVk3UzM=; b=VL+VFm10dlxY0Q5svEtYRA/AnxaDC+9NWXdS2Gkyc5YpkiRXS91CpoPxbA4ims6wF3 gl7dElcJZC60J2lVRox0LZFzBjREwscggd89t2n2+bU8HR78ebZx7pi7Ynepb+4ybRsi st6Wt4gXCqtmIhYaBHafxk0Ul0v2BDro5qUP/cWr5drEWBKq7o0q4eKIVv3z+CrVo6Kg 75YJ9tsN5hO3ftKEZ+rUo39WS8ItsIjBBRHDMNqYyk/16sv91+zdt+9/M/8lbnaUr5AP fA178GS+BMFqNSeCCoEuyOSXPQaRUPTGT7fp2yTSohXm9Wb8zyHjstPHKKKN3UFBFchy PktQ== X-Forwarded-Encrypted: i=1; AJvYcCVqCAyleAT28zeiLpWu4cSXqCkihlvP4nto5kItTEXnqEQ7DXHJabLMHTKAwDk9xcuyDQnu0KWpNAnwDOU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/UVv15oaI1DMSajm4iF1zaB/uJEQPWTaIJuIW+WXPdDntJUhH ecnBNwB1LGc7+Ln0I7ra9EarrvhjHc7DZamhpFO9LzdoBWyHSu4tI+TZQI2xUN6waDY0QR0h8H0 LdYKJMuDVy1VYFSJNblKl0u55cOBLzs+oEeg6KeZmtzRdVtpgaOBkUisbI56XPP+gMW4= X-Gm-Gg: AY/fxX6DHwycW1I2Oe/wV9X37rte5UDFvwjRDMNa+4Ar79aZiRzlqG38GtYVURq81Vz ACwhQUb4EROns0fTTicOtxnPPduQTKGRCW2MxC++2fz0AsDM61s2Xgz+ovzPhYgEyQ+ea2WaFpb tBxp/7c93b8DchocIHMhPs4tQpRxkfQACyWgigflonaAIVxVdsZrb9Y5Hh+4EOp/JTEJbuG7th+ eSPEftdydIRiDULQFZJu5gGhD2VFZBaHcze40MGOkqBw098NjfNKcr5yAtp6D46y6mm+KYE0w6W 72sHMrIGXmYcVeap//T3JxXvFGESN0YXDfzx3Ccy20+TgabpeOYO1eQzIqgNgrCl9w4s5+rXQbf pFS0qLCpmJDJMda/by8vo93ybjbeTbe/dsf0InnQEG9lrhmYbJrVUGZ879c8hsWr9hBeIeA== X-Received: by 2002:a05:7022:fc0b:b0:11b:9b9f:4283 with SMTP id a92af1059eb24-12336a6d9c6mr2588085c88.24.1768411461903; Wed, 14 Jan 2026 09:24:21 -0800 (PST) X-Received: by 2002:a05:7022:fc0b:b0:11b:9b9f:4283 with SMTP id a92af1059eb24-12336a6d9c6mr2588056c88.24.1768411461381; Wed, 14 Jan 2026 09:24:21 -0800 (PST) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121f24985d1sm31170055c88.16.2026.01.14.09.24.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 09:24:21 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 09:24:19 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params To: Vasanthakumar Thiagarajan , Alexandru Gagniuc , jjohnson@kernel.org, ath11k@lists.infradead.org Cc: baochen.qiang@oss.qualcomm.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251228151408.2116108-1-mr.nuke.me@gmail.com> <56c6471b-c878-4afd-8e8e-d56266ca9c64@oss.qualcomm.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <56c6471b-c878-4afd-8e8e-d56266ca9c64@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 6y-YD2taEc5l2Ng45yKeBh6L_x7FSbov X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDE0NiBTYWx0ZWRfXwyIrQv3Y85YM zJjeoeUGQmr2VFnfi7t2npJnRMAmJpn3s6oVIGzjrexj3KOEVuMvmVmb4buHjr5OQjH1Uc6V/LR 7u3T9GQYtoKw4OzcRNc9V0rFJEmhpgm7MzIaQ6t0ZZ37Gmay9pt5MHMO4MGjM2GRZbXKSoX1b/+ jEpTZaCHQLBuHP81TjE4K8hN9VFTmYAzrg7SBkE9rmXVAXJCNZApTKy5AuISs0/BLKeCK/Vzxha sMe3dykPPufhvGQXRqBLJgyQrGVRMbbacER32CUGoVaGXI1sOGYo21vGlZjXAvA/NVYLz3o3y47 Mx0n1Xse7Yl6A/9kSBKmYwIDdqgNlXEpI6XvCClnRSJ07ACwgxsKf7HAz51CCCW7pbzXNTLsTi6 H+HsxhY2Gy8OKuhLlbydTiu3znbv6roH2Xtj6ihGzps2F/Er8SF6nACUNlH5fQmunSE2Pnz2KB+ hTkWt6VxvS75AeIo5SA== X-Authority-Analysis: v=2.4 cv=HY4ZjyE8 c=1 sm=1 tr=0 ts=6967d146 cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=4N76r0Ozp7Clb_Fv4mYA:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 X-Proofpoint-ORIG-GUID: 6y-YD2taEc5l2Ng45yKeBh6L_x7FSbov X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_05,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140146 On 1/12/2026 11:00 PM, Vasanthakumar Thiagarajan wrote: > > > On 12/28/2025 8:44 PM, Alexandru Gagniuc wrote: >> ".max_tx_ring" is an upper bounds to indexing ".tcl2wbm_rbm_map". It >> is initialized in, core.c, a different file than the array. This >> spaghetti-like relation is fragile and not obvious. Accidentally >> setting ".max_tx_ring" too high leads to a hard to track out-of- >> bounds access and memory corruption. >> >> There is a small ambiguity on the meaning of "max_tx_ring": >> - The highest ring, max=3 implies there are 4 rings (0, 1, 2, 3) >> - The highest number to use for array indexing (there are 3 rings) >> >> Clarify this dependency by moving ".max_tx_ring" adjacent to the array >> ".tcl2wbm_rbm_map", and name it "num_tx_rings". Use ARRAY_SIZE() >> instead of #defines to initialize the length field. >> >> The ath11k_hw_hal_params_qca6390 uses fewer num_tx_rings than its map, >> so use a constant to express the correct value. Add a static_assert() >> to fail compilation if the constant is accidentally set too high. > > Text related to static_assert to be removed accordingly. I removed the last sentence in 'pending', please check: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=26bb149b5e011b0f73f7b74421589cbd38e3304b > >> >> The intent is to make the code easier to understand rather than fix >> an existing bug. >> >> Signed-off-by: Alexandru Gagniuc > > With the above minor comment addressed. > > Reviewed-by: Vasanthakumar Thiagarajan