mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chanwoo Choi <chanwoo@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
	cw00.choi@samsung.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / devfreq: Reword the kernel-doc comment for devfreq_monitor_start() API
Date: Mon, 24 Jul 2023 05:26:00 +0900	[thread overview]
Message-ID: <c84a78c6-1582-a9fa-e0fd-43c0faac5a75@kernel.org> (raw)
In-Reply-To: <20230720084854.18975-1-manivannan.sadhasivam@linaro.org>

On 23. 7. 20. 17:48, Manivannan Sadhasivam wrote:
> Current kernel-doc comment doesn't specify the default timer used for the
> load monitoring. Also, it uses the term "default delayed work" which could
> be misunderstood as "default delayer timer". So reword the comment to
> clearly specify the default timer and also reword the last sentence to make
> it more understandable.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
>  drivers/devfreq/devfreq.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 7686993d639f..e2939c1b7d1f 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -472,10 +472,11 @@ static void devfreq_monitor(struct work_struct *work)
>   * devfreq_monitor_start() - Start load monitoring of devfreq instance
>   * @devfreq:	the devfreq instance.
>   *
> - * Helper function for starting devfreq device load monitoring. By
> - * default delayed work based monitoring is supported. Function
> - * to be called from governor in response to DEVFREQ_GOV_START
> - * event when device is added to devfreq framework.
> + * Helper function for starting devfreq device load monitoring. By default,
> + * deferrable timer is used for load monitoring. But the users can change this
> + * behavior using the "timer" type in devfreq_dev_profile. This function will be
> + * called by devfreq governor in response to the DEVFREQ_GOV_START event
> + * generated while adding a device to the devfreq framework.
>   */
>  void devfreq_monitor_start(struct devfreq *devfreq)
>  {

Applied it. Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi


      reply	other threads:[~2023-07-23 20:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20  8:48 Manivannan Sadhasivam
2023-07-23 20:26 ` Chanwoo Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c84a78c6-1582-a9fa-e0fd-43c0faac5a75@kernel.org \
    --to=chanwoo@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®