mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Patrick Rudolph <patrick.rudolph@9elements.com>,
	Konstantin Aladyshev <aladyshev22@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Naresh Solanki <Naresh.Solanki@9elements.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device
Date: Sat, 27 Jan 2024 07:24:05 -0800	[thread overview]
Message-ID: <c853502f-230b-47b3-9c93-28d99f4d83b8@roeck-us.net> (raw)
In-Reply-To: <CALNFmy2KVbiwvuEz=qjcB1vL82OOPSsZMuYWze56siCHLQ8JgQ@mail.gmail.com>

On 1/27/24 00:56, Patrick Rudolph wrote:
> Hi Konstantin,
> Thank you for fixing this regression.
> 
> The comment is no longer true as the driver doesn't internally convert
> from VID to direct,
> but rather configures READ_VOUT using MFR_DC_LOOP_CTRL.
> 
> The comment thus should read as the following:
> 
> Report direct format as configured by MFR_DC_LOOP_CTRL.
> Unlike on MP2971/MP2973 the reported VOUT_MODE isn't automatically
> internally updated,
> but always reads as PB_VOUT_MODE_VID.
> 
> Regards,
> Patrick

Please don't top-post.

This patch has already been applied. Please send a follow-up to that patch
to update it.

Thanks,
Guenter


      reply	other threads:[~2024-01-27 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 20:57 Konstantin Aladyshev
2024-01-26 21:07 ` Guenter Roeck
2024-01-27  8:56 ` Patrick Rudolph
2024-01-27 15:24   ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c853502f-230b-47b3-9c93-28d99f4d83b8@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Naresh.Solanki@9elements.com \
    --cc=aladyshev22@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick.rudolph@9elements.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®