From: John Veness <john-linux@pelago.org.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/conexant: Add quirk for HP ProBook 450 G4 mute LED
Date: Mon, 17 Feb 2025 12:28:15 +0000 [thread overview]
Message-ID: <c8556845-7d12-46aa-ab28-138da8903583@pelago.org.uk> (raw)
In-Reply-To: <877c5o92sg.wl-tiwai@suse.de>
On 17/02/2025 12:25, Takashi Iwai wrote:
> On Mon, 17 Feb 2025 13:15:50 +0100,
> John Veness wrote:
>>
>> Allows the LED on the dedicated mute button on the HP ProBook 450 G4
>> laptop to change colour correctly.
>>
>> Signed-off-by: John Veness <john-linux@pelago.org.uk>
>> ---
>> Re-submitted with correct tabs (I hope!)
>
> Now the patch is cleanly applicable, so I took now.
> But, the Cc-to-stable should have been put in the patch itself (around
> your Signed-off-by line). I put it locally.
Whoops, I just submitted a v3 to fix the stable CC, after "kernel test
robot" alerted me. I hope that doesn't mess things up.
John
> thanks,
>
> Takashi
>
>>
>> sound/pci/hda/patch_conexant.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
>> index 4985e72b9..34874039a 100644
>> --- a/sound/pci/hda/patch_conexant.c
>> +++ b/sound/pci/hda/patch_conexant.c
>> @@ -1090,6 +1090,7 @@ static const struct hda_quirk cxt5066_fixups[] = {
>> SND_PCI_QUIRK(0x103c, 0x814f, "HP ZBook 15u G3", CXT_FIXUP_MUTE_LED_GPIO),
>> SND_PCI_QUIRK(0x103c, 0x8174, "HP Spectre x360", CXT_FIXUP_HP_SPECTRE),
>> SND_PCI_QUIRK(0x103c, 0x822e, "HP ProBook 440 G4", CXT_FIXUP_MUTE_LED_GPIO),
>> + SND_PCI_QUIRK(0x103c, 0x8231, "HP ProBook 450 G4", CXT_FIXUP_MUTE_LED_GPIO),
>> SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_HP_DOCK),
>> SND_PCI_QUIRK(0x103c, 0x8299, "HP 800 G3 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x103c, 0x829a, "HP 800 G3 DM", CXT_FIXUP_HP_MIC_NO_PRESENCE),
>> --
>> 2.48.1
prev parent reply other threads:[~2025-02-17 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 12:15 John Veness
2025-02-17 12:25 ` Takashi Iwai
2025-02-17 12:28 ` John Veness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8556845-7d12-46aa-ab28-138da8903583@pelago.org.uk \
--to=john-linux@pelago.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®