Re: [PATCH] kconfig: wrap long expressions in menuconfig

[Julian Braha <julianbraha@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2542 bytes --]

On 11/5/26 04:17, Nathan Chancellor wrote:
>> In an offline conversation, Miguel Ojeda reported that scrolling
>> horizontally in menuconfig's search to read RUST's dependencies has been
>> slowing down debugging.
>>
>> Let's wrap expressions (like in the 'Depends on', 'Selected by', or
>> 'Range' sections) between tokens at the end of the window, such that each
>> line begins with the same indentation. Ensure the '!' negation stays
>> attached to the left side of the option symbol, and keep the value
>> annotation attached to the right side when wrapping.
>>
>> Note that the 'help' textbox uses the same expression printer as search,
>> so this has the side effect of improving the formatting in 'help', too.
>>
>> In the future, we should consider a larger revamp that would wrap all text
>> in the search window, allowing us to safely disable horizontal scrolling.
>>
>> Assisted-by: LLM
>> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> I spend some time searching for random symbols to see if all long
> depends or selects lines looked seriously broken and I did not find
> anything.
> 
> Tested-by: Nathan Chancellor <nathan@kernel.org>
> 
> Like you said down thread, this seems much better than what we currently
> have, which is nothing. The Sashiko comments [1] seem rather contrived
> (if valid at all, I did not check closely) but it seems reasonable not
> to get things wrong off rip so with those fixed (if necessary), we can
> probably get this into -next to see if there is anyting we immediately
> need to tweak.

Thanks for taking a look!

I can confirm that the findings are true positives, but it's a mixed
amount of contrived-ness:
(1) there actually are some Kconfig string constants in use with
trailing '!' characters. Rare usage, but not overly contrived.
(2) the leading space problem is much less realistic: technically yes,
Kconfig allows strings to have leading spaces. But no constants in-tree
are using that and I can't imagine potential use cases.

I've thought about tightening input validation to disallow leading
spaces in strings, but I suppose it's _possible_ the host has a poorly
formatted env var, and preprocessing Kconfig macros should probably not
be the place where that gets caught...

Okay, so resolving sashiko's alarms belongs here.

It's taking me longer than expected (why is expression printing this
complicated?) so let's see if I can finish v2 this weekend; I agree on
giving this its fair time in -next.

- Julian Braha

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]