From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933583AbdGSPlO (ORCPT ); Wed, 19 Jul 2017 11:41:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34054 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932439AbdGSPlM (ORCPT ); Wed, 19 Jul 2017 11:41:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 59A363DBE5 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=longman@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 59A363DBE5 Subject: Re: [PATCH 6/6] cgroup: update debug controller to print out thread mode information To: Tejun Heo Cc: lizefan@huawei.com, hannes@cmpxchg.org, peterz@infradead.org, mingo@redhat.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de, torvalds@linux-foundation.org, guro@fb.com References: <20170717020721.3612468-1-tj@kernel.org> <20170717020721.3612468-7-tj@kernel.org> <20170719153105.GM3365493@devbig577.frc2.facebook.com> From: Waiman Long Organization: Red Hat Message-ID: Date: Wed, 19 Jul 2017 11:41:09 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170719153105.GM3365493@devbig577.frc2.facebook.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 19 Jul 2017 15:41:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2017 11:31 AM, Tejun Heo wrote: > Hello, > > On Mon, Jul 17, 2017 at 05:19:16PM -0400, Waiman Long wrote: >>> + if (cgroup_is_thread_root(css->cgroup)) >>> + seq_puts(seq, "[thread root]\n"); >>> + else if (cgroup_is_threaded(css->cgroup)) >>> + seq_puts(seq, "[threaded]\n"); >> The cgroup status will not be needed anymore as you have introduced the >> cgroup.type control file that returns the proper information. > Ah, right, will drop this file. > > Thanks. > Oh, I am not saying that we should drop the whole patch. I just want to drop the above 4 line of codes as they are not needed. Thanks, Longman