mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Hans de Goede" <hansg@kernel.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	ibm-acpi-devel@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Add sysfs to display HWDD raw
Date: Tue, 28 Apr 2026 09:15:29 -0400	[thread overview]
Message-ID: <c858deda-4a9b-4617-baab-d4171f927337@app.fastmail.com> (raw)
In-Reply-To: <75ad46f0-2c1f-9831-eff6-92df477f7db8@linux.intel.com>

On Tue, Apr 28, 2026, at 9:00 AM, Ilpo Järvinen wrote:
> On Tue, 28 Apr 2026, Mark Pearson wrote:
>
>> The Lenovo diagnostics and support team have requested a mechanism
>> to get the raw data from the HWDD commands to support customer debug
>> situations.
>> 
>> Add a sysfs entry to display the raw data.
>> 
>> As it shouldn't be needed in normal operation, add a hwdd_raw_enable
>> module parameter for when it is needed
>
> Wouldn't debugfs be more appropriate for things like this? By using it, 
> you can avoid adding the module parameter as well.
>
Yeah - you're right. I was thinking of what we did on think-lmi and didn't think of that.
I'll revisit this.

Thanks for the quick review :)
Mark

      reply	other threads:[~2026-04-28 13:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 12:53 Mark Pearson
2026-04-28 13:00 ` Ilpo Järvinen
2026-04-28 13:15   ` Mark Pearson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c858deda-4a9b-4617-baab-d4171f927337@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=hansg@kernel.org \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®