From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 723DF3E5A35 for ; Mon, 15 Jun 2026 12:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525236; cv=none; b=K6cwFUY1dAPrv1n8vl3U9aPjIJzxSXMqsDwYmUpKFhIBt7u4HjgK7nrOeTbmH2CrRiWu9FnVZJJDfPOnCPZGeJkrNY3OTUfksN/7IXJ1Pqq3q0wtVPdo7OHGaov73BqVJqyGsm5g+i3jwVqODMZlJ4FH71mSsPBJUz16Yyxzpps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525236; c=relaxed/simple; bh=ND7KG3N9MBrMZvVY0w5QREg+dNE6BwwRSSbIcSH9sa8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g6Vu8d8ZVBAj1aOwTVCihGwtUGIzcC9UztOyk0F3qtI1zKDEwL6n9IuxvcM9RoXaz5is0R/vtWGGO3f7UdPmlAyFxXuIQMYwAknUQCy1AkLhV+1O3ousW1hP9p8H8BQZyj93BU6MviZqC3PzxAYNOlv3IyQPgY3K1aLaU0Nl24I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d5wJdni5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WfFXYdG4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d5wJdni5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WfFXYdG4" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FApAWi359060 for ; Mon, 15 Jun 2026 12:07:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UuSAM3kSZuXdViGtqqiEJCksQHrxoR+infoumgosJxs=; b=d5wJdni5rz04nj0p B/sk5reO7L8PiLn/ZirW26K0iPUoli7oXhuOlzTC3TTBuXOG2YN0ppqfWoIfLLOQ ZddzEyqB6/OctbFM7QgjpROJvtCNt2CxcrDhnPsvpvk3vKJM+4aW+CSMAwAWX/yR tMILsycwUzCiSJPC5r530r3B6lK2CKbMjbEOICIafpZtCRzPV+2CdQzAG2SLKpcp 9X6mH3jd0rgTc9ffmpgwKPb60fWtxEokNYKDlKyYOeDTJLitCwiOCgLBQBYSs3JK R09gZo8/QIQytN1Tmb/94io/OTY4klv0bM4m8+8qWX9LK+FLzVw7ThGRtPkz58t/ ZjZ7AA== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etd2c91yj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 12:07:14 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-6cc5ae9b959so3390781137.3 for ; Mon, 15 Jun 2026 05:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781525234; x=1782130034; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UuSAM3kSZuXdViGtqqiEJCksQHrxoR+infoumgosJxs=; b=WfFXYdG4XQAAtWDTr+wtA171I3wOL/NftrDFiCjFJM52OihGKWWMru60iJ3gssLCmZ Zl6RH8SptRbB0ZPjq9Ar/YvnDOlA5vyRwn81PJA23Mrszd9w8Cu91t2yYm8Csz8iECQ5 jxX4X+BNX0P3h3jIBx7aM1RtA8/8fi+i21Zw7KminPDxVHFf1NclUc1G9nCv+dPNUZxV tbmsvfIzQ0NQ/iGe4+TKJveTPd2vKGXO4bMnya65Y2x03ssti4ntwtuP9ZEYVgbme6b6 vKYKCxQ9vInC0aqTrSjjcw8wag5vTCs8UU9ZV0tg5aoVzkDBmoub5z7J5arppUS4gCdF nfTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781525234; x=1782130034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UuSAM3kSZuXdViGtqqiEJCksQHrxoR+infoumgosJxs=; b=XcZee+llusey6+SvLWtz41uGGXSu2GQk1lDNVg+usMIfKktM1C34RIIEpw61gCrHUZ Tjfx8cTs0CLFqZm7ekFS+3kTb1j7mys0QGBCbdx1+DosEQ9km+NPnsW78oIdK8RPHyv4 HExftEh/fkoDwV6FelEiJCbzmosAkRvjhLL8ZAGLCgH7Wy4yMYmhUUK3vvfWAE4tbMEa lDZ2d/tB/QqXg949pXC0FJxlZL8emXL8C6qaXEX4BxdxKTQ3oknVuGdk4CJOGtfBj3Pt nyR7jRbQzDi9+Mw4YeSku3M6N57UuXxvqHB9/LqDki48XACCn5vlke2Dg7y/TKAIgeBh uscg== X-Forwarded-Encrypted: i=1; AFNElJ9uO4YKwQla2kR2Vk8CrdIl/aifVwG/LuvvIJL8KeZm/gETJjWBr4RSXXT6HKbTEtCALMBF79ezGUvYEWA=@vger.kernel.org X-Gm-Message-State: AOJu0YwrvQd6o9/YI1QZDrbCHIi8Id/PSamVvkDG8CMVfRNlODSaJ4F9 bFTsghMeQsfLEUjnMaAdvA0cUhLDwgGxW9qlabsthUYJzGTqXiywIJ+AdLCWrRSrHCfO3nofSkA XaOvN3TCSKLQP1ztN1AF9ynlLk+5CT9b1zCvQsyMOlNw0uxt1uBo6989ILFPwT6V8i94= X-Gm-Gg: Acq92OFBtJukfD6VBx2hzh/6rAQCMOTTP8bTEaTGZ6C07lALiIrJiyaiwL3OzIhJeUr TGkw4/Ut94aquudNZFMqnQoIuD9QMONMBR6TY5KDS3/qFchr4luCs9mKGwtbDYRhBxcZZ8y424R pv8iv2kcn5I17rpQ/nIAuD11gXPkdJ5bMM3QeNMEP7DxIIkTKGMWTVBqRoOJN7NDPOvx3MkPH1Q n+SQFTBz7YrBzNtW7tbLfmBRal6lrh5G8poYrDuJ6ZJA0FhOjklRZZvHmC6NN3ZZ4+HxHt4QuMv J6k1v5noHEYiZid0MecNX1vYw45S2h/6VH3BRwKcM/2ANM8W5KqnYgXoZSG5ciAKBZ404fhib4o imTIRkT9liI+kojf4/iVNeCZKzmE539W7+dUVEAxrUckGGrE3CfNHAmkW9tIBThJinWRfR1ORwR zdqFrOc3UVYKkiXw== X-Received: by 2002:a05:6102:570c:b0:62f:3abe:907f with SMTP id ada2fe7eead31-71f5e0fa666mr4734439137.4.1781525232295; Mon, 15 Jun 2026 05:07:12 -0700 (PDT) X-Received: by 2002:a05:6102:570c:b0:62f:3abe:907f with SMTP id ada2fe7eead31-71f5e0fa666mr4734386137.4.1781525231745; Mon, 15 Jun 2026 05:07:11 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:b0eb:75fa:2a81:cf30? ([2a05:6e02:1041:c10:b0eb:75fa:2a81:cf30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26f23fsm33848212f8f.9.2026.06.15.05.07.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 05:07:10 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 14:07:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] powercap: qcom: Add SPEL powercap driver To: Konrad Dybcio , Manaf Meethalavalappu Pallikunhi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Gaurav Kohli References: <20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com> <20260519-qcom_spel_driver_upstream-v1-2-75356d1b7f94@oss.qualcomm.com> <7ea2f2cc-ef11-4727-810c-e32e815bd973@oss.qualcomm.com> <8f045340-a6c8-41c7-b1c7-6d9b87b05d90@oss.qualcomm.com> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEyNyBTYWx0ZWRfXx2YHuTqcr5lG UZZZErj+c5Q02P2Nv4UA+lOywhyx/EnXmZYiuri/nVUuMIq/apZFkFhwVBBN6qenqJhrEzEgwlr ItuVKzm/kOVEaer1LAdq5Pq/kSKEt5ExwUO0CbAfm7cNndjx++w74pF8KKVpoTWKOB3OqZSEI3H XLsgttHfon44gibGSQ2sKm6Nbz74vJcwztRvbenGmFmmj2r+/6Q6O60GQTzm6GEXF1r1M98in6f LLt5TpxrbPHzrvgv6JRorfcgWZLqF7S907UKBpcTeA/if+GhyuE/fCreO1WnFYDVTmdxgudGP7R RUJkI2YcWqh+meu8KMgCf4SQleL0cuybnXAm1bADYKZRCQaE0CdssIP1ecBgf8qraPNljy4cCBX DOuXM/VSmCn61NepMQ1ujkePcHMGh6B5HfxXkyT+OKdev4LWiPTa335+PpPelBS/lTs7EECasOO 6HMpPfD6Wh4WAXlLDnQ== X-Proofpoint-ORIG-GUID: 0TO0g6KD0trI9_l7I0QtYXNmq96VWWXR X-Proofpoint-GUID: 0TO0g6KD0trI9_l7I0QtYXNmq96VWWXR X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEyNyBTYWx0ZWRfX1JWOX+t9C+Am rl+krB3l0ic6Y6yfRCGgrIhrBX6EzmpZJvSdgoOZbD3VkZ94cRPLxCnApnc00eHPqeM3T8+jzg7 qyKD0aQLQqZG48iYNV0RleUEM2VejnM= X-Authority-Analysis: v=2.4 cv=MsRiLWae c=1 sm=1 tr=0 ts=6a2feaf2 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=qtblmzGj4WCF7b9vubUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150127 Hi Konrad, Le 09/06/2026 à 15:31, Konrad Dybcio a écrit : > On 6/9/26 3:23 PM, Manaf Meethalavalappu Pallikunhi wrote: >> Hi Konrad, >> >> >> On 5/21/2026 4:46 PM, Konrad Dybcio wrote: >>> On 5/19/26 12:49 PM, Manaf Meethalavalappu Pallikunhi wrote: >>>> The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware >>>> based power monitoring and limiting capabilities for various power >>>> domains including System, SoC, CPU clusters, GPU, and various other >>>> subsystems. >>>> >>>> The driver integrates with the Linux powercap framework, exposing SPEL >>>> capabilities through powercap sysfs interfaces. >>>> >>>> Signed-off-by: Manaf Meethalavalappu Pallikunhi >>>> --- > > [...] > >>>> +static void spel_remove(struct platform_device *pdev) >>>> +{ >>>> +    struct spel_system *sp = platform_get_drvdata(pdev); >>>> +    int i; >>>> + >>>> +    if (!sp) >>>> +        return; >>>> + >>>> +    /* Unregister in reverse order: children first, then SOC, then SYS */ >>>> +    for (i = SPEL_DOMAIN_MAX - 1; i >= 0; i--) >>>> +        powercap_unregister_zone(sp->control_type, &sp->domains[i].power_zone); >>> >>> Could you try adding a devm_ variant of these register functions? >> >> Powercap framework doesn't support any devm_* API, you meant add this support in framework in this series ? > > Yes, this should be fairly trivial - look at e.g. > > drivers/regulator/devres.c : devm_of_regulator_get Given how structured is the powercap framework, I'm not sure it is so trivial. May be it is, but I doubt. I don't think it is worth to investigate adding devm_ variant now (for a few lines saved) and diverge from the objective of this series -- Daniel