mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Randy Dunlap <rdunlap@infradead.org>,
	linux-scsi@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: scsi/stex time_after() build warnings
Date: Sun, 28 May 2023 13:30:01 -0700	[thread overview]
Message-ID: <c86f90b4-458a-3066-4a8e-6e510a41a37d@acm.org> (raw)
In-Reply-To: <89df78d0-fb52-9045-2074-1d6f0afae4d9@infradead.org>

On 5/27/23 16:08, Randy Dunlap wrote:
> When I build stex.o for i386, I see these build warnings:

Are you perhaps using gcc 13?

Has the following alternative patch been considered? I think this patch 
is lower risk than the patch in the original email:

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 5b230e149c3d..8ffb75be99bc 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -109,7 +109,9 @@ enum {
  	TASK_ATTRIBUTE_HEADOFQUEUE		= 0x1,
  	TASK_ATTRIBUTE_ORDERED			= 0x2,
  	TASK_ATTRIBUTE_ACA			= 0x4,
+};

+enum {
  	SS_STS_NORMAL				= 0x80000000,
  	SS_STS_DONE				= 0x40000000,
  	SS_STS_HANDSHAKE			= 0x20000000,
@@ -121,7 +123,9 @@ enum {
  	SS_I2H_REQUEST_RESET			= 0x2000,

  	SS_MU_OPERATIONAL			= 0x80000000,
+};

+enum {
  	STEX_CDB_LENGTH				= 16,
  	STATUS_VAR_LEN				= 128,


Thanks,

Bart.

  reply	other threads:[~2023-05-28 20:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-27 23:08 Randy Dunlap
2023-05-28 20:30 ` Bart Van Assche [this message]
2023-05-28 22:24   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c86f90b4-458a-3066-4a8e-6e510a41a37d@acm.org \
    --to=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®