From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22D939D6CB for ; Wed, 25 Mar 2026 11:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774439838; cv=none; b=m+iXKVTrjkipIrE8kOt7c43JmODnB+/9d+d610pRfinAmtpfTUw5XOhHWcahKDJ+ltXR0aGNO5vHarWvBsXgTbI/FdIRrudDoFlJzY5PyuLHoDH2OdocQOeJMYmq7jp8jYtYYWW9/+dcgqsbfMv8tl2tyULrJGvyFQpDXLOHSf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774439838; c=relaxed/simple; bh=rGUXkPwSkQ89I158wBw/9XHF84KlHiIQkhQ/gUtbYRM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EBITSDHgA+uX/aQA7Ti1JRaDkNEGZGa+llzjav/ibeDXtE+ulFPfFO3jHXB0p7NUzkdyB8lQTKE+CqhpWHYww5BF2/9XauQ1MUJO8xKqlCP8MUHK4eITpaKyr13V3n1/1Ku9PPtAVzSCBnrk4/hv2MfKdupc7TuGlcR9RDjDsC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R6Q9LAS6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZT5mDwJ/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R6Q9LAS6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZT5mDwJ/" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PBGZY6876106 for ; Wed, 25 Mar 2026 11:57:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Gr18nfu9JJ8gSoYFoxnvVAHkTdc2dAzT6iMHWG8h1ww=; b=R6Q9LAS6EO7rrk50 nW1Leqjq84qwf6cfDWMfEvVB4SOmxhkM0NpHrN+1l91gUTrNS125PoWtaEJPWojr /TAiUYD7Xved23H2r2ytnowG440qLoHxLB1wHcv/GWSYZM94ubTb9rrnRFOCW8+c Kapivy3iI1oh3iJwDRmn+XANH/v5K2NGH1+gIe4xtBHnibrd1OGnZ1STNHrKFXjR fJXuuRg0x/oJpzeJBpMv+YuvT5TQq2PdTNs1Zns0mET44fu3iklMPdOmx0xqVN64 1/Gq0g8l/xwGOJgWVLEYyEyXC7dnKHtugChDRiAyCuXg5PyDrmhmqg41mJBkvrLO rMMwoA== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d40f4k21m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 11:57:15 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2c1596fabb6so4826662eec.0 for ; Wed, 25 Mar 2026 04:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774439835; x=1775044635; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Gr18nfu9JJ8gSoYFoxnvVAHkTdc2dAzT6iMHWG8h1ww=; b=ZT5mDwJ/6xYMqh0tISmI1Cun9cwBEO1A+I0nZVJoYPNfh70WaeJiK1i9wqcQVgQY2i 0jvvDNXRvo95KSIPDrZ+MQ05tzwns1rnOrjozX6wXo6oJbwNg4rW/265DEnVu4Q6au5j wCCZvwXzt4wI/n5XSTbvZtgOCVaEvq+Gpe3cu5r+FrBzMEoEntXMo59OaCSzgYhuzhLP 39t1NS9SCTR53g1kQ55HNqsBslcinhwjsxx9gzpFYC5NfESd/YbbafASHtt3G+K9/ZVl AiBHKOMTt3KXLoavQzaWdHMB83uGUggBJspthB8vSjS3tkAGJLf9LT4kiowPL5c2imAO NlZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774439835; x=1775044635; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Gr18nfu9JJ8gSoYFoxnvVAHkTdc2dAzT6iMHWG8h1ww=; b=jMYWaVFSyzlJqRuFmJhkQXfqRDksy/1DzYj57jpoojcxXBeJRS3u381I8ug2aLC5lw xTL/C9/Ox34++SXY5KQ/MaYs7V0iK7WG4W/Z1tx53jOG0lD1ZBbFX59uGMmQtETZ2Ivm F/CKw901DCIrFuKynInZ02PoFifmR708VVAmhWGAmjICLgurmKA1jD92OH24yEA3uI5O lsUOCLiEvtoFnJmTH31pTF62RkfofnfxuX5Hcf2T4EgE26mL/hMQhM2S1VgziQQgDWsv SyYeGNa+VUjm1BIqA0EHRXDiy3IEv1ysi/E2wCz0a3mDzA/x1VO58D09feM4J7g580VI O9Qg== X-Forwarded-Encrypted: i=1; AJvYcCXFcYl41IiLhBYkkZ67uiSqyEgAxuz9kD/BGjZmvL1lyxujM4iJv1sGRpjHlNrFooZ0W/6AAEvJC4vCc4s=@vger.kernel.org X-Gm-Message-State: AOJu0YwLw7F9jdXjK8/JQrZoeebFp2eLeEC3xBt9Prid9MIscaFVb854 zM1M/7X67NIOyzUrMYvDxo6iLpZoFF/R4Ych7BYw3Re62ZEpH+oqpqzk/tkb1sNn3hXwhQxdMk6 0D/K6dmAo6Z3ln9Lz3f6PsTsj8Df7QZxuPb25FWAUSJD7BpWTb1bwWN2Wezhd7qIT4pI= X-Gm-Gg: ATEYQzx+lgxfyEtaVZBI0DdIcRUjRssSp2uNbGKgmCYyhHv5FPKRLiczJOn6AmFpMLu PSnWRc3xe4fyEqITmdRYm5uyhu9jTTZ888S2GPfuKV/hshxyU3kRgIMt1rdQTH2D7OcWQ58+hIp 6xBvn9Nl3jBNkeOdmA999u5LFi6b4oqtKdpzamfTAKnfIkUxP1Igz2KOpkCw4/6QC1jMhjLH1I1 I0TfL0Trow291LuVysKomjYbWbZxnltmQFk2D0O3mRqedDaslnLbM5hZi7/owM9sU2D+Ei2xvvw hNYv920SnwuTVk8O6xBNraCzwCTFUCwugAyzI11Dx8Gyc3H/5Ajnlw2CFGNqzrbksYNVfDjOf+7 BLTeHKCRIhgEoaFcoDQ5pdCD0uqRJE/IqXFIo2qcQgjA8FqVD1Ihy1YcOxGy5qAibOhv+ISulRD 5xNlA= X-Received: by 2002:a05:7300:7ba0:b0:2be:e4b:60a8 with SMTP id 5a478bee46e88-2c15d31dbfamr1990509eec.7.1774439834846; Wed, 25 Mar 2026 04:57:14 -0700 (PDT) X-Received: by 2002:a05:7300:7ba0:b0:2be:e4b:60a8 with SMTP id 5a478bee46e88-2c15d31dbfamr1990491eec.7.1774439834282; Wed, 25 Mar 2026 04:57:14 -0700 (PDT) Received: from [10.110.19.183] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b14c99bsm18187680eec.1.2026.03.25.04.57.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 04:57:13 -0700 (PDT) Message-ID: Date: Wed, 25 Mar 2026 19:57:09 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] dm-inlinecrypt: add target for inline block device encryption To: Milan Broz , Mikulas Patocka , Eric Biggers Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, adrianvovk@gmail.com, dm-devel@lists.linux.dev, quic_mdalam@quicinc.com, israelr@nvidia.com References: <20260304121729.1532469-1-linlin.zhang@oss.qualcomm.com> <20260304121729.1532469-3-linlin.zhang@oss.qualcomm.com> <20260312070110.GD2359@sol> <5a310122-bd7e-d10e-653e-bc7e09681478@redhat.com> <7f613001-fc2b-44e3-ac14-7e661cf52fdd@gmail.com> Content-Language: en-US From: Linlin Zhang In-Reply-To: <7f613001-fc2b-44e3-ac14-7e661cf52fdd@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDA4NSBTYWx0ZWRfX57e5cpcw/vWE jPJLWj4cGN1K+MYHqchJF1TQBvCzstlH5ukTd06ht9spuFTvHQ8dkaNSsbrFTtVSNA9IRD2V7jK dMzfKvmUHz4xN86vagKFGJ3L/0xr5YVeqWsk3+VX2GgXpLDLWn+rVgtmt0AdYJwb72NA/FdMBdg zxR3iTHFa2wasmfBqpd4O5osiZmZ9r5mPp66qoA4jT+mPaH/XuEFort4tpAC0SQ31gNPM4UsyAx y0QfdmAhfdPq5hOfonkNaLRD0xW0PyiD3Bja6n7bUrmOSoQSylMKN4LepxIl84x3CskTBII8Vwq JUFN28CeisP5TsRyY9fqLLts8rRRCEpmcjdWl14P4bAfIuBYBQS3JH7sDNKFfmR7am3Qh0yCbS/ G46iWyrWWiYD7kM1Ig8sL6PmSXZvkMsx7rCJ8CBg40M4ndrynwT2LxB+TT6myNtbwMSzhEMm8J4 fy4Ai5Nb2JGG/dYVyzA== X-Proofpoint-ORIG-GUID: 4NdBAXSJvX1ZGK8AYbN3ObjJotTFYO52 X-Authority-Analysis: v=2.4 cv=Cd8FJbrl c=1 sm=1 tr=0 ts=69c3cd9b cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=1XWaLZrsAAAA:8 a=Q6PVb_SgueIFlp-ES8wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-GUID: 4NdBAXSJvX1ZGK8AYbN3ObjJotTFYO52 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_04,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250085 On 3/13/2026 11:27 PM, Milan Broz wrote: > On 3/13/26 2:25 PM, Mikulas Patocka wrote: >> On Thu, 12 Mar 2026, Eric Biggers wrote: >> >>> On Wed, Mar 04, 2026 at 04:17:27AM -0800, Linlin Zhang wrote: >>>> From: Eric Biggers >>>> >>>> Add a new device-mapper target "dm-inlinecrypt" that is similar to >>>> dm-crypt but uses the blk-crypto API instead of the regular crypto API. >>>> This allows it to take advantage of inline encryption hardware such as >>>> that commonly built into UFS host controllers. > > ... > >>> I don't think it's plausible that this new patch was actually tested. >>> The version I sent in 2024 was tested at the time >>> (https://lore.kernel.org/r/20241016232748.134211-3-ebiggers@kernel.org/), >>> but I see at least two things that would make this new patch not work. > > What a waste of time... thanks. >> OK. I dropped it. > > Well, the inline crypt has some advantages to proprietary internal > hw implementations (like self-encrypting drives)  - it can be actually validated > comparing to sw version. > > Anyway, Mikulas, if this dm-inlinecrypt returns one day, please be > sure that we do not have security-related "regressions" like not supporting > keyring. There is no need for dm-inlinecrypt to keep key inside the mapping table. > The keyring code is in dm-crypt, it should be easy to adapt it here. > > Thanks, > Milan > Thanks for your review. I understood that supporting keyring here is to ensure no raw key exposed to dm table. As implied by the name dm-inlinecrypt, the key used by dm-inlinecyrpt is a wrapped key, rather raw key. Can we keep the wrapped key inside the mapping table? In other word, can dm-inlinecrypt support both keyring and hex key(key in mapping table)? Thanks, Linlin