From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752143AbdLFNZR (ORCPT <rfc822;w@1wt.eu>);
        Wed, 6 Dec 2017 08:25:17 -0500
Received: from mout.web.de ([212.227.15.14]:57312 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751443AbdLFNZP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Dec 2017 08:25:15 -0500
Subject: Re: [PATCH] USB: emi26: Delete an error message for a failed memory
 allocation in emi26_writememory()
To: Julia Lawall <julia.lawall@lip6.fr>, linux-usb@vger.kernel.org
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
References: <244f8baf-0cd7-89f5-b210-7c321e180f11@users.sourceforge.net>
 <alpine.DEB.2.20.1712061312090.9552@hadrien>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <c873917f-0264-f4c5-3753-dc6a588cfb51@users.sourceforge.net>
Date: Wed, 6 Dec 2017 14:25:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1712061312090.9552@hadrien>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:CGnklfyfrodpJjqwfRAbjA6cTBMBK1l4zZ1srfgum4NwiPpg6Bs
 TTI8nFgi2Wng5Zl+cQZMbQfwRGbSsw7YyZcRkSD6E9/u9UPIcAhZIy48iBSmDdpBv0YWlFG
 mPTBFpFSAY5zj0yFO5/0cuS0+yqSHABGB08gtEix96X3oXuXlhki//yF4w+LNSvIhmwYFP6
 t8oGiRnl7c4Rh5kqPnQXA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:s0A2U0DLmIU=:iYPxkr47AW8jUHpC4A1aD+
 CWM6vwMpRABhdhuHM8umn0bCMoVg9dKgKMXGPKvrIQkLalNyMLunA4nTOiNStHVSiBQBCh2Cp
 +7pcmO5vpVfRNL2unZpmsk+H+5iKz9c8uyjEvaIEYauhlVe5P6YIQR5PWqlxTKBYpqBB4ZwtV
 AE/YneumJYqsVVPHKbGfRjIzGGFaxXVkZtEhmyfoWz9hBeVqGGEtWEqJg8xlmDdsnkuqeZi4m
 DJ/Q0Vb7Vl59pr6X8wTaKcdLuzgVmSLwNrDQzrT+VlvFkxPJwE9Tqf/5rpPlPWxxdxLgpMj1a
 6bCeYfQtssx3v57VQu/3SvRXVMyevtZQdWG0+sG4UMiM0ojxARzIROs6OtDSEyStn0Up6GqQX
 IBVdmC+UP8DOWWUHxrzZFt2G/5GIfigZeayMQYdeOEEqp9eteTFoW5wQfBYprTG6NCoSpRlLn
 nglq5rFBm3VsV3/vEtAIqNhrRe60oK/Sin7pPI9nUP6eQelqgu/1Qatk6ZVK0N+7uSCE1VcV1
 um/JcJRz+8wGupEoCEVwcBPDUPDDXkoU12VBwym0yuBdeUGKd96nkcB3AaCF41a/M9KAlgRpV
 xyBCEvtFTMAddKNnnAhV3gB6WbGl1Cfzx6enAt8fLgfDSYRcVtGeAOLnBdDZTIhWyxz7gv6Bx
 OegjleYkVhxcV+jvXb37FjglBAeA8BHhTqISZiLCHvujhVTQg56hSxsJOaaVtxWDCSNrm0GU2
 bqgxTHZPcvw2+ebtRUDO21AzeZNTNq7WhmEl9p4onunaiHrbnZr6y2+DC3XcpDrBrJUYitigp
 qbDbu7dERJiTkjxUV2l2uHMJQhdAVVAjh/rh4ctsWmE2WkEjQ8=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -42,10 +42,9 @@ static int emi26_writememory (struct usb_device *dev, int address,
>>  	int result;
>>  	unsigned char *buffer =  kmemdup(data, length, GFP_KERNEL);
>>
>> -	if (!buffer) {
>> -		dev_err(&dev->dev, "kmalloc(%d) failed.\n", length);
> 
> I guess the length information would not be so easy to find in the backtrace.

Why do you “guess”?


>> +	if (!buffer)
>>  		return -ENOMEM;
>> -	}

Would we like to achieve another consensus on the data which are provided by
a default Linux allocation failure report?

Regards,
Markus