From: Ed Cashin <ed.cashin@acm.org>
To: Kees Cook <keescook@chromium.org>, Jens Axboe <axboe@kernel.dk>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block/aoe: discover_timer: Convert timers to use timer_setup()
Date: Fri, 3 Nov 2017 20:39:40 -0400 [thread overview]
Message-ID: <c8772ae6-e0ed-6fc4-340b-455168e978b0@acm.org> (raw)
In-Reply-To: <20171102233151.GA103378@beast>
On 11/02/2017 07:31 PM, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> This refactors the discover_timer to remove the needless locking and
> state machine used for synchronizing timer death. Using del_timer_sync()
> will already do the right thing.
Looks OK to me, thanks.
--
Ed
prev parent reply other threads:[~2017-11-04 1:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 23:31 Kees Cook
2017-11-04 0:39 ` Ed Cashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8772ae6-e0ed-6fc4-340b-455168e978b0@acm.org \
--to=ed.cashin@acm.org \
--cc=axboe@kernel.dk \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome