From: Markus Elfring <Markus.Elfring@web.de>
To: Aditya Pakki <pakki001@umn.edu>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Kangjie Lu <kjlu@umn.edu>, Qiushi Wu <wu000273@umn.edu>
Subject: Re: [PATCH] rocker: Fix error handling in dma_rings_init()
Date: Sat, 13 Jun 2020 08:14:13 +0200 [thread overview]
Message-ID: <c87858ed-a91f-22d3-09d7-17a00703d168@web.de> (raw)
> … The patch fixes the
> order consistent with cleanup in rocker_dma_rings_fini().
I suggest to choose another imperative wording for your change description.
Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
next reply other threads:[~2020-06-13 6:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 6:14 Markus Elfring [this message]
2020-06-14 7:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c87858ed-a91f-22d3-09d7-17a00703d168@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kjlu@umn.edu \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®