From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7666DC433DF for ; Wed, 10 Jun 2020 17:13:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 598DC2070B for ; Wed, 10 Jun 2020 17:13:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729286AbgFJRN2 (ORCPT ); Wed, 10 Jun 2020 13:13:28 -0400 Received: from smtprelay0251.hostedemail.com ([216.40.44.251]:51044 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726979AbgFJRN2 (ORCPT ); Wed, 10 Jun 2020 13:13:28 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 59FF8180286EF; Wed, 10 Jun 2020 17:13:27 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: coat52_230528b26dcc X-Filterd-Recvd-Size: 1882 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Wed, 10 Jun 2020 17:13:26 +0000 (UTC) Message-ID: Subject: Re: [PATCH] .clang-format: update column limit From: Joe Perches To: Christian Brauner , Miguel Ojeda Cc: linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Linus Torvalds Date: Wed, 10 Jun 2020 10:13:24 -0700 In-Reply-To: <20200610125147.2782142-1-christian.brauner@ubuntu.com> References: <20200610125147.2782142-1-christian.brauner@ubuntu.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-06-10 at 14:51 +0200, Christian Brauner wrote: > The provided clang-format file wraps at 80 chars. If noone minds I'd like > to adjust this limit to 100 similar to what checkpatch (cf. [1]) uses now. > > [1]: commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning") > Signed-off-by: Christian Brauner [] > diff --git a/.clang-format b/.clang-format [] > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false > #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0 > BreakAfterJavaFieldAnnotations: false > BreakStringLiterals: false > -ColumnLimit: 80 > +ColumnLimit: 100 Ii think this is a not a good change. If you read the commit log you provided, it ways "staying withing 80 columns is certainly still _preferred_" With this change, clang would _always_ wrap to 100 columns. clang would not make any reasonable attempt to use 80 when it should.