From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5AD1D5AAE for ; Fri, 25 Oct 2024 09:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729849496; cv=none; b=RDXK5+ZbYYXKksU8KNL4DS5JyrkyTetoTP830uwyg6yz20v/qbfsgAS2twi6OhOKNVrUPDFSf0AfP3ophy836rVUysmzgO28380GcHqFZKPsLQWFNviDhtrDYRLXRsWdS9uzjO2Iz+cNSuhEDHGaIZ77rfywMy6yNsnT59lMRuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729849496; c=relaxed/simple; bh=ZafInEDb0XvZcBle/B3yP/da0xFDIROyRvCkN9TXFGg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bg7CiaJLb4drieSza/mT/OK/RhanwCabClSxrATGTPwEh4I1ib1d8LCGaZJrQVpFxkRL/2C64hAT3P8ow88rrE/RLlIYPTeQHZc8dFoHkZMZOwVrTye/UrHTZNebKwKkZK0IiswG5BVdHOfRoBkwfG6w/KZQtND8BOTjiFgd+GQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fl07+xZf; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fl07+xZf" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a99cc265e0aso263158366b.3 for ; Fri, 25 Oct 2024 02:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729849492; x=1730454292; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TV3rdZguaCClNEqVe787I0Vt/8PGTZ52ISSdbaUDUE8=; b=fl07+xZfAB1VcddLviq6Nf/eZBWnkA6V+CjTgFj0eD/zTuOVGsxsp+TC5oXAjXAaaN kyIJ6yd6qrhv8lCbnjV3b4jRMfF+SNdMUHJkY92XyI6LvMoFvg3HWEtmkuUmsR6xLZxV qc4NLTysRAQ+PNX9MutJId4yftQHjWQYRLi17ttnzuNyLRkZjbJkPv4qaJVdX3n+csA1 RIyRgjoCQ6EbS0HVc8g0N9vkUj6j88xX9pjjlep7cUS2WZ6fXhGL4ZK+B94GebVxqhaf i6tF/Acxuqzl0bsExl+NQDRJMa9c7ScqCTt4y50qA3m2/qvIE7ccQ9sG/l/MKTOy3PFP Hh8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729849492; x=1730454292; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TV3rdZguaCClNEqVe787I0Vt/8PGTZ52ISSdbaUDUE8=; b=FZJXziuVbAvlRSyOyOELVZY3GJP+tAAJpM+Pm1xuuIPdjEVO7PzkQiQc1YtK5Qmezm jKFfVwp/f8KQiJ3Vl+315piXywZ2Xi0z+J1egUFziMAksGgOrHc21i2aDG1th8zWQ8NK RPNI0oWp93tm36zFMDVrTbwNJVqBMe61KWn0q0j8IdEl+7quqs07am2qtiO+gzKvuYAq EithJSkPVkIuHUKP43ZQ2R8f454CTQ3xPt0r6t6MefxiKBS005cjRjpANzj4cQCGm+TZ kEj9SiCmOyR2akTdjfOnRZfmHCsIKYAkMh7EyX1Ue+djM2GBHkya3+BVp53w+TQaXzZV LgOw== X-Forwarded-Encrypted: i=1; AJvYcCVfBo/Dir1XFCVUNm/8Tj9H7pRuUUkPFj/NaenkOyNhiVtGWUE5cSNF/aPnrw8YBA97rUB3nJpNb7Y4rsM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy+yQh6tBCFxQs/6TrcGnoFoCsq7VnmECEamLmNB2cj66rkMxo 6wVB2+W3TJf2awXGZ/4fkliV9gk0A/G9PDP0T0ynt6a+H4SUtedC29mYyK3N6AY= X-Google-Smtp-Source: AGHT+IGvMaHhp0yBItJqMrGnh8WZFy1BosQ2JJpGEG7L5fd6mP/jhMEMMgdVrFkbCial7NwjOHcdTw== X-Received: by 2002:a17:906:730f:b0:a99:f8db:68b2 with SMTP id a640c23a62f3a-a9ad2730a9amr471160666b.18.1729849491793; Fri, 25 Oct 2024 02:44:51 -0700 (PDT) Received: from [192.168.0.157] ([79.115.63.43]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b1f029511sm50430366b.62.2024.10.25.02.44.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Oct 2024 02:44:51 -0700 (PDT) Message-ID: Date: Fri, 25 Oct 2024 10:44:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] firmware: add exynos acpm driver To: Alim Akhtar , krzk@kernel.org Cc: mst@redhat.com, javierm@redhat.com, tzimmermann@suse.de, bartosz.golaszewski@linaro.org, luzmaximilian@gmail.com, sudeep.holla@arm.com, conor.dooley@microchip.com, bjorn@rivosinc.com, ulf.hansson@linaro.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, marcan@marcan.st, neal@gompa.dev, alyssa@rosenzweig.io, broonie@kernel.org, andre.draszik@linaro.org, willmcvicker@google.com, peter.griffin@linaro.org, kernel-team@android.com, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, Jassi Brar References: <20241017163649.3007062-1-tudor.ambarus@linaro.org> <20241017163649.3007062-3-tudor.ambarus@linaro.org> <0da701db23d8$ed5684e0$c8038ea0$@samsung.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <0da701db23d8$ed5684e0$c8038ea0$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/21/24 5:47 PM, Alim Akhtar wrote: > Hi Tudor Hi, Alim! Thanks for the review! >> diff --git a/drivers/firmware/samsung/Kconfig >> b/drivers/firmware/samsung/Kconfig >> new file mode 100644 >> index 000000000000..f908773c1441 >> --- /dev/null >> +++ b/drivers/firmware/samsung/Kconfig >> @@ -0,0 +1,11 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> + >> +config EXYNOS_ACPM > > This looks misleading to me, as you mentioned below, ACPM is a FW which runs > on APM module, and > The proposed driver is a communication method between Application processor > and APM module, > Which is via MAILBOX. > So preferably EXYNOS_MAILBOX_APM is more meaningful here. This seems more accurate indeed. The design document that I have refers to the protocol as "ACPM IPC", so maybe I shall stick with EXYNOS_ACPM_IPC. I'll also need to prefix all the definitions in the driver with exynos_acpm_ipc_* which will result in long names. But I guess there's nothing we can do about it. Cheers, ta