From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B43C2C47089 for ; Thu, 1 Dec 2022 21:28:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231164AbiLAV2O (ORCPT ); Thu, 1 Dec 2022 16:28:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbiLAV2B (ORCPT ); Thu, 1 Dec 2022 16:28:01 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86D7976141; Thu, 1 Dec 2022 13:28:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3450CB82025; Thu, 1 Dec 2022 21:27:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A85AEC433D6; Thu, 1 Dec 2022 21:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669930078; bh=+DN+P/rKB/9tSIZAc6i0bxDS167JyMagYuQTQ8imLrI=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=uQMJuusUn8CNI4pztWvsbyTXchDju2WKgZTz3saR/BgX9smZeCwvibPrzs9Tdto6H VA9B1hA7g7ZOhjYryGYTX7Z2fNYZCFaLNU5zyko1KC8a/DqKJyohuKBs4elBA7l+CK 1msdZtU5vSC8+oDl5fYLVFDw3+MmkcaWIyfn7oMfr7b/CWLZNb4x2FdMn8tJJ6Qb8q OFWEsb4OpyFYQmjxyY7bi7RwZSQS1lZqFMFDjlfh23gGwxCP14wpbjORohXqKNMpdJ mpKWX/+eyf8VB0Yv5i8qVoz0YIm4tzoNwis/YhJQieorteKMRctFM6mX1T8jiMv2Wl FqJZjXvPVfNEg== Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 8A80727C0054; Thu, 1 Dec 2022 16:27:55 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Thu, 01 Dec 2022 16:27:55 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdehgdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusehkvghrnhgvlhdrohhrgheqnecuggftrf grthhtvghrnhepvdeviefgtedugeevieelvdfgveeuvdfgteegfeeiieejjeffgeeghedu gedtveehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhguodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduvdekhedujedt vdegqddvkeejtddtvdeigedqrghrnhgupeepkhgvrhhnvghlrdhorhhgsegrrhhnuggsrd guvg X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E3357B60086; Thu, 1 Dec 2022 16:27:54 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Mime-Version: 1.0 Message-Id: In-Reply-To: <7e5f86c0-04b3-aa68-565a-7b86f1e1553d@infradead.org> References: <20221201204310.142039-1-arnd@kernel.org> <7e5f86c0-04b3-aa68-565a-7b86f1e1553d@infradead.org> Date: Thu, 01 Dec 2022 22:27:34 +0100 From: "Arnd Bergmann" To: "Randy Dunlap" , "Damien Le Moal" Cc: linux-kernel@vger.kernel.org, "Arnd Bergmann" , "Luis Machado" , linux-ide@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ata: ahci: fix enum constants for gcc-13 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 1, 2022, at 21:48, Randy Dunlap wrote: > On 12/1/22 12:43, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> gcc-13 slightly changes the type of constant expressions that are deifined > > defined fixed >> --- >> drivers/ata/ahci.h | 234 ++++++++++++++++++++++----------------------- >> 1 file changed, 117 insertions(+), 117 deletions(-) > > What #include ? > or is it just done indirectly? Good point. It survived a build test, and it's one of the headers that is almost always included from somewhere, but you are correct that there should be an explicit include here as well. I also found that PORT_CMD_ICC_MASK is still a negative number that needs to be changed: @@ -178,10 +178,10 @@ enum { PORT_CMD_SPIN_UP = BIT(1), /* Spin up device */ PORT_CMD_START = BIT(0), /* Enable port DMA engine */ - PORT_CMD_ICC_MASK = (0xf << 28), /* i/f ICC state mask */ - PORT_CMD_ICC_ACTIVE = (0x1 << 28), /* Put i/f in active state */ - PORT_CMD_ICC_PARTIAL = (0x2 << 28), /* Put i/f in partial state */ - PORT_CMD_ICC_SLUMBER = (0x6 << 28), /* Put i/f in slumber state */ + PORT_CMD_ICC_MASK = (0xfu << 28), /* i/f ICC state mask */ + PORT_CMD_ICC_ACTIVE = (0x1u << 28), /* Put i/f in active state */ + PORT_CMD_ICC_PARTIAL = (0x2u << 28), /* Put i/f in partial state */ + PORT_CMD_ICC_SLUMBER = (0x6u << 28), /* Put i/f in slumber state */ /* PORT_CMD capabilities mask */ PORT_CMD_CAP = PORT_CMD_HPCP | PORT_CMD_MPSP | I've addressed all three issues now, will send a v2 after Luis is able to validate that this fixes the problem. Arnd