From: Philipp Zabel <p.zabel@pengutronix.de>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
linux-clk@vger.kernel.org
Cc: john@phrozen.org, linux-staging@lists.linux.dev,
gregkh@linuxfoundation.org, neil@brown.name,
linux-kernel@vger.kernel.org, sboyd@kernel.org
Subject: Re: [PATCH v7 3/4] clk: ralink: make system controller node a reset provider
Date: Mon, 10 Jan 2022 12:37:24 +0100 [thread overview]
Message-ID: <c88e81067826f04e2301b52eddb84ec84bbd1c9d.camel@pengutronix.de> (raw)
In-Reply-To: <20220110111036.1380288-4-sergio.paracuellos@gmail.com>
On Mon, 2022-01-10 at 12:10 +0100, Sergio Paracuellos wrote:
[...]
> +static int mt7621_rst_xlate(struct reset_controller_dev *rcdev,
> + const struct of_phandle_args *reset_spec)
> +{
> + unsigned long id = reset_spec->args[0];
> +
> + if (id == MT7621_RST_SYS)
if (id == MT7621_RST_SYS || id >= rcdev->nr_resets)
I forgot to mention that with .of_xlate set, the driver needs to check
whether id < nr_resets on its own.
regards
Philipp
next prev parent reply other threads:[~2022-01-10 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 11:10 [PATCH v7 0/4] clk: ralink: make system controller " Sergio Paracuellos
2022-01-10 11:10 ` [PATCH v7 1/4] dt-bindings: reset: add dt binding header for Mediatek MT7621 resets Sergio Paracuellos
2022-01-10 11:10 ` [PATCH v7 2/4] dt-bindings: clock: mediatek,mt7621-sysc: add '#reset-cells' property Sergio Paracuellos
2022-01-10 11:10 ` [PATCH v7 3/4] clk: ralink: make system controller node a reset provider Sergio Paracuellos
2022-01-10 11:37 ` Philipp Zabel [this message]
2022-01-10 11:41 ` Sergio Paracuellos
2022-01-10 11:10 ` [PATCH v7 4/4] staging: mt7621-dts: align resets with binding documentation Sergio Paracuellos
2022-01-10 11:28 ` Philipp Zabel
2022-01-10 11:36 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c88e81067826f04e2301b52eddb84ec84bbd1c9d.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=john@phrozen.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=neil@brown.name \
--cc=sboyd@kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®