From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 344E0C433EF for ; Wed, 20 Oct 2021 13:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16993601FF for ; Wed, 20 Oct 2021 13:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230246AbhJTNLK (ORCPT ); Wed, 20 Oct 2021 09:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbhJTNLF (ORCPT ); Wed, 20 Oct 2021 09:11:05 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22DE9C06161C for ; Wed, 20 Oct 2021 06:08:51 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id d198-20020a1c1dcf000000b00322f53b9b89so10151572wmd.0 for ; Wed, 20 Oct 2021 06:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=4P4AVlRuS+D8nRRZwY7bESCy+/9tZLn5inc7/Sy4z+g=; b=XyzvrgVNkV/afwxqMkX5uoSxL3qX4Hb0sTQfo44r6x/QtqVKaSBK/7OlAuOIAlRrjE NbszUB0kB50R4XBwLdOENLmlQwexDnDhOIiN8oHs/7y5FuGrOP2Pw1Tv40oDTytAfNlj UojVZ8UMguW/TueF7aeKl98cY0wfwMpOz68CfC9J2FaUNv4gLTvEiycezbR7+mwP7Ar5 L4+KJTZX12i7L+QMgyMMOlZX94fFMefhocAyip/fGcy5wK+T9hgV8G1mFITiq57Kx55+ Uc3wIW/aNMGxTIyxRNXhc89sMuKPJICdcNFWY0lu6WW9WjQQyGk9i7JUEMuyPxgLNuCy RjgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4P4AVlRuS+D8nRRZwY7bESCy+/9tZLn5inc7/Sy4z+g=; b=JSpTUlk9OxDpzaYwBpCLiK2HYZ2nO0iIRhHS6b8bNnINoI8lf2Nido4tcO6W5RKulS dSvU/bKAjWBkCzxva1TJ+qjcdrtFMjTtJy+8yoap9e49tJSDRq/+AH6VCkZEEZaARkSs fMCNpsUvWhnsvileZVb+2WPn91rAaNduTZsDLx9T1gsak/D8dChYzWWiOx41B01A/CWI UgyoJeCqFmjLpF34Up7MU1yuHNtocO8oi57YLRu794+tlkQYiB7ahVFlUjgeP7CKIcZi m4LiBurnPBoyCQib4yxyPwaL0j+4pOAzTkiosCOg9ZuVE/YhZTTETiCHkKnwJuS4sDBX yjSw== X-Gm-Message-State: AOAM533FB4lAeJ/3+UuluklLkJ5+Z0RKZqdyPBESiQaTO7Va7A5PM2x7 biYI4BuUqsZpNQYZXg1XEf4= X-Google-Smtp-Source: ABdhPJyBxaVbJZpais0T6mHisqa9q1uhVgD3hlebgRYc6WsQ0a5As2/UOlqoeZF29HBhlvSZhyQgHQ== X-Received: by 2002:adf:e7d0:: with SMTP id e16mr51195752wrn.283.1634735329623; Wed, 20 Oct 2021 06:08:49 -0700 (PDT) Received: from ?IPv6:2a01:4b00:f411:e700:e085:8cb7:7bf6:5d62? ([2a01:4b00:f411:e700:e085:8cb7:7bf6:5d62]) by smtp.gmail.com with ESMTPSA id g25sm2012944wrc.88.2021.10.20.06.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 06:08:49 -0700 (PDT) Message-ID: Subject: Re: [Outreachy kernel] [PATCH] staging: vt6655: Rename `by_preamble_type` parameter From: Karolina Drobnik To: Julia Lawall Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, forest@alittletooquiet.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Wed, 20 Oct 2021 14:08:47 +0100 In-Reply-To: References: <20211020084033.414994-1-karolinadrobnik@gmail.com> <6089e564f89ceaa7303bf3a4b4c864bf1389ac25.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-10-20 at 14:59 +0200, Julia Lawall wrote: > On Wed, 20 Oct 2021, Karolina Drobnik wrote: > > > On Wed, 2021-10-20 at 10:54 +0200, Julia Lawall wrote: > > > On Wed, 20 Oct 2021, Karolina Drobnik wrote: > > > > > > > Drop `by` prefix in the first parameter of `bb_get_frame_time` > > > > function. > > > > As the original argument, `byPreambleType`, was renamed to > > > > `preamble_type`, > > > > the parameter referring to it is now renamed to match the new > > > > naming > > > > convention. > > > > Update `bb_get_frame_time` comment to reflect that change. > > > > > > > > This patch is a follow-up work to this commit: > > > >     Commit 548b6d7ebfa4 ("staging: vt6655: Rename > > > > byPreambleType > > > > field") > > > > > > This is not going to be practical.  If the previous patch is > > > accepted, then this it not needed. > > > > This change was there before but Greg told me to do only one > > logical > > change per patch (which was a struct member rename), so I reverted > > it. > > I believe this is needed because this parameter still uses > > Hungarian > > notation, which is against the LK coding style. Also, it makes > > sense to > > update the name given my previous change. > > Sorry, I think I was not clear.  It's not practical to explain > constraints > on other patches in the log message. Oh, I see. I thought about this log message as "why" but now, when I come think of it, just saying it's about the Hungarian notation should be enough. I'll correct the log message, thank you. > > The important thing is > that if you want to make two different changes on the same file, > either > the first one has to be accepted before you submit the second one, or > they > have to be in a series. I see, thanks for clarification. > > > > > I can add this in but will that still count as a one logical > > change? > > No.  It's a different change.  It's just a small whitespace issue, > but > it's not triggered by the other changes you have made. Ok, I'll submit a separate patch for it later on. Thanks, Karolina