From: Dinh Nguyen <dinguyen@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v3] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE_TEST
Date: Thu, 21 Oct 2021 17:09:15 -0500 [thread overview]
Message-ID: <c89e23d6-b56c-1c69-287e-18d8c890f539@kernel.org> (raw)
In-Reply-To: <20211021143315.3139952-1-linux@roeck-us.net>
On 10/21/21 9:33 AM, Guenter Roeck wrote:
> nios2:allmodconfig builds fail with
>
> make[1]: *** No rule to make target 'arch/nios2/boot/dts/""',
> needed by 'arch/nios2/boot/dts/built-in.a'. Stop.
> make: [Makefile:1868: arch/nios2/boot/dts] Error 2 (ignored)
>
> This is seen with compile tests since those enable NIOS2_DTB_SOURCE_BOOL,
> which in turn enables NIOS2_DTB_SOURCE. This causes the build error
> because the default value for NIOS2_DTB_SOURCE is an empty string.
> Disable NIOS2_DTB_SOURCE_BOOL for compile tests to avoid the error.
>
> Fixes: 2fc8483fdcde ("nios2: Build infrastructure")
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v3: Added Fixes: and Reviewed-by: tags
> v2: Add build error message to commit description
>
> arch/nios2/platform/Kconfig.platform | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/nios2/platform/Kconfig.platform b/arch/nios2/platform/Kconfig.platform
> index 9e32fb7f3d4c..e849daff6fd1 100644
> --- a/arch/nios2/platform/Kconfig.platform
> +++ b/arch/nios2/platform/Kconfig.platform
> @@ -37,6 +37,7 @@ config NIOS2_DTB_PHYS_ADDR
>
> config NIOS2_DTB_SOURCE_BOOL
> bool "Compile and link device tree into kernel image"
> + depends on !COMPILE_TEST
> help
> This allows you to specify a dts (device tree source) file
> which will be compiled and linked into the kernel image.
>
Applied!
Thanks,
Dinh
prev parent reply other threads:[~2021-10-21 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 14:33 Guenter Roeck
2021-10-21 22:09 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c89e23d6-b56c-1c69-287e-18d8c890f539@kernel.org \
--to=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®