mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Honglei Wang <wanghonglei@didichuxing.com>
To: Oliver Sang <oliver.sang@intel.com>
Cc: <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
	<linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	<aubrey.li@linux.intel.com>, <yu.c.chen@intel.com>,
	Tiwei Bie <tiwei.btw@antgroup.com>,
	Abel Wu <wuyun.abel@bytedance.com>
Subject: Re: [linus:master] [sched/eevdf] 2227a957e1: BUG:kernel_NULL_pointer_dereference,address
Date: Thu, 1 Feb 2024 10:52:47 +0800	[thread overview]
Message-ID: <c8a1b948-4e03-418b-94b9-c35045b8f886@didichuxing.com> (raw)
In-Reply-To: <Zbr51SNYUpH2J+3z@xsang-OptiPlex-9020>



On 2024/2/1 09:54, Oliver Sang wrote:
> hi, Honglei,
> 
> On Thu, Feb 01, 2024 at 09:29:30AM +0800, Honglei Wang wrote:
>>
>>
>> On 2024/1/30 22:09, Oliver Sang wrote:
>>> hi, Abel,
>>>
>>> On Tue, Jan 30, 2024 at 06:13:32PM +0800, Abel Wu wrote:
>>>> On 1/30/24 3:24 PM, kernel test robot Wrote:
>>>>>
>>>>>
>>>>> Hello,
>>>>>
>>>>> (besides a previous performance report),
>>>>> kernel test robot noticed "BUG:kernel_NULL_pointer_dereference,address" on:
>>>>>
>>>>> commit: 2227a957e1d5b1941be4e4207879ec74f4bb37f8 ("sched/eevdf: Sort the rbtree by virtual deadline")
>>>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>>>>>
>>>>> [test failed on linus/master 3a5879d495b226d0404098e3564462d5f1daa33b]
>>>>> [test failed on linux-next/master 01af33cc9894b4489fb68fa35c40e9fe85df63dc]
>>>>>
>>>>> in testcase: trinity
>>>>> version: trinity-i386-abe9de86-1_20230429
>>
>> Hi Oliver,
>>
>> I'm a bit curious, did the problem happen on i386 only? Did you hit it on
>> x86_64 or other platform with the same trinity testcases?
> 
> we did not observe same issue on x86_64 so far.
> 
> we can run performance tests with this commit on x86_64 (compiled with gcc-12).
> FYI, we sent out a performance report before this crash one.
> 
> https://lore.kernel.org/all/202401292151.829b01b0-oliver.sang@intel.com/
> 

Thanks for the feedback. The performance improvement is as expected. I 
assume the panic is not introduced by 2227a957e1. We don't know where 
the "EEVDF scheduling fail, picking leftmost" messages come from even 
before this patch.

It would be great if we can find a way to reproduce the problem. Seems 
it's worth a try on VM with fewer cpus and a bit more syscall workload 
like testcase trinity.

>>
>> Thanks,
>> Honglei

  reply	other threads:[~2024-02-01  2:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30  7:24 kernel test robot
2024-01-30 10:13 ` Abel Wu
2024-01-30 14:09   ` Oliver Sang
2024-01-31 12:34     ` Abel Wu
2024-02-01  1:47       ` Oliver Sang
2024-02-01  1:29     ` Honglei Wang
2024-02-01  1:54       ` Oliver Sang
2024-02-01  2:52         ` Honglei Wang [this message]
2024-01-31 12:10   ` Tiwei Bie
2024-01-31 12:28     ` Abel Wu
2024-01-31 13:14       ` Tiwei Bie
2024-02-19 12:35       ` Chen Yu
2024-02-20  3:39         ` Abel Wu
2024-02-21  2:16         ` Oliver Sang
2024-02-19 12:49   ` Chen Yu
2024-02-20  4:04     ` Abel Wu
2024-02-20  9:17       ` Chen Yu
2024-02-21  2:32     ` Oliver Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8a1b948-4e03-418b-94b9-c35045b8f886@didichuxing.com \
    --to=wanghonglei@didichuxing.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=peterz@infradead.org \
    --cc=tiwei.btw@antgroup.com \
    --cc=wuyun.abel@bytedance.com \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®