From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2C743164C5 for ; Mon, 19 Jan 2026 11:45:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768823117; cv=none; b=kmnAA/aWmCkxoPHSqo8yX8QTHBhjUyjSyvS0ajtLvYKPAY+tW876XM7q/hgpUBottjsg15xs6MIN8mBM7JBhStjZ37898q6eWcN6/fD6oqsm/OZ7HcyZKObEsirAuad8ejv/5+1nwwJSttKub+npbpUxNSWpcwkG6loriap8yXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768823117; c=relaxed/simple; bh=umryTibXcEQwLZ01ZLSgmOnDPdofWJThj73ttFHadAQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N+9f2PriJno/M+JH/8ULaTTAa1Rt9T7jtFMANMonU6BfqdJ6JyLR441bq6du6HIeAOYAM8rWCd5QUKMRQ8q2nj6WZXKBqRZ6Rg/ltU82KA4qgCo+wSf+XPHXclNw0DN4xutIhhT25rLBu7SvCQ6+NtWtR54fPg12Nw5wNQfJhdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZasSyb5P; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UY5LYxum; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZasSyb5P"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UY5LYxum" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60JAJgjP1531138 for ; Mon, 19 Jan 2026 11:45:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /eXR7xA5LS0QTGw/FESYvmdD/IqbbhC/JHHaNFog5ho=; b=ZasSyb5P9baP6bMm QZyAsG7eOqPxRNO0n1+7OyzxTuJHEDJGdzalmOBMlWzwhvjyeWqC/q4zqdkB0GwE fOp0jw8o4qnMfatdTsLJFOtLMlvvRkGqJ7ctSF5Z+kIgvb1xaJIaTExGnTXM/vjr xNY0mwSdwRs0zcWK1tiBoMJAvSPU03sHEWLLXUNhyEzCiGMpQf+oT9W6GH7E9VsW yopMYoGEYNiXNgPDZUGKzEPTGmYlUOKTsOMJ5UuTkYKQni5Bggonz7qOK1Q+u1fA IXf1ACXWsnAb5dOYwXOYsOFXyX602KMFAhPYnbxMpn2vmjdTDf9ZJ4Mqj+aibiE8 KK7lKA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsjrxr815-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 11:45:15 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34ec823527eso7459504a91.2 for ; Mon, 19 Jan 2026 03:45:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768823114; x=1769427914; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/eXR7xA5LS0QTGw/FESYvmdD/IqbbhC/JHHaNFog5ho=; b=UY5LYxumRz/QOFscDlt/qY5KCine8fQWIdFWIwbFGiQE34BAUHwNUbavbIUAP13me0 +tY1L03Onn17xrSZ7kzzVkSr64NSZz/oXdZFkyLMqBxiwSr1xHg6KVXfpVmnuFwSoXsj +1wJ/7rtLW9fQa2DsgGsx7RWKyVJIdwXc//4mup97pXFxKDNyQEoVyoGEkNAJlO8xfVi gLQpwr4TEGelYHGUm0YrkZla6NFYeeTHRQddKMOHZx7Emk0IKzJtGRIJmFbyBD9ZtuEf tBXBRELHNwbdmh3SxNzpPUPsr9D7U5HAiiW2GFgt8xSkYxXd8n7VLVhHiTvoBZfB56nt kOQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768823114; x=1769427914; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/eXR7xA5LS0QTGw/FESYvmdD/IqbbhC/JHHaNFog5ho=; b=a7X5u6j9M+thF+UmC4OaB/ZbJLFL9SWq7EMdwT8GJBMKs/hz+QXti0rAuVdV3AxgJ8 Ojl/5N5BXcdUavUng+qZntb5MziDnIN0sIRQF3ZhtK0AP79Lj2DyQvs3tYX/1OD+Bmwh sgjrARTU0pjNNCPE7Ae8h+O/jva2dCKQbu95JHtkayEaZQYJ/wTLw/niZCpasNlt78xF edSWWKWxpoYVyKys4YFomti2qukjLtb6HRJ32WKjy0iN9YUU8lcXRKAgkEdQw3B1yBrY 1PBcWDLww8X5gSSQGLfP3W5EiNtPkBTeCU8Ou+0ocXuOc03wQ74le11vomDJzgRXAdpz gv8A== X-Forwarded-Encrypted: i=1; AJvYcCUvxSG5jIZ+569icW2U6yPDFi73Cgn/IvITQCqalFWHqRzc7D1YGsx4XgbkHUbIcH6OPU+KdOqmDTJMn0g=@vger.kernel.org X-Gm-Message-State: AOJu0YxOXvKHhPIVHVvPsMJK9oT4toKc6oNIS/mnIrS6TYpo2G9P+b4y 3aXX2frkwUJa7KfyI+vllYTcv+FaphptNus2jsaqefuvRcRwVzt72zZodJidpA/zCW1OO9K8I0r d9Gdvzhb1MoYZynffYhHoph1gR3pMVoA0BvZeYwcu5a00w0k+KO1WE6eEjYw4RYWlyvY8CXxVue 4= X-Gm-Gg: AZuq6aLLqoMvqZQ0F+SF/JxOTD6iJvgA8Q2kgSgE/YD6ECn0DbnzHYjiuQPxi/jv6oh 0EV+Fl/xZP5AH5rrop5ZrxT5X7PwCVNxlcVpB/tIF071FEP+mZQblKFMvtUIJ7ibHmkHoEN88od /u9kGB6BeV2A5/cylh2abeVvdCcltfnNswQLDu8MSHH9l+qWxDiH4EVXC6CSGpvjgo1WMLA/RZk 7hwlkb0LVSVvHcJ8Cs0MUKVPxodOogD/o3Z+96oTklDpwNRFzWnsrlnb0YBiaRJLKXZEIAMiByj DwZrOsrXX9lDin9Y68IqNxxX3tkW37ER1le6WSEPe8VXDChPtdKNY4u86ASlfYYRQOd9KrWomas YD3cCmbTHuzSLZEuEnvuE9pmZlo7CjDX17gs= X-Received: by 2002:a17:90b:2750:b0:34a:adf1:6781 with SMTP id 98e67ed59e1d1-35272efa0dbmr9463649a91.9.1768823114540; Mon, 19 Jan 2026 03:45:14 -0800 (PST) X-Received: by 2002:a17:90b:2750:b0:34a:adf1:6781 with SMTP id 98e67ed59e1d1-35272efa0dbmr9463624a91.9.1768823114080; Mon, 19 Jan 2026 03:45:14 -0800 (PST) Received: from [10.239.97.158] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3527306d61bsm5934443a91.7.2026.01.19.03.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 03:45:13 -0800 (PST) Message-ID: Date: Mon, 19 Jan 2026 19:45:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Bluetooth: btusb: Allow firmware re-download when version matches To: Marcel Holtmann , Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, cheng.jiang@oss.qualcomm.com, quic_chezhou@quicinc.com, wei.deng@oss.qualcomm.com, jinwang.li@oss.qualcomm.com, mengshi.wu@oss.qualcomm.com References: <20260108074353.1027877-1-shuai.zhang@oss.qualcomm.com> Content-Language: en-US From: Shuai Zhang In-Reply-To: <20260108074353.1027877-1-shuai.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA5NyBTYWx0ZWRfX2J8OMuRZITAC X3wIqs3DZqeQwdKWO/AEJAHNawcgLxCjEfBu5hMAljW1RoQbYWM/jqg92w4vw6K91UZKMYYUoRU /gHSeMP7WJOOa3n//Ex0WEhcNjvrEtrQERE6B0AzUTDJSInPLAr6ExU+Tj8cJy87k7bJHSrHNAK Z82oH6P+b4QSV2X+r1evTwkh2ajZtfsYbBBsy5LZikwz7R2jbwkoDpCe+Nj4UGPV16o3/b/tHuT cMm88HSmMbVSA/CSdexZyahX9PAedRn+/jhceBrLlrN3irJXr7/tee8d8jiIn2Imuh/hBOEhkay Jq2nqKBVmMs1sEi4DOcKVJ/IJetlXaHVjopKOxIVn970OG+4iFdXTXGrrOEFi4XMk6NiFEwgB9W Dc5pxVSg2Y2TBEJlLer46XTW8iDI7doy5MhKk0U43D92cfF2SN5liSyeRrcnf0t+GR7FWGFkv1l fMNl2wPTiPYnkRrvpXA== X-Proofpoint-GUID: cLJQmqnUxxi7Ml_VVRmKMMZNzIKRxT4m X-Authority-Analysis: v=2.4 cv=PPUCOPqC c=1 sm=1 tr=0 ts=696e194b cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=XLcW7MSiMK0kOx3OsRAA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: cLJQmqnUxxi7Ml_VVRmKMMZNzIKRxT4m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190097 Hi On 1/8/2026 3:43 PM, Shuai Zhang wrote: > Since USB can disconnect at any time, if it disconnects during > the BT firmware download, the BT controller firmware version may still > be updated even without completing the download. > > When USB reconnects, the BT host detects the same version as in the > firmware file, which prevents the firmware from being downloaded again. > > Therefore, remove the equality check to ensure that after > USB reconnection, the BT host can still download the firmware. > > Signed-off-by: Shuai Zhang > --- > drivers/bluetooth/btusb.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 646de80c7..991064a25 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -3503,7 +3503,10 @@ static int btusb_setup_qca_load_rampatch(struct hci_dev *hdev, > "firmware rome 0x%x build 0x%x", > rver_rom, rver_patch, ver_rom, ver_patch); > > - if (rver_rom != ver_rom || rver_patch <= ver_patch) { > + /* Allow rampatch if version is greater than or equal to firmware version. > + * Equal versions are acceptable for re-flashing or recovery scenarios. > + */ > + if (rver_rom != ver_rom || rver_patch < ver_patch) { > bt_dev_err(hdev, "rampatch file version did not match with firmware"); > err = -EINVAL; > goto done; Kindly let me know if there are any updates. Kindly, regard Shuai