mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Andrew Lunn <andrew@lunn.ch>,
	Justin Lai <justinlai0215@realtek.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jiri Pirko <jiri@resnulli.us>,
	Joe Damato <jdamato@fastly.com>,
	Larry Chiu <larry.chiu@realtek.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Ratheesh Kannoth <rkannoth@marvell.com>,
	Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next v25 01/13] rtase: Add support for a pci table in this module
Date: Mon, 29 Jul 2024 18:44:18 +0200	[thread overview]
Message-ID: <c8a42211-3b39-4258-93a7-354ce729eb7f@web.de> (raw)
In-Reply-To: <7d85ae3a-28d3-4267-9182-6e799ba8ae0a@lunn.ch>

>> …
>>> +++ b/drivers/net/ethernet/realtek/rtase/rtase.h
>>> @@ -0,0 +1,338 @@
>> …
>>> +#ifndef _RTASE_H_
>>> +#define _RTASE_H_
>> …
>>
>> I suggest to omit leading underscores from such identifiers.
>> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
>
> Do you have a reference to a Linux kernel document which suggests not
> to do this?

I assume that you would become interested to clarify corresponding concerns
according to compliance (or deviations) from the standard of the programming language “C”.


> My grep foo is not great, but there appears to be around 20,000
> instances of #define _[A-Z] in the kernel. So i doubt adding a couple
> more is going to be an issue.

I suggest to improve case distinctions accordingly.
Can it be more desirable to avoid undefined behaviour another bit?

How will development interests evolve further?

Regards,
Markus

  reply	other threads:[~2024-07-29 16:44 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29  6:21 [PATCH net-next v25 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 01/13] rtase: Add support for a pci table in this module Justin Lai
2024-07-29  9:33   ` Markus Elfring
2024-07-29 11:31     ` Justin Lai
2024-07-29 13:00     ` Andrew Lunn
2024-07-29 16:44       ` Markus Elfring [this message]
2024-07-29  6:21 ` [PATCH net-next v25 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-07-30  2:15   ` Jakub Kicinski
2024-07-30  9:24     ` Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 03/13] rtase: Implement the rtase_down function Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 05/13] rtase: Implement hardware configuration function Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-07-30  2:14   ` Jakub Kicinski
2024-07-30  9:27     ` Justin Lai
2024-07-30 14:12       ` Jakub Kicinski
2024-07-30 19:34       ` Heiner Kallweit
2024-07-29  6:21 ` [PATCH net-next v25 07/13] rtase: Implement a function to receive packets Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 08/13] rtase: Implement net_device_ops Justin Lai
2024-07-29 10:29   ` Joe Damato
2024-07-29 11:39     ` Justin Lai
2024-07-29 11:56       ` Joe Damato
2024-07-29 12:26         ` Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 10/13] rtase: Implement ethtool function Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-07-29  6:21 ` [PATCH net-next v25 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8a42211-3b39-4258-93a7-354ce729eb7f@web.de \
    --to=markus.elfring@web.de \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jdamato@fastly.com \
    --cc=jiri@resnulli.us \
    --cc=justinlai0215@realtek.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=larry.chiu@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkshih@realtek.com \
    --cc=rkannoth@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®