From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74464CCA47F for ; Fri, 1 Jul 2022 11:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235841AbiGALyW (ORCPT ); Fri, 1 Jul 2022 07:54:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbiGALyU (ORCPT ); Fri, 1 Jul 2022 07:54:20 -0400 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D04FC83F01 for ; Fri, 1 Jul 2022 04:54:16 -0700 (PDT) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20220701115415euoutp02d6350b63e276c403fc8e15065fcf6004~9snVt1i102851928519euoutp02R for ; Fri, 1 Jul 2022 11:54:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20220701115415euoutp02d6350b63e276c403fc8e15065fcf6004~9snVt1i102851928519euoutp02R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1656676455; bh=D0iTNPqm8xdE5bO7JoJlEXL2x40Y/ZNqT+jQxldPOSE=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=Nny+M92zjS7CB7jdVnDmwmHy1Blf73088G1YOBUJFSuy96pDjmHXlggowSmzgspKe W72cSnOI/hCkvv6EDyJmJXmzsarHCSKV02vLPwmcqtKZF89c+LCE8/Taz5fyFNbfCw nWYywORJBuTiSpmX7qktMi371CCoiMPIbDj0feM0= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20220701115415eucas1p25ea6f1d8e7270c71015f1b21ad9d987a~9snVaUSWT0592705927eucas1p2d; Fri, 1 Jul 2022 11:54:15 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 26.47.10067.660EEB26; Fri, 1 Jul 2022 12:54:14 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20220701115414eucas1p10a3278ddcc4503ad2674b62e3514345c~9snU0lzV11141111411eucas1p1n; Fri, 1 Jul 2022 11:54:14 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220701115414eusmtrp186e3d64503b8692aa72daeff85f1ed6e~9snUz2Le20885108851eusmtrp1V; Fri, 1 Jul 2022 11:54:14 +0000 (GMT) X-AuditID: cbfec7f4-dd7ff70000002753-37-62bee0665e44 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id BC.78.09038.660EEB26; Fri, 1 Jul 2022 12:54:14 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220701115413eusmtip11ad56a63fdfbe80f6ea2ad250f45bd84~9snULagbv0383503835eusmtip1J; Fri, 1 Jul 2022 11:54:13 +0000 (GMT) Message-ID: Date: Fri, 1 Jul 2022 13:54:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] PM / devfreq: Rework freq_table to be local to devfreq struct Content-Language: en-US To: Christian Marangi Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 'Linux Samsung SOC' , Krzysztof Kozlowski , stable@vger.kernel.org From: Marek Szyprowski In-Reply-To: <62beda74.1c69fb81.bace6.3899@mx.google.com> Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA01SaUwTURjM6y7bbbXwLBi+eKcao3KJ5xqNEUVtYkhQ8AhqtOAKVQ7TCoJR g+ABVQgqiqwcNQSpSBBxRVErWo9KCMVIOEXxaCIgjSIVlQhqux78m2++mXwzL48m5IUu42h1 7F5WE6uKVlBSsurJd4vPztf3wmcfK1vInK0dIJkW+3sXpqGhQszUp/SKmcbbeRTTn/EIMecb 7omYF4cNFKO/9hYtkyiruZdiZWVpOqXM5EuRsr9yUjAZJl2yg41WJ7Aav6XbpVGGkm7xns+a xOSn78TJKH+zDklowPPgSM17SoektBwbEBQ0lpHCYEdQfpFDwtCP4Gxxpvivpeio/o+lBIHp 21EXYehDUPzJ9ntD0zK8FF6WJzkMJJ4GD3/wIgeW4TFQm2slHXgsjgBLfZNT7o5Doa0rxEET 2BParYVOuQf2huMnO52JCMyLwNY9TDkWFPYHnU3nxBK8CCxXfiLBPBlSb1wgHAbAXTSUZ/DI cQBwIHw0bhUKuEOPmf9TZgLUnTlJCpI4GDo/V6AToflDGSHgxdBhGXTGJPBMuHrbT6ADoCy/ kxKcrtBqGyMEcIXTVTmEQMsg7ZhcUE8Hzlz+7+aDZ8+JLKTgRjwJN6I7N6IK9/+uHpGlyJON 18ZEsto5sew+X60qRhsfG+kbERdTiX7/obphs/0WKunp8zUhEY1MCGhC4SGjCozhctkOVdJ+ VhO3TRMfzWpNaDxNKjxlEeoKlRxHqvayu1l2D6v5uxXRknHJomyPrEw+9NGB+hPJuXpTx8QL p+xXCeBHV69519eSlh3V5uf2c8j4ZmxFe3XhfVIWaEiL+bJ8UmgC13V3fZGtOSfIHrBCt4u7 0hVonUv3mc9xhsR1bgP1mxa8qEnv2Lh+bYYb3pJd6LXSvypSMeh9Lj3V1TJgbu3w6W0bTtp/ wNtQvNs9NHDZw7u9l8N8lUNeLTMKUke9nZHyOlhNpTVdknTvMjZ15zQri6Z8kDTpD/E+eZ3T v3ytvB5uTYjasqiufVp+8C1MBBwy1vhtXbHp84ZGZY90TVWi12pisFVTHXR91ePiJ6tuWkNG Z2245vYqLOTgsInih+anPK+906rOm7quQkFqo1T+swiNVvULtiyIjLIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t/xu7ppD/YlGSzeK2wx9eQ3FovrX56z Wpw/v4Hd4mzTG3aLy7vmsFl87j3CaDHj/D4mi9uNK9gsFmx8xOjA6bFz1l12j02rOtk8+ras YvT4vEkugCVKz6Yov7QkVSEjv7jEVina0MJIz9DSQs/IxFLP0Ng81srIVEnfziYlNSezLLVI 3y5BL2PF8pfsBZ+KKhpOPGZvYJwb3cXIySEhYCKxuHUBWxcjF4eQwFJGiVc/ulkhEjISJ6c1 QNnCEn+udUEVvWeUOLRmJnsXIwcHr4CdxN11lSA1LAIqEof/bGECsXkFBCVOznzCAmKLCiRL NG85xARSLiwQInHzRTBImFlAXOLWk/lg5SICOhLtPfdZQMYzC2xjktj0ZS8zxK6PjBILrx0B G8QmYCjR9RbkCE4OTgFLiXOr/zNCTDKT6NraBWXLSzRvnc08gVFoFpI7ZiFZOAtJyywkLQsY WVYxiqSWFuem5xYb6RUn5haX5qXrJefnbmIExt+2Yz+37GBc+eqj3iFGJg7GQ4wSHMxKIrxs 8/YmCfGmJFZWpRblxxeV5qQWH2I0BQbGRGYp0eR8YALIK4k3NDMwNTQxszQwtTQzVhLn9Szo SBQSSE8sSc1OTS1ILYLpY+LglGpgEpduehO27Qcr+xXPk583PVsYsVsv5nJu36GyotpmjoTV FS+4WjU1RGXFu7+u5uqLzrovfIBrsfvTPr6ND+TnVQplfZq0WDWgoHf2gUCWRwtudMTWyoeu OBi6NvrrwoxPH7gPRM49dz2MScIsJKicl6F5z63EQ+/ub+6N4BDMM/ex3mD0sj3ztIjt0mWn fufpbc147ntWxpux0Sfs2CadmpcuM4MedfzLYhK4WLhg5lSDOzrfPx6cs/tH5oXHgVeOCM3M 3/zy5u2pKw6pLLgdtc9P0EHVtFslyvRu1tEgxXf27HN/Km0VrFeYvLbhmEXJir60/2zChTwh fG4XYh9tOXzn02atH76hH222ltW4KLEUZyQaajEXFScCAJz/mbNIAwAA X-CMS-MailID: 20220701115414eucas1p10a3278ddcc4503ad2674b62e3514345c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20220701080154eucas1p2c545476306b23c62ebddcabf2616b828 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20220701080154eucas1p2c545476306b23c62ebddcabf2616b828 References: <20220619220351.29891-1-ansuelsmth@gmail.com> <4ea890c9-7df1-b5b2-0e13-0f23eb452d49@samsung.com> <62beda74.1c69fb81.bace6.3899@mx.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.07.2022 13:28, Christian Marangi wrote: > On Fri, Jul 01, 2022 at 10:01:52AM +0200, Marek Szyprowski wrote: >> On 20.06.2022 00:03, Christian Marangi wrote: >>> On a devfreq PROBE_DEFER, the freq_table in the driver profile struct, >>> is never reset and may be leaved in an undefined state. >>> >>> This comes from the fact that we store the freq_table in the driver >>> profile struct that is commonly defined as static and not reset on >>> PROBE_DEFER. >>> We currently skip the reinit of the freq_table if we found >>> it's already defined since a driver may declare his own freq_table. >>> >>> This logic is flawed in the case devfreq core generate a freq_table, set >>> it in the profile struct and then PROBE_DEFER, freeing the freq_table. >>> In this case devfreq will found a NOT NULL freq_table that has been >>> freed, skip the freq_table generation and probe the driver based on the >>> wrong table. >>> >>> To fix this and correctly handle PROBE_DEFER, use a local freq_table and >>> max_state in the devfreq struct and never modify the freq_table present >>> in the profile struct if it does provide it. >>> >>> Fixes: 0ec09ac2cebe ("PM / devfreq: Set the freq_table of devfreq device") >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Christian Marangi >>> --- >> This patch landed in linux next-20220630 as commit b5d281f6c16d ("PM / >> devfreq: Rework freq_table to be local to devfreq struct"). >> Unfortunately it causes the following regression on my Exynos based test >> systems: >> >> 8<--- cut here --- >> Unable to handle kernel NULL pointer dereference at virtual address 00000000 >> [00000000] *pgd=00000000 >> Internal error: Oops: 5 [#1] PREEMPT SMP ARM >> Modules linked in: >> CPU: 3 PID: 49 Comm: kworker/u8:3 Not tainted 5.19.0-rc4-next-20220630 #5312 >> Hardware name: Samsung Exynos (Flattened Device Tree) >> Workqueue: events_unbound deferred_probe_work_func >> PC is at exynos_bus_probe+0x604/0x684 >> LR is at device_add+0x14c/0x908 >> pc : []    lr : []    psr: 80000053 >> ... >> Process kworker/u8:3 (pid: 49, stack limit = 0x(ptrval)) >> Stack: (0xf0a15d30 to 0xf0a16000) >> ... >>  exynos_bus_probe from platform_probe+0x5c/0xb8 >>  platform_probe from really_probe+0xe0/0x414 >>  really_probe from __driver_probe_device+0xa0/0x208 >>  __driver_probe_device from driver_probe_device+0x30/0xc0 >>  driver_probe_device from __device_attach_driver+0xa4/0x11c >>  __device_attach_driver from bus_for_each_drv+0x7c/0xc0 >>  bus_for_each_drv from __device_attach+0xac/0x20c >>  __device_attach from bus_probe_device+0x88/0x90 >>  bus_probe_device from deferred_probe_work_func+0x98/0xe0 >>  deferred_probe_work_func from process_one_work+0x288/0x774 >>  process_one_work from worker_thread+0x44/0x504 >>  worker_thread from kthread+0xf4/0x128 >>  kthread from ret_from_fork+0x14/0x2c >> Exception stack(0xf0a15fb0 to 0xf0a15ff8) >> ... >> ---[ end trace 0000000000000000 ]--- >> >> This issue is caused by bus->devfreq->profile->freq_table being NULL here: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/devfreq/exynos-bus.c?h=next-20220630#n451 >> >> > I just checked this and the bug is caused by a simple pr_info... > > Can you test the following patch just to make sure? Yes, this fixes the issue. Thanks! Feel free to add: Reported-by: Marek Szyprowski Tested-by: Marek Szyprowski > diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c > index b5615e667e31..79725bbb4bb0 100644 > --- a/drivers/devfreq/exynos-bus.c > +++ b/drivers/devfreq/exynos-bus.c > @@ -447,9 +447,9 @@ static int exynos_bus_probe(struct platform_device *pdev) > } > } > > - max_state = bus->devfreq->profile->max_state; > - min_freq = (bus->devfreq->profile->freq_table[0] / 1000); > - max_freq = (bus->devfreq->profile->freq_table[max_state - 1] / 1000); > + max_state = bus->devfreq->max_state; > + min_freq = (bus->devfreq->freq_table[0] / 1000); > + max_freq = (bus->devfreq->freq_table[max_state - 1] / 1000); > pr_info("exynos-bus: new bus device registered: %s (%6ld KHz ~ %6ld KHz)\n", > dev_name(dev), min_freq, max_freq); > > >>> drivers/devfreq/devfreq.c | 71 ++++++++++++++---------------- >>> drivers/devfreq/governor_passive.c | 14 +++--- >>> include/linux/devfreq.h | 5 +++ >>> 3 files changed, 46 insertions(+), 44 deletions(-) >>> >>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c >>> index 01474daf4548..2e2b3b414d67 100644 >>> --- a/drivers/devfreq/devfreq.c >>> +++ b/drivers/devfreq/devfreq.c >>> @@ -123,7 +123,7 @@ void devfreq_get_freq_range(struct devfreq *devfreq, >>> unsigned long *min_freq, >>> unsigned long *max_freq) >>> { >>> - unsigned long *freq_table = devfreq->profile->freq_table; >>> + unsigned long *freq_table = devfreq->freq_table; >>> s32 qos_min_freq, qos_max_freq; >>> >>> lockdep_assert_held(&devfreq->lock); >>> @@ -133,11 +133,11 @@ void devfreq_get_freq_range(struct devfreq *devfreq, >>> * The devfreq drivers can initialize this in either ascending or >>> * descending order and devfreq core supports both. >>> */ >>> - if (freq_table[0] < freq_table[devfreq->profile->max_state - 1]) { >>> + if (freq_table[0] < freq_table[devfreq->max_state - 1]) { >>> *min_freq = freq_table[0]; >>> - *max_freq = freq_table[devfreq->profile->max_state - 1]; >>> + *max_freq = freq_table[devfreq->max_state - 1]; >>> } else { >>> - *min_freq = freq_table[devfreq->profile->max_state - 1]; >>> + *min_freq = freq_table[devfreq->max_state - 1]; >>> *max_freq = freq_table[0]; >>> } >>> >>> @@ -169,8 +169,8 @@ static int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq) >>> { >>> int lev; >>> >>> - for (lev = 0; lev < devfreq->profile->max_state; lev++) >>> - if (freq == devfreq->profile->freq_table[lev]) >>> + for (lev = 0; lev < devfreq->max_state; lev++) >>> + if (freq == devfreq->freq_table[lev]) >>> return lev; >>> >>> return -EINVAL; >>> @@ -178,7 +178,6 @@ static int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq) >>> >>> static int set_freq_table(struct devfreq *devfreq) >>> { >>> - struct devfreq_dev_profile *profile = devfreq->profile; >>> struct dev_pm_opp *opp; >>> unsigned long freq; >>> int i, count; >>> @@ -188,25 +187,22 @@ static int set_freq_table(struct devfreq *devfreq) >>> if (count <= 0) >>> return -EINVAL; >>> >>> - profile->max_state = count; >>> - profile->freq_table = devm_kcalloc(devfreq->dev.parent, >>> - profile->max_state, >>> - sizeof(*profile->freq_table), >>> - GFP_KERNEL); >>> - if (!profile->freq_table) { >>> - profile->max_state = 0; >>> + devfreq->max_state = count; >>> + devfreq->freq_table = devm_kcalloc(devfreq->dev.parent, >>> + devfreq->max_state, >>> + sizeof(*devfreq->freq_table), >>> + GFP_KERNEL); >>> + if (!devfreq->freq_table) >>> return -ENOMEM; >>> - } >>> >>> - for (i = 0, freq = 0; i < profile->max_state; i++, freq++) { >>> + for (i = 0, freq = 0; i < devfreq->max_state; i++, freq++) { >>> opp = dev_pm_opp_find_freq_ceil(devfreq->dev.parent, &freq); >>> if (IS_ERR(opp)) { >>> - devm_kfree(devfreq->dev.parent, profile->freq_table); >>> - profile->max_state = 0; >>> + devm_kfree(devfreq->dev.parent, devfreq->freq_table); >>> return PTR_ERR(opp); >>> } >>> dev_pm_opp_put(opp); >>> - profile->freq_table[i] = freq; >>> + devfreq->freq_table[i] = freq; >>> } >>> >>> return 0; >>> @@ -246,7 +242,7 @@ int devfreq_update_status(struct devfreq *devfreq, unsigned long freq) >>> >>> if (lev != prev_lev) { >>> devfreq->stats.trans_table[ >>> - (prev_lev * devfreq->profile->max_state) + lev]++; >>> + (prev_lev * devfreq->max_state) + lev]++; >>> devfreq->stats.total_trans++; >>> } >>> >>> @@ -835,6 +831,9 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> if (err < 0) >>> goto err_dev; >>> mutex_lock(&devfreq->lock); >>> + } else { >>> + devfreq->freq_table = devfreq->profile->freq_table; >>> + devfreq->max_state = devfreq->profile->max_state; >>> } >>> >>> devfreq->scaling_min_freq = find_available_min_freq(devfreq); >>> @@ -870,8 +869,8 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> >>> devfreq->stats.trans_table = devm_kzalloc(&devfreq->dev, >>> array3_size(sizeof(unsigned int), >>> - devfreq->profile->max_state, >>> - devfreq->profile->max_state), >>> + devfreq->max_state, >>> + devfreq->max_state), >>> GFP_KERNEL); >>> if (!devfreq->stats.trans_table) { >>> mutex_unlock(&devfreq->lock); >>> @@ -880,7 +879,7 @@ struct devfreq *devfreq_add_device(struct device *dev, >>> } >>> >>> devfreq->stats.time_in_state = devm_kcalloc(&devfreq->dev, >>> - devfreq->profile->max_state, >>> + devfreq->max_state, >>> sizeof(*devfreq->stats.time_in_state), >>> GFP_KERNEL); >>> if (!devfreq->stats.time_in_state) { >>> @@ -1665,9 +1664,9 @@ static ssize_t available_frequencies_show(struct device *d, >>> >>> mutex_lock(&df->lock); >>> >>> - for (i = 0; i < df->profile->max_state; i++) >>> + for (i = 0; i < df->max_state; i++) >>> count += scnprintf(&buf[count], (PAGE_SIZE - count - 2), >>> - "%lu ", df->profile->freq_table[i]); >>> + "%lu ", df->freq_table[i]); >>> >>> mutex_unlock(&df->lock); >>> /* Truncate the trailing space */ >>> @@ -1690,7 +1689,7 @@ static ssize_t trans_stat_show(struct device *dev, >>> >>> if (!df->profile) >>> return -EINVAL; >>> - max_state = df->profile->max_state; >>> + max_state = df->max_state; >>> >>> if (max_state == 0) >>> return sprintf(buf, "Not Supported.\n"); >>> @@ -1707,19 +1706,17 @@ static ssize_t trans_stat_show(struct device *dev, >>> len += sprintf(buf + len, " :"); >>> for (i = 0; i < max_state; i++) >>> len += sprintf(buf + len, "%10lu", >>> - df->profile->freq_table[i]); >>> + df->freq_table[i]); >>> >>> len += sprintf(buf + len, " time(ms)\n"); >>> >>> for (i = 0; i < max_state; i++) { >>> - if (df->profile->freq_table[i] >>> - == df->previous_freq) { >>> + if (df->freq_table[i] == df->previous_freq) >>> len += sprintf(buf + len, "*"); >>> - } else { >>> + else >>> len += sprintf(buf + len, " "); >>> - } >>> - len += sprintf(buf + len, "%10lu:", >>> - df->profile->freq_table[i]); >>> + >>> + len += sprintf(buf + len, "%10lu:", df->freq_table[i]); >>> for (j = 0; j < max_state; j++) >>> len += sprintf(buf + len, "%10u", >>> df->stats.trans_table[(i * max_state) + j]); >>> @@ -1743,7 +1740,7 @@ static ssize_t trans_stat_store(struct device *dev, >>> if (!df->profile) >>> return -EINVAL; >>> >>> - if (df->profile->max_state == 0) >>> + if (df->max_state == 0) >>> return count; >>> >>> err = kstrtoint(buf, 10, &value); >>> @@ -1751,11 +1748,11 @@ static ssize_t trans_stat_store(struct device *dev, >>> return -EINVAL; >>> >>> mutex_lock(&df->lock); >>> - memset(df->stats.time_in_state, 0, (df->profile->max_state * >>> + memset(df->stats.time_in_state, 0, (df->max_state * >>> sizeof(*df->stats.time_in_state))); >>> memset(df->stats.trans_table, 0, array3_size(sizeof(unsigned int), >>> - df->profile->max_state, >>> - df->profile->max_state)); >>> + df->max_state, >>> + df->max_state)); >>> df->stats.total_trans = 0; >>> df->stats.last_update = get_jiffies_64(); >>> mutex_unlock(&df->lock); >>> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c >>> index 72c67979ebe1..ce24a262aa16 100644 >>> --- a/drivers/devfreq/governor_passive.c >>> +++ b/drivers/devfreq/governor_passive.c >>> @@ -131,18 +131,18 @@ static int get_target_freq_with_devfreq(struct devfreq *devfreq, >>> goto out; >>> >>> /* Use interpolation if required opps is not available */ >>> - for (i = 0; i < parent_devfreq->profile->max_state; i++) >>> - if (parent_devfreq->profile->freq_table[i] == *freq) >>> + for (i = 0; i < parent_devfreq->max_state; i++) >>> + if (parent_devfreq->freq_table[i] == *freq) >>> break; >>> >>> - if (i == parent_devfreq->profile->max_state) >>> + if (i == parent_devfreq->max_state) >>> return -EINVAL; >>> >>> - if (i < devfreq->profile->max_state) { >>> - child_freq = devfreq->profile->freq_table[i]; >>> + if (i < devfreq->max_state) { >>> + child_freq = devfreq->freq_table[i]; >>> } else { >>> - count = devfreq->profile->max_state; >>> - child_freq = devfreq->profile->freq_table[count - 1]; >>> + count = devfreq->max_state; >>> + child_freq = devfreq->freq_table[count - 1]; >>> } >>> >>> out: >>> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h >>> index dc10bee75a72..34aab4dd336c 100644 >>> --- a/include/linux/devfreq.h >>> +++ b/include/linux/devfreq.h >>> @@ -148,6 +148,8 @@ struct devfreq_stats { >>> * reevaluate operable frequencies. Devfreq users may use >>> * devfreq.nb to the corresponding register notifier call chain. >>> * @work: delayed work for load monitoring. >>> + * @freq_table: current frequency table used by the devfreq driver. >>> + * @max_state: count of entry present in the frequency table. >>> * @previous_freq: previously configured frequency value. >>> * @last_status: devfreq user device info, performance statistics >>> * @data: Private data of the governor. The devfreq framework does not >>> @@ -185,6 +187,9 @@ struct devfreq { >>> struct notifier_block nb; >>> struct delayed_work work; >>> >>> + unsigned long *freq_table; >>> + unsigned int max_state; >>> + >>> unsigned long previous_freq; >>> struct devfreq_dev_status last_status; >>> >> Best regards >> -- >> Marek Szyprowski, PhD >> Samsung R&D Institute Poland >> Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland