From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A732362156 for ; Wed, 21 Jan 2026 19:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769024702; cv=none; b=CrOi+2cCPAWSPIgn9crJgG/kE12TJMIpDuBtmH7mwW7uOywncOgxOnhldMbPT4UxDqQDora3LO9ilCildCby00hKekMCzklQV0LquttcVGurVz2cL8h9/VqlyxihdcX03eaZAINzZcP1U4a1Kym/9xSy4sBnq5Hc4uBCLjSCX98= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769024702; c=relaxed/simple; bh=ykOJXdnRPdORkrcuM4LDP6Fwb8+CG51exR/43qlXuAw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NHEEQnuDbpFYsff0CnEIZ66Mp7HbmU0mOZ/5+uB+UPogixqEjqXixXCskmBTHKNxPwVUZwsNTsKwr392lxwIe1A2zUX4KURMX5EsZVTK646Vsz5TSAP++g55QN+WvUAKw3WAgN+4KVBS5lxAtoj5P3Tg2zkJlsJXhcB1SvO2AqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com; spf=none smtp.mailfrom=mojatatu.com; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b=m/gLvpKm; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b="m/gLvpKm" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-121a0bcd376so586992c88.0 for ; Wed, 21 Jan 2026 11:44:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20230601.gappssmtp.com; s=20230601; t=1769024698; x=1769629498; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ecdrB4zSMEy5aBv8OAslEgazFoiJdmaPpZodoGqi+h0=; b=m/gLvpKmxspQ32YdnwcEX3KVnmdoNdVcKjtGLCVlDThBtYQeXf2g2V8FCjkPFrDEEO b198E8/2c/OLB9rKKApQoKfzavgUvp34diP7qKde56/X6wYr4KtE52H3SIZr3HE/1Vc/ 3J4+qe2OMoEx7W4IHxqyKcGspaRMItEoD3WEbaXDG8711dmKPILy8S50XcTfhkJpXkyE 3yXlrxQXIF3KvYap/jbNy1EYv1y7Ev52fK+5mGiQX1SylTaGJmQOCSP4fymRafPiUjkx loR88taQbXx9jq2jX0mbJWW1Gw0ByfMgYzPsgfKLIsLPQjxaBGTokOx60uvX0lzAaeYz VGEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769024698; x=1769629498; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ecdrB4zSMEy5aBv8OAslEgazFoiJdmaPpZodoGqi+h0=; b=vEGtfkaMpajx5dnSe7u1n2wNMJ70wUQA+PtZMsY443bLxKiuSukurKX4K2rzA62+ln AfDecdMdvHmsB2yKB7BESuTq/dkKcw8M2utObwd0xsK8IdrsWwK78Vt5JLZvGFbU+APW zsssrx5uDq+eFA/NQ49VQN4HCkvps8B/wZXFG1/sSBTvPZlFw1W8jCLgvN6U5aIo4gtg nOMDXVDWLlVLTUiiapBr1Sk8QJT5e2b6zVsBB+N5IaTRavfrAztVX6aBizWliVnkcLJ9 AoL/4lYVG+I3ruquwSSr7s9qQn1dk9u1gSZggCWFoOjQf2c5pHojH1GnwiUrnUnqXSh/ mYVw== X-Forwarded-Encrypted: i=1; AJvYcCWQNxnzZfMQ7CRXhkjnxUu3vo90/iBajbVf1m5HLpcKv+MzfyvAkwK0wcNyIpLpHzKBF/K/90rvM/mmOT8=@vger.kernel.org X-Gm-Message-State: AOJu0YxScatFVk/WmUbvin9FYPmECerUQ/o8YZZn2JZ2wfkBbeOMyRFD yTOVjrz6HFKIhJzOMvW81My5i8vHwTu6Z3QcrepsH1ms8vw+OaM+MP6xeVtkswjxfw== X-Gm-Gg: AZuq6aLRM3LGOjmahdzjaWEVo62pu9XNdSOEYN5Ik9iKXMjIDDuf3tM/L57R3kWMsVx lkyDiy16aFWOR3BLy1sS3xlTUcJNfT8qBVfz2gMbwj7k6b+Q5tbLlDfAbcifrAlxZI5bbIcUbi6 RLhIcBtXZVa/gfcUHH3SOsd1qXvaPRQx5BKmyfiklu3ZIwtPLrVkCCYShRZKrLsCFu/8ECLKke6 hEEGDuNbHPHYkKDWojhzyReR4fjvbclE/fEIBZ/ffdulQSjceAEkKv8uucjYZI/GrPAQoLQNDvp GVopFf+qLW+3pCnsbg/CKn+k/PT9VQMbn+GXGcudiozikrKubtyIIM9kEN5vt/Cm/excNE/oDOz NoDLhGQQ5juwF18r/AXLLcuz2pjPobspqZC5BTyUqG9ipMSZJnGmmDM4ABuMt+yhIFi5KeZ7otv FLZ+BEHUbPnIHx8VzK+MXNCQ== X-Received: by 2002:a05:7022:914:b0:119:e56b:c75a with SMTP id a92af1059eb24-1246aad1e60mr4237514c88.31.1769024697979; Wed, 21 Jan 2026 11:44:57 -0800 (PST) Received: from ?IPV6:2804:14d:5c54:4efb::1c9d? ([2804:14d:5c54:4efb::1c9d]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244aefac48sm23814082c88.11.2026.01.21.11.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 11:44:57 -0800 (PST) Message-ID: Date: Wed, 21 Jan 2026 16:44:51 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3 6/7] net/sched: act_gate: reject empty schedule list To: Paul Moses , netdev@vger.kernel.org Cc: Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260121131954.2710459-1-p@1g4.org> <20260121131954.2710459-7-p@1g4.org> Content-Language: en-US From: Victor Nogueira In-Reply-To: <20260121131954.2710459-7-p@1g4.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/01/2026 10:20, Paul Moses wrote: > Reject empty schedules (num_entries == 0) so next_entry is always valid and > RCU readers/timer logic never walk an empty list. taprio enforces the same > constraint on schedules (sch_taprio.c, commit 09dbdf28f9f9fa). > > Fixes: a51c328df310 ("net: qos: introduce a gate control flow action") > Signed-off-by: Paul Moses > Cc: stable@vger.kernel.org > --- > net/sched/act_gate.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/sched/act_gate.c b/net/sched/act_gate.c > index 48ff378bb051a..e4134b9a4a314 100644 > --- a/net/sched/act_gate.c > +++ b/net/sched/act_gate.c > @@ -509,6 +509,12 @@ static int tcf_gate_init(struct net *net, struct nlattr *nla, > cycletime_ext = nla_get_u64(tb[TCA_GATE_CYCLE_TIME_EXT]); > p->tcfg_cycletime_ext = cycletime_ext; > > + if (p->num_entries == 0) { > + NL_SET_ERR_MSG(extack, "The entry list is empty"); > + err = -EINVAL; > + goto release_mem; > + } It would be simpler to check this in parse_gate_list. That way you could return -EINVAL there directly in case 0 entries were passed. cheers, Victor