mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Alexander Graf <graf@amazon.com>, Priscilla Lam <prl@amazon.com>,
	 maz@kernel.org, oliver.upton@linux.dev
Cc: christoffer.dall@arm.com, gurugubs@amazon.com,
	jgrall@amazon.co.uk,  joey.gouly@arm.com, kvmarm@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
	yuzenghui@huawei.com
Subject: Re: [PATCH] KVM: arm64: Implement KVM_TRANSLATE ioctl for arm64
Date: Tue, 23 Sep 2025 10:02:38 +0100	[thread overview]
Message-ID: <c8a8ddbc4b1c53429748d239f2a8461f180a5133.camel@infradead.org> (raw)
In-Reply-To: <97759f51-385b-4ce4-8766-d00ed5af580b@amazon.com>

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On Tue, 2025-09-23 at 10:39 +0200, Alexander Graf wrote:
> 
> All modern OSs constrain themselves to only ISV enabled MMIO 
> instructions.

Why? Such does not appear to be required by the architecture, AFAICT?

And what is "MMIO" architecturally anyway? Using LDP is actually fine
on MMIO, if a PCI BAR is passed through to a guest (and assuming there
are no ordering dependencies on the loads). It's the fact that it's
missing from stage2 page tables and causes a guest exit which is the
problem.

Other than lying to a compiler and *pretending* there are ordering
constraints, or explicitly using inline asm, how would a guest OS
*prevent* the compiler from using problematic instructions?

>  NISV is really only useful to run non hypervisor 
> enlightened guests. Did you encounter a real world OS that was causing 
> NISV faults? And if so, what was causing these? It's most likely a 
> driver or OS bug.

The Windows CRB TPM driver uses LDP. Even if it *were* forbidden by the
architecture, the track record of getting Microsoft to fix bugs *even*
when they are egregious violations of both specifications and common
sense is... poor.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]

  reply	other threads:[~2025-09-23  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22 20:24 Priscilla Lam
2025-09-22 23:27 ` Oliver Upton
2025-09-23  8:03 ` Marc Zyngier
2025-09-23  8:29   ` Priscilla Lam
2025-09-23  8:39     ` Alexander Graf
2025-09-23  9:02       ` David Woodhouse [this message]
2025-09-23 18:05         ` Christoffer Dall
2025-09-23  9:25     ` Marc Zyngier
2025-09-25  5:21       ` Priscilla Lam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8a8ddbc4b1c53429748d239f2a8461f180a5133.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=christoffer.dall@arm.com \
    --cc=graf@amazon.com \
    --cc=gurugubs@amazon.com \
    --cc=jgrall@amazon.co.uk \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=prl@amazon.com \
    --cc=suzuki.poulose@arm.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®